From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935453AbeAKRup (ORCPT + 1 other); Thu, 11 Jan 2018 12:50:45 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:44710 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934484AbeAKRul (ORCPT ); Thu, 11 Jan 2018 12:50:41 -0500 X-Google-Smtp-Source: ACJfBovHpsB5eX8kuO0hHWYcOLp0D4mt1e6kdY3d2NOicc0mrQj/Aiy1fcIRDtfrxcFp1gp+cbGOTuGrTjscVGXwQhA= MIME-Version: 1.0 In-Reply-To: <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> References: <1514202808-29747-1-git-send-email-oleksandrs@mellanox.com> <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> From: Joel Stanley Date: Thu, 11 Jan 2018 09:50:19 -0800 X-Google-Sender-Auth: i2FGUNjqrvAl5I1eMXxy7JhhOA0 Message-ID: Subject: Re: [patch v15 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver To: Oleksandr Shamray Cc: Greg KH , Arnd Bergmann , Linux Kernel Mailing List , Linux ARM , devicetree , OpenBMC Maillist , =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Tobias Klauser , linux-serial@vger.kernel.org, Vadim Pasternak , system-sw-low-level@mellanox.com, Rob Herring , openocd-devel-owner@lists.sourceforge.net, linux-api@vger.kernel.org, "David S . Miller" , mchehab@kernel.org, Jiri Pirko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Dec 25, 2017 at 3:53 AM, Oleksandr Shamray wrote: > It has been tested on Mellanox system with BMC equipped with > Aspeed 2520 SoC for programming CPLD devices. > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > Acked-by: Rob Herring > --- > v14->v15 > v13->v14 > v12->v13 > v11->v12 > v10->v11 > v9->v10 > v8->v9 > v7->v8 > Comments pointed by pointed by Joel Stanley > - Change compatible string to ast2400 and ast2000 > > V6->v7 > Comments pointed by Tobias Klauser > - Fix spell "Doccumentation" -> "Documentation" > > v5->v6 > Comments pointed by Tobias Klauser > - Small nit: s/documentation/Documentation/ > > v4->v5 > > V3->v4 > Comments pointed by Rob Herring > - delete unnecessary "status" and "reg-shift" descriptions in > bndings file > > v2->v3 > Comments pointed by Rob Herring > - split Aspeed jtag driver and binding to sepatrate patches > - delete unnecessary "status" and "reg-shift" descriptions in > bndings file > --- > .../devicetree/bindings/jtag/aspeed-jtag.txt | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > > diff --git a/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > new file mode 100644 > index 0000000..8cfc610 > --- /dev/null > +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > @@ -0,0 +1,18 @@ > +Aspeed JTAG driver for ast2400 and ast2500 SoC > + > +Required properties: > +- compatible: Should be one of > + - "aspeed,ast2400-jtag" > + - "aspeed,ast2500-jtag" > +- reg contains the offset and length of the JTAG memory > + region > +- clocks root clock of bus, should reference the APB clock > +- interrupts should contain JTAG controller interrupt > + > +Example: > +jtag: jtag@1e6e4000 { > + compatible = "aspeed,ast2500-jtag"; > + reg = <0x1e6e4000 0x1c>; > + clocks = <&clk_apb>; We've now got a proper clock driver upstream. Can you update the example to match the newly added bindings? clocks = <&syscon ASPEED_CLK_APB>; Cheers, Joel From mboxrd@z Thu Jan 1 00:00:00 1970 From: joel@jms.id.au (Joel Stanley) Date: Thu, 11 Jan 2018 09:50:19 -0800 Subject: [patch v15 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver In-Reply-To: <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> References: <1514202808-29747-1-git-send-email-oleksandrs@mellanox.com> <1514202808-29747-4-git-send-email-oleksandrs@mellanox.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Dec 25, 2017 at 3:53 AM, Oleksandr Shamray wrote: > It has been tested on Mellanox system with BMC equipped with > Aspeed 2520 SoC for programming CPLD devices. > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > Acked-by: Rob Herring > --- > v14->v15 > v13->v14 > v12->v13 > v11->v12 > v10->v11 > v9->v10 > v8->v9 > v7->v8 > Comments pointed by pointed by Joel Stanley > - Change compatible string to ast2400 and ast2000 > > V6->v7 > Comments pointed by Tobias Klauser > - Fix spell "Doccumentation" -> "Documentation" > > v5->v6 > Comments pointed by Tobias Klauser > - Small nit: s/documentation/Documentation/ > > v4->v5 > > V3->v4 > Comments pointed by Rob Herring > - delete unnecessary "status" and "reg-shift" descriptions in > bndings file > > v2->v3 > Comments pointed by Rob Herring > - split Aspeed jtag driver and binding to sepatrate patches > - delete unnecessary "status" and "reg-shift" descriptions in > bndings file > --- > .../devicetree/bindings/jtag/aspeed-jtag.txt | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > > diff --git a/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > new file mode 100644 > index 0000000..8cfc610 > --- /dev/null > +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.txt > @@ -0,0 +1,18 @@ > +Aspeed JTAG driver for ast2400 and ast2500 SoC > + > +Required properties: > +- compatible: Should be one of > + - "aspeed,ast2400-jtag" > + - "aspeed,ast2500-jtag" > +- reg contains the offset and length of the JTAG memory > + region > +- clocks root clock of bus, should reference the APB clock > +- interrupts should contain JTAG controller interrupt > + > +Example: > +jtag: jtag at 1e6e4000 { > + compatible = "aspeed,ast2500-jtag"; > + reg = <0x1e6e4000 0x1c>; > + clocks = <&clk_apb>; We've now got a proper clock driver upstream. Can you update the example to match the newly added bindings? clocks = <&syscon ASPEED_CLK_APB>; Cheers, Joel