From: Joel Stanley <joel@jms.id.au>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
"Claudiu.Beznea@microchip.com" <Claudiu.Beznea@microchip.com>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>
Subject: Re: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula
Date: Wed, 15 Sep 2021 03:07:18 +0000 [thread overview]
Message-ID: <CACPK8XfN9YxTveoOVUFoJjq1_R_8mdvDQnF+DOVvkNaosnKN0g@mail.gmail.com> (raw)
In-Reply-To: <HK0PR06MB33801C3DADFD87363C09BFAFF2DB9@HK0PR06MB3380.apcprd06.prod.outlook.com>
On Wed, 15 Sept 2021 at 02:52, Ryan Chen <ryan_chen@aspeedtech.com> wrote:
>
> > -----Original Message-----
> > From: Stephen Boyd <sboyd@kernel.org>
> > Sent: Wednesday, September 15, 2021 9:17 AM
> > To: Claudiu.Beznea@microchip.com; Ryan Chen
> > <ryan_chen@aspeedtech.com>; andrew@aj.id.au; joel@jms.id.au;
> > linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org;
> > mturquette@baylibre.com
> > Subject: RE: [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula
> >
> > Quoting Ryan Chen (2021-09-12 22:31:46)
> > > > > + if (hwstrap & BIT(10))
> > > > > + m = 0x5F;
> > > > > + else {
> > > > > + if (hwstrap & BIT(8))
> > > >
> > > > You may write it directly:
> > > > else if (hwstrap & BIT(8))
> > > >
> > > Hello,
> > > Like I commit message M = SCU500[10] ? 0x5F : SCU500[8] ? 0xBF :
> > SCU200[12:0]
> > > it need keep from register read, if BIT(8)/BIT(10) not 1.
> > >
> >
> > I don't get it. The review comment was that the else { if (...) can be collapsed
> > into an else if (..) What does commit message have to do with it?
> Sorry for confuse.
> Or do you mean like following modification?
>
> if (hwstrap & BIT(10))
> m = 0x5F;
> else if (hwstrap & BIT(8))
> m = 0xBF;
Yep!
Take a look at my review of v1. I wrote it out there.
next prev parent reply other threads:[~2021-09-15 3:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 9:18 [PATCHv2] clk:aspeed:Fix AST2600 hpll calculate formula Ryan Chen
2021-09-13 5:26 ` Claudiu.Beznea
2021-09-13 5:31 ` Ryan Chen
2021-09-15 1:17 ` Stephen Boyd
2021-09-15 2:52 ` Ryan Chen
2021-09-15 3:07 ` Joel Stanley [this message]
2021-09-15 3:11 ` Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XfN9YxTveoOVUFoJjq1_R_8mdvDQnF+DOVvkNaosnKN0g@mail.gmail.com \
--to=joel@jms.id.au \
--cc=Claudiu.Beznea@microchip.com \
--cc=andrew@aj.id.au \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.