From: Joel Stanley <joel@jms.id.au>
To: Willie Thai <williethaitu@gmail.com>
Cc: Willie Thai <willie_thai@compal.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH] ARM: dts: aspeed: Add device tree for Liwu2 BMC
Date: Tue, 9 Feb 2021 12:25:16 +0000 [thread overview]
Message-ID: <CACPK8XfNrYFNy0KHjxa=nM01LV7PMnVC5U7_Wuudf_xk3tQ2iw@mail.gmail.com> (raw)
In-Reply-To: <1610358177-3874-1-git-send-email-willie_thai@compal.com>
On Mon, 11 Jan 2021 at 09:45, Willie Thai <williethaitu@gmail.com> wrote:
>
> The Liwu2 is a server platform with an ASPEED AST2500 based BMC.
You need to have a signed-off-by in your commit message.
Please make sure you run ./scripts/checkpatch.pl on your patch before
sending it.
The patch looks okay; there are some minor issues to fix that I have
mentioned below. Apologies for the delay in reviewing it.
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts | 320 ++++++++++++++++++++++++++
> 2 files changed, 321 insertions(+)
> create mode 100755 arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5a14adc..16fc64d 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1354,6 +1354,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> aspeed-bmc-arm-centriq2400-rep.dtb \
> aspeed-bmc-arm-stardragon4800-rep2.dtb \
> aspeed-bmc-bytedance-g220a.dtb \
> + aspeed-bmc-compal-liwu2.dts \
> aspeed-bmc-facebook-cmm.dtb \
> aspeed-bmc-facebook-minipack.dtb \
> aspeed-bmc-facebook-tiogapass.dtb \
> diff --git a/arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts b/arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
> new file mode 100755
> index 0000000..a93af32
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-compal-liwu2.dts
> @@ -0,0 +1,320 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> + model = "AST2500 liwu2";
> + compatible = "aspeed,ast2500";
> +
> + aliases {
> + serial4 = &uart5;
> + };
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=tty0 console=ttyS4,115200 earlyprintk";
> + };
> +
> + memory@80000000 {
> + reg = <0x80000000 0x20000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + gfx_memory: framebuffer {
> + size = <0x01000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> + };
> +
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
> + <&adc 4>, <&adc 5>, <&adc 6>, <&adc 7>,
> + <&adc 8>, <&adc 9>, <&adc 10>, <&adc 11>,
> + <&adc 12>, <&adc 13>, <&adc 14>, <&adc 15>;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + LED_FAN0_FAULT {
Node names have lower case.
> + label = "LED_FAN0_FAULT";
> + gpios = <&gpio ASPEED_GPIO(F, 4) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN1_FAULT {
> + label = "LED_FAN1_FAULT";
> + gpios = <&gpio ASPEED_GPIO(F, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN2_FAULT {
> + label = "LED_FAN2_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 2) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN3_FAULT {
> + label = "LED_FAN3_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN4_FAULT {
> + label = "LED_FAN4_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_LOW>;
> + };
> +
> + LED_FAN5_FAULT {
> + label = "LED_FAN5_FAULT";
> + gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_LOW>;
> + };
> +
> + FP_LED_STATUS_AMBER_N {
> + label = "FP_LED_STATUS_AMBER_N";
> + gpios = <&gpio ASPEED_GPIO(S, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + REAR_ID_LED_N {
> + label = "REAR_ID_LED_N";
> + gpios = <&gpio ASPEED_GPIO(S, 6) GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + status = "okay";
> + m25p,fast-read;
> + label = "bmc";
> + spi-max-frequency = <50000000>;
> +#include "openbmc-flash-layout.dtsi"
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + flash@0 {
> + status = "okay";
> + m25p,fast-read;
> + label = "pnor";
> + spi-max-frequency = <100000000>;
> + };
> +};
> +
> +&spi2 {
> + status = "okay";
> +};
> +
> +&uart5 {
> + status = "okay";
> +};
> +
> +&mac0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
> +};
> +
> +&mac1 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>;
> +};
> +
> +&adc {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + status = "okay";
> +};
> +
> +&i2c1 {
> + status = "okay";
> +
> + eeprom@54 {
> + compatible = "atmel,24c64";
> + reg = <0x54>;
> + pagesize = <32>;
> + };
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +
> + tmp75@48 {
> + compatible = "ti,tmp75";
> + reg = <0x48>;
> + };
> +
> + tmp75@4b {
> + compatible = "ti,tmp75";
> + reg = <0x4b>;
> + };
> +
> + tmp75@4c {
> + compatible = "ti,tmp75";
> + reg = <0x4c>;
> + };
> +
> + tmp75@4d {
> + compatible = "ti,tmp75";
> + reg = <0x4d>;
> + };
> +
> + vr-controller@5a {
> + compatible = "ti,tps53679";
> + reg = <0x5a>;
> + };
> +
> + vr-controller@5d {
> + compatible = "ti,tps53679";
> + reg = <0x5d>;
> + };
> +
> + vr-controller@68 {
> + compatible = "ti,tps53679";
> + reg = <0x68>;
> + };
> +
> + vr-controller@6a {
> + compatible = "ti,tps53679";
> + reg = <0x6a>;
> + };
> +
> + vr-controller@6c {
> + compatible = "ti,tps53679";
> + reg = <0x6c>;
> + };
> +
> + vr-controller@6e {
> + compatible = "ti,tps53679";
> + reg = <0x6e>;
> + };
> +
> +};
> +
> +&i2c4 {
> + status = "okay";
> +
> + eeprom@51 {
> + compatible = "atmel,24c64";
The whitespace looks wrong here.
> + reg = <0x51>;
> + pagesize = <32>;
> + };
> +};
> +
> +&i2c5 {
> + status = "okay";
> +};
> +
> +&i2c6 {
> + status = "okay";
> +};
> +
> +&i2c7 {
> + status = "okay";
> +
> + power-supply@58 {
> + compatible = "pmbus";
> + reg = <0x58>;
> + };
> +
> + power-supply@59 {
> + compatible = "pmbus";
> + reg = <0x59>;
> + };
> +};
> +
> +
> +&sdmmc {
> + status = "okay";
> +};
> +
> +&sdhci0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sd1_default>;
> +};
> +
> +&vhub {
> + status = "okay";
> +};
> +
> +&ehci1 {
> + status = "okay";
> +};
> +
> +&uhci {
> + status = "okay";
> +};
> +
> +&gfx {
> + status = "okay";
> + memory-region = <&gfx_memory>;
> +};
> +
> +&pwm_tacho {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default
> + &pinctrl_pwm2_default &pinctrl_pwm3_default
> + &pinctrl_pwm4_default &pinctrl_pwm5_default
> + &pinctrl_pwm6_default &pinctrl_pwm7_default>;
> +
> + fan@0 {
> + reg = <0x00>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x00 0x01>;
> + };
> +
> + fan@1 {
> + reg = <0x01>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x02 0x03>;
> + };
> +
> + fan@2 {
> + reg = <0x02>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x04 0x05>;
> + };
> +
> + fan@3 {
> + reg = <0x03>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x06 0x07>;
> + };
> +
> + fan@4 {
> + reg = <0x04>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x08 0x09>;
> + };
> +
> + fan@5 {
> + reg = <0x05>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x0a 0x0b>;
> + };
> +
> + fan@6 {
> + reg = <0x06>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x0c 0x0d>;
> + };
> +
> + fan@7 {
> + reg = <0x07>;
> + aspeed,fan-tach-ch = /bits/ 8 <0x0e 0x0f>;
> + };
> +
> +};
> +
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-02-09 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:41 [PATCH] ARM: dts: aspeed: Add device tree for Liwu2 BMC Willie Thai
2021-01-08 3:12 ` Joel Stanley
2021-01-11 9:42 ` Willie Thai
2021-02-09 12:25 ` Joel Stanley [this message]
2021-02-19 7:11 ` [[PATCH linux dev-5.8] ARM: dts: Aspeed: Add Compal's Liwu2 BMC machine] ARM: dts: aspeed: Add device tree for Compal's " Willie Thai
2021-03-31 6:33 ` Joel Stanley
2021-04-01 0:31 ` Andrew Jeffery
2021-08-20 2:36 ` [External Mail] Willie_Thai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XfNrYFNy0KHjxa=nM01LV7PMnVC5U7_Wuudf_xk3tQ2iw@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=willie_thai@compal.com \
--cc=williethaitu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.