From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3066FC433E0 for ; Tue, 22 Dec 2020 04:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E84F723122 for ; Tue, 22 Dec 2020 04:35:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725994AbgLVEfU (ORCPT ); Mon, 21 Dec 2020 23:35:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgLVEfT (ORCPT ); Mon, 21 Dec 2020 23:35:19 -0500 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 685A2C0613D3; Mon, 21 Dec 2020 20:34:39 -0800 (PST) Received: by mail-qk1-x734.google.com with SMTP id 19so10935848qkm.8; Mon, 21 Dec 2020 20:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PmY1Zbvh4P5fvr7vf3dYvsRt7lpuDqOG99f8cRvMW2Y=; b=GrKyju7r5Q55J4AEUPA+SDTGZg+Q0Rl8bpjFEOY7Wf1W7lvAh+3vJzCVrUF51b8DOJ zMZtths6IEkGwaO9na4a4ouDj76WbiJDCdRm8q61C6r1Ubxb+5iNB2coHyViB+Gvs14J KggaDh8uAa9rgGhcc9pFidYBFp8jRHg8c2wBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PmY1Zbvh4P5fvr7vf3dYvsRt7lpuDqOG99f8cRvMW2Y=; b=e+k2tE3pxKVC/8eNONFrh2kLFIXshFKJF05fGwj/4+/J5k+0c3OnJ4wZIjoKHrQ5PD XDf/JGhbaEVOzXO6Fb6zdlCYc/QkOj4mM2I/uRLFIE9G3S7yTN6Hp7+iCFKNeBcXlRwW Le6RIycOXQyH0Eqm1lNZm/DoYAqNIwCbAEYnk+q0vZP6msAWh+JtD9My5rc/IP8Ismxa 0XO2Rz926+kAdEb4iuI9nA7hZt1vyEVud0QSwpJxKNClYeKVpUyAkfpTDLJR6YEolpBa 86dehc5giCDS8WmoPXbfW7mCeM4vx/8+rlxbhfK3TADaaKOvuQFNafWJdqJ7WQUcvMES lWmQ== X-Gm-Message-State: AOAM530Xpoj4jOquPd+JmWREFWgGSR8UeFdwH1I2JllGxW1S0f7QgdGE ufmobPparrqJWEpPyRWjUMKG9jV4bHlVyuN7VNI= X-Google-Smtp-Source: ABdhPJwphoIU/ETccJ0+oBIrWPt5ewRHb2AZGa28DlUbwZupNShcyclpTxbkFNL6J4Za9zG8/A4dFQpfPCoTBgNIOyA= X-Received: by 2002:a05:620a:4155:: with SMTP id k21mr20507246qko.55.1608611678607; Mon, 21 Dec 2020 20:34:38 -0800 (PST) MIME-Version: 1.0 References: <20201215024542.18888-1-zev@bewilderbeest.net> <20201215024542.18888-2-zev@bewilderbeest.net> In-Reply-To: <20201215024542.18888-2-zev@bewilderbeest.net> From: Joel Stanley Date: Tue, 22 Dec 2020 04:34:26 +0000 Message-ID: Subject: Re: [PATCH 1/3] aspeed-video: add error message for unhandled interrupts To: Zev Weiss , Jae Hyun Yoo , Ryan Chen Cc: Eddie James , Mauro Carvalho Chehab , Andrew Jeffery , linux-media@vger.kernel.org, OpenBMC Maillist , Linux ARM , linux-aspeed , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote: > > This device seems to have a propensity for asserting interrupts that > aren't enabled -- in addition to the CAPTURE_COMPLETE and FRAME_COMPLETE > interrupts squashed in commit 65d270acb2d662c3346793663ac3a759eb4491b8, > COMP_READY has also been observed. Adding a message diagnosing what > happened in the event of unhandled interrupt status bits should > hopefully make the debugging process simpler for any others that pop up > in the future. Ryan, is this a known issue with the video engine hardware? > > Signed-off-by: Zev Weiss > --- > drivers/media/platform/aspeed-video.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index 7d98db1d9b52..eb02043532e3 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -562,6 +562,7 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > { > struct aspeed_video *video = arg; > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > + u32 orig_sts = sts; > > /* > * Resolution changed or signal was lost; reset the engine and > @@ -639,6 +640,10 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > if (sts & VE_INTERRUPT_FRAME_COMPLETE) > sts &= ~VE_INTERRUPT_FRAME_COMPLETE; > > + if (sts) > + dev_err_ratelimited(video->dev, "unexpected interrupt asserted:" > + " sts=%08x, orig_sts=%08x", sts, orig_sts); Do you want to do this before clearing the FRAME and CAPTURE bits? > + > return sts ? IRQ_NONE : IRQ_HANDLED; > } > > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD92C433E0 for ; Tue, 22 Dec 2020 04:36:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA93C23120 for ; Tue, 22 Dec 2020 04:36:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA93C23120 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4D0Nnv4wFkzDqDx for ; Tue, 22 Dec 2020 15:36:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::735; helo=mail-qk1-x735.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=GrKyju7r; dkim-atps=neutral Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4D0Nm60XHgzDqDl; Tue, 22 Dec 2020 15:34:42 +1100 (AEDT) Received: by mail-qk1-x735.google.com with SMTP id z11so10935113qkj.7; Mon, 21 Dec 2020 20:34:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PmY1Zbvh4P5fvr7vf3dYvsRt7lpuDqOG99f8cRvMW2Y=; b=GrKyju7r5Q55J4AEUPA+SDTGZg+Q0Rl8bpjFEOY7Wf1W7lvAh+3vJzCVrUF51b8DOJ zMZtths6IEkGwaO9na4a4ouDj76WbiJDCdRm8q61C6r1Ubxb+5iNB2coHyViB+Gvs14J KggaDh8uAa9rgGhcc9pFidYBFp8jRHg8c2wBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PmY1Zbvh4P5fvr7vf3dYvsRt7lpuDqOG99f8cRvMW2Y=; b=NnknbJ0lrPTshxaxg5+7UN/Ko3Yq8lRgZOTn7If2NVArocEKMLOk39ODOzSq+16MeV /hL5M1YruGSBGYTLu6Jldva4GfK1E2uRKPNXOM1lYoZe8rngNgKebU8qFbJ4vYLvmc1B lY0rAHOcZau/NlbmEZApEv0InAPVUM2D/yCxampejK53PAHYMf7mQMqmAV+9/IWLPLIk w4n2110vmk4KNDYSCt3S6anmSgi6uRcEmORCAIrmzSHrL62MZ0VInjIKRzffcevo75NY ZHLUO/20kjQlgYD44SHljjXQjkEJeuSn8KKsIYe2jQKjeKN8VGuJloFGkeQdb4lMEY1y GXtw== X-Gm-Message-State: AOAM530p/Zn7O7EigkLE76WifZ7JVirJus0DrWE1wvSK+gEOowmFvV/E ous6YYxiy9vo93y4bt3aJ4jC4cbKFEfJ+AyBVXo= X-Google-Smtp-Source: ABdhPJwphoIU/ETccJ0+oBIrWPt5ewRHb2AZGa28DlUbwZupNShcyclpTxbkFNL6J4Za9zG8/A4dFQpfPCoTBgNIOyA= X-Received: by 2002:a05:620a:4155:: with SMTP id k21mr20507246qko.55.1608611678607; Mon, 21 Dec 2020 20:34:38 -0800 (PST) MIME-Version: 1.0 References: <20201215024542.18888-1-zev@bewilderbeest.net> <20201215024542.18888-2-zev@bewilderbeest.net> In-Reply-To: <20201215024542.18888-2-zev@bewilderbeest.net> From: Joel Stanley Date: Tue, 22 Dec 2020 04:34:26 +0000 Message-ID: Subject: Re: [PATCH 1/3] aspeed-video: add error message for unhandled interrupts To: Zev Weiss , Jae Hyun Yoo , Ryan Chen Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Eddie James , Linux Kernel Mailing List , Mauro Carvalho Chehab , Linux ARM , linux-media@vger.kernel.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote: > > This device seems to have a propensity for asserting interrupts that > aren't enabled -- in addition to the CAPTURE_COMPLETE and FRAME_COMPLETE > interrupts squashed in commit 65d270acb2d662c3346793663ac3a759eb4491b8, > COMP_READY has also been observed. Adding a message diagnosing what > happened in the event of unhandled interrupt status bits should > hopefully make the debugging process simpler for any others that pop up > in the future. Ryan, is this a known issue with the video engine hardware? > > Signed-off-by: Zev Weiss > --- > drivers/media/platform/aspeed-video.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index 7d98db1d9b52..eb02043532e3 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -562,6 +562,7 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > { > struct aspeed_video *video = arg; > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > + u32 orig_sts = sts; > > /* > * Resolution changed or signal was lost; reset the engine and > @@ -639,6 +640,10 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > if (sts & VE_INTERRUPT_FRAME_COMPLETE) > sts &= ~VE_INTERRUPT_FRAME_COMPLETE; > > + if (sts) > + dev_err_ratelimited(video->dev, "unexpected interrupt asserted:" > + " sts=%08x, orig_sts=%08x", sts, orig_sts); Do you want to do this before clearing the FRAME and CAPTURE bits? > + > return sts ? IRQ_NONE : IRQ_HANDLED; > } > > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6334C433DB for ; Tue, 22 Dec 2020 04:36:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58FFC22B2D for ; Tue, 22 Dec 2020 04:36:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58FFC22B2D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yi7pWMkaCCgXY8TGma/yWxgNB7iEoKOaWuPYNDVrBTM=; b=1EpcwCZOaDJrqHitqsm0LIutG fJyLpwNnTuHTR4gzIRVlgFcCvnyeoOw/KnGmoIU9XqLTYWbemJEWR1sorgowQAAIxKP/Mbq6Q0lpj MjxuCsgytNLagn7Lda5UGyRVw9nbZ4m6Q/4NkJbO/eC243x6SJ/TB2HlH0dRUB6QSutp79hEsQOPV kHwzii+bWcJ+VPFP7BHDu26AwiZKG5R4fgVS+h88unMwjcfqBycrnQP0pzkWWrXyedHPPO5ABJ7jg FHkn4lPDwz34o8pFPaNpXBSPTLK6ua+dSMKLxOjXDOlguOUNZq1kcNYY06b5LMHeWilmerwmzfzfl DtkOtGS5g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krZNj-0006vR-F5; Tue, 22 Dec 2020 04:34:43 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krZNg-0006ux-Ca for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 04:34:41 +0000 Received: by mail-qk1-x729.google.com with SMTP id p14so10943501qke.6 for ; Mon, 21 Dec 2020 20:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PmY1Zbvh4P5fvr7vf3dYvsRt7lpuDqOG99f8cRvMW2Y=; b=GrKyju7r5Q55J4AEUPA+SDTGZg+Q0Rl8bpjFEOY7Wf1W7lvAh+3vJzCVrUF51b8DOJ zMZtths6IEkGwaO9na4a4ouDj76WbiJDCdRm8q61C6r1Ubxb+5iNB2coHyViB+Gvs14J KggaDh8uAa9rgGhcc9pFidYBFp8jRHg8c2wBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PmY1Zbvh4P5fvr7vf3dYvsRt7lpuDqOG99f8cRvMW2Y=; b=GY6GqPoeOaiVWBi9860L0F1FPFAu6p29Xy5NvL6YhEbRBBOsL8qMnj2VnAnn9G0gNH S8AWKF5kX9BEpILN+6kZCiPhIytu4BPpG7SEr41z2h8loHkTIYujmJogukj10bgQPl/l Xn9AsdcgkxftdeK3sEbddV6gll05GJokimLFuaP1OC2ngoFvqGip1hd6n9IN8IdiuPC7 NutksCO9IePdpQmtOC29K3q4YALxtjlmwjk3/o+vJxEIcoRTzyCg2x1CoBKgvPQKlL1R D1H3xpR/XkJHFX650hZlkYSfkbPMM0iJTs/0Li/sFZU87vOXJWqeW34bvHTRmUmWwhz+ SivQ== X-Gm-Message-State: AOAM532zbfBUM9C/OMXPGk062GQ60GWLRJ4Ly8w6bM/E8tU2sdTjlIMh Gn/upcJvbNb2ezVyQtqI7xTaS6e/fyk6LqyDyh1qxswj X-Google-Smtp-Source: ABdhPJwphoIU/ETccJ0+oBIrWPt5ewRHb2AZGa28DlUbwZupNShcyclpTxbkFNL6J4Za9zG8/A4dFQpfPCoTBgNIOyA= X-Received: by 2002:a05:620a:4155:: with SMTP id k21mr20507246qko.55.1608611678607; Mon, 21 Dec 2020 20:34:38 -0800 (PST) MIME-Version: 1.0 References: <20201215024542.18888-1-zev@bewilderbeest.net> <20201215024542.18888-2-zev@bewilderbeest.net> In-Reply-To: <20201215024542.18888-2-zev@bewilderbeest.net> From: Joel Stanley Date: Tue, 22 Dec 2020 04:34:26 +0000 Message-ID: Subject: Re: [PATCH 1/3] aspeed-video: add error message for unhandled interrupts To: Zev Weiss , Jae Hyun Yoo , Ryan Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201221_233440_453176_3811766E X-CRM114-Status: GOOD ( 21.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Eddie James , Linux Kernel Mailing List , Mauro Carvalho Chehab , Linux ARM , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 15 Dec 2020 at 02:46, Zev Weiss wrote: > > This device seems to have a propensity for asserting interrupts that > aren't enabled -- in addition to the CAPTURE_COMPLETE and FRAME_COMPLETE > interrupts squashed in commit 65d270acb2d662c3346793663ac3a759eb4491b8, > COMP_READY has also been observed. Adding a message diagnosing what > happened in the event of unhandled interrupt status bits should > hopefully make the debugging process simpler for any others that pop up > in the future. Ryan, is this a known issue with the video engine hardware? > > Signed-off-by: Zev Weiss > --- > drivers/media/platform/aspeed-video.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index 7d98db1d9b52..eb02043532e3 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -562,6 +562,7 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > { > struct aspeed_video *video = arg; > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > + u32 orig_sts = sts; > > /* > * Resolution changed or signal was lost; reset the engine and > @@ -639,6 +640,10 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) > if (sts & VE_INTERRUPT_FRAME_COMPLETE) > sts &= ~VE_INTERRUPT_FRAME_COMPLETE; > > + if (sts) > + dev_err_ratelimited(video->dev, "unexpected interrupt asserted:" > + " sts=%08x, orig_sts=%08x", sts, orig_sts); Do you want to do this before clearing the FRAME and CAPTURE bits? > + > return sts ? IRQ_NONE : IRQ_HANDLED; > } > > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel