From: Joel Stanley <joel@jms.id.au>
To: George Hung <ghung.quanta@gmail.com>
Cc: kwliu@nuvoton.com, yschu@nuvoton.com,
Benjamin Fair <benjaminfair@google.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
brandonkim@google.com, Tomer Maimon <tomer.maimon@nuvoton.com>
Subject: Re: [PATCH dev-5.10 v1] ARM: dts: nuvoton: Add Quanta GBS BMC Device Tree
Date: Fri, 12 Mar 2021 01:20:50 +0000 [thread overview]
Message-ID: <CACPK8XfW-ZMkJbfemDMiJPn=i8sSiQ8nexwj6Q0c_x68Enn5+A@mail.gmail.com> (raw)
In-Reply-To: <20210310030952.26090-1-george.hung@quantatw.com>
On Wed, 10 Mar 2021 at 03:18, George Hung <ghung.quanta@gmail.com> wrote:
>
> Add initial version of device tree for Quanta GBS
> BMC (NPCM730 SoC)
>
> Signed-off-by: George Hung <george.hung@quantatw.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/nuvoton-npcm730-gbs.dts | 1233 +++++++++++++++++++++
> 2 files changed, 1234 insertions(+)
> create mode 100644 arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index c57729f40185..82785fe2c8bf 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -340,6 +340,7 @@ dtb-$(CONFIG_ARCH_LPC32XX) += \
> lpc3250-phy3250.dtb
> dtb-$(CONFIG_ARCH_NPCM7XX) += \
> nuvoton-npcm730-gsj.dtb \
> + nuvoton-npcm730-gbs.dtb \
> nuvoton-npcm730-kudo.dtb \
> nuvoton-npcm750-evb.dtb \
> nuvoton-npcm750-runbmc-olympus.dtb
> diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> new file mode 100644
> index 000000000000..15357ae97ec4
> --- /dev/null
> +++ b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> @@ -0,0 +1,1233 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2020 Quanta Computer Inc. George.Hung@quantatw.com
> +
> +/dts-v1/;
> +#include "nuvoton-npcm730.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> + model = "Quanta GBS Board (Device Tree)";
> + compatible = "nuvoton,npcm750";
Give your machine a compatible string too. eg:
compatible = "qanta,gbs-bmc", "nuvoton,npcm750";
> +
> + ahb {
> + fiu0: spi@fb000000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi0cs1_pins>;
> + status = "okay";
> + spi-nor@0 {
> + compatible = "jedec,spi-nor";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0>;
> + spi-max-frequency = <19000000>;
> + spi-rx-bus-width = <2>;
> + label = "bmc";
> + partitions@80000000 {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + u-boot@0 {
> + label = "u-boot";
> + reg = <0x0000000 0xf0000>;
> + };
> + image-descriptor@f0000 {
> + label = "image-descriptor";
> + reg = <0xf0000 0x10000>;
> + };
> + hoth-update@100000 {
> + label = "hoth-update";
> + reg = <0x100000 0x100000>;
> + };
Is this layout common for all nuvoton openbmc machines?
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0x500000>;
> + };
> + rofs@700000 {
> + label = "rofs";
> + reg = <0x700000 0x35f0000>;
> + };
> + rwfs@3cf0000 {
> + label = "rwfs";
> + reg = <0x3cf0000 0x300000>;
> + };
> + hoth-mailbox@3ff0000 {
> + label = "hoth-mailbox";
> + reg = <0x3ff0000 0x10000>;
> + };
> + };
> + };
> + };
> +
> + gmac0: eth@f0802000 {
Please take a look at the latest version of the other nuvoton device
trees. They now follow the convention of using phandles to enable
devices. eg:
&gmac {
status = "okay";
phy-mode = "rgmii-id";
snps,eee-force-disable;
};
Please update all of the nodes to use this style.
> + status = "okay";
> + phy-mode = "rgmii-id";
> + snps,eee-force-disable;
> + };
> +
>
next prev parent reply other threads:[~2021-03-12 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 3:09 [PATCH dev-5.10 v1] ARM: dts: nuvoton: Add Quanta GBS BMC Device Tree George Hung
2021-03-12 1:20 ` Joel Stanley [this message]
2021-03-12 3:33 ` George Hung (洪忠敬)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XfW-ZMkJbfemDMiJPn=i8sSiQ8nexwj6Q0c_x68Enn5+A@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=benjaminfair@google.com \
--cc=brandonkim@google.com \
--cc=ghung.quanta@gmail.com \
--cc=kwliu@nuvoton.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tomer.maimon@nuvoton.com \
--cc=yschu@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.