From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53666C10F0B for ; Wed, 3 Apr 2019 00:23:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 236B7206C0 for ; Wed, 3 Apr 2019 00:23:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="dl06ZL/z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbfDCAXH (ORCPT ); Tue, 2 Apr 2019 20:23:07 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:42367 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfDCAXH (ORCPT ); Tue, 2 Apr 2019 20:23:07 -0400 Received: by mail-qt1-f195.google.com with SMTP id p20so17280699qtc.9; Tue, 02 Apr 2019 17:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AQU0UmSUQjCjWhQD0cwp3WsrLbAxYZS7pwvflPfeqwk=; b=dl06ZL/zBEfP9CYuwbaChO0p+5sshlqKT+3sb8LKjtyPy/lUtUTLnDdzVYKiLRy28y 8YgRlwETZAlLD4q+kFuO7qBCW1U6wIZORuj4o9KegsjCBPUgMgcFyA4w9AhCxr0n/p9h gKAH7tEBQqh/G43amUrbghj5K7vrK2hZ1Xkhs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AQU0UmSUQjCjWhQD0cwp3WsrLbAxYZS7pwvflPfeqwk=; b=klGMu2XQIAPrGZHn8w/WPD1gGmSTz5QGYh0J0liT98VC8mP0baGOetdq/FoK3QHBdH zqqit5+1K2XQlWkELnXby9RjdU9ZGFv2tBhxkCCxeVSH8pKtDzvdxEK9jwEgLvdEN4dY SKxsNkHhZbxsHpYf/olQCfzlf3ib23Vpk0a9GNvt0hP1alCbtsFDpZFKlNMxYxSCg1jW qGnSEwecIGwmh4Vg3JbdLGENcppOpEN4oyOvLpy58g/tN6WA3+VbAUwZ0Ev7awxkaFUa o+pLkGTv6MFE5yltnuayftxaDWpXQjJ8IN9qKd88uo01g77p1Mcn7YaQi1WlvLFeTBN+ WWfg== X-Gm-Message-State: APjAAAWbWCcH9qtdPOVUvoFJF014+VcTS5qZ9Mz/7/fZYr3GrQEOTsjg 4BM62HpGUKX2uufEDTibqjjwsWl4/ZrSoRImRRw= X-Google-Smtp-Source: APXvYqzEKjU95VCL3aBh7dQGGLkH45xy4YG02E4zYFPVw0Qb4b89lLs5Y78yrKQe218KtEnZXcFVyf8aG45TR7v8DYQ= X-Received: by 2002:a0c:d155:: with SMTP id c21mr60573834qvh.64.1554250985938; Tue, 02 Apr 2019 17:23:05 -0700 (PDT) MIME-Version: 1.0 References: <1554231713-14137-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1554231713-14137-1-git-send-email-linux@roeck-us.net> From: Joel Stanley Date: Wed, 3 Apr 2019 00:22:54 +0000 Message-ID: Subject: Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource To: Guenter Roeck Cc: Wim Van Sebroeck , LINUXWATCHDOG , Linux Kernel Mailing List , Nicolas Ferre , Alexandre Belloni , Florian Fainelli , Linus Walleij , Baruch Siach , Keguang Zhang , Vladimir Zapolskiy , Kevin Hilman , Matthias Brugger , Avi Fishman , Nancy Yuen , Brendan Higgins , Wan ZongShun , Michal Simek , Sylvain Lemieux , Kukjin Kim , Barry Song , Orson Zhai , Patrice Chotard , Maxime Coquelin , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Thierry Reding , Shawn Guo Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Apr 2019 at 19:02, Guenter Roeck wrote: > > Use devm_platform_ioremap_resource to reduce source code size, This is a strange name for a function that doesn't take nor return a 'struct resource'. However, the intent is welcome as many drivers do redundant checking of the platform_get_resource result before passing to devm_ioremap_resource. > improve readability, and reduce the likelyhood of bugs. > drivers/watchdog/aspeed_wdt.c | 4 +--- Acked-by: Joel Stanley Cheers, Joel