All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Andrew Jeffery <andrew@aj.id.au>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Ryan Chen <ryan_chen@aspeedtech.com>
Subject: Re: [RFC PATCH] ARM: aspeed: Add secure boot controller support
Date: Wed, 17 Nov 2021 03:03:56 +0000	[thread overview]
Message-ID: <CACPK8Xfsfz=3ByQ0jYXUe-MWs+_OxYqfUTQ5QNppPNjb9SV5_g@mail.gmail.com> (raw)
In-Reply-To: <57584776-06e7-0faf-aeb2-eab0c7c5ae1f@molgen.mpg.de>

On Tue, 16 Nov 2021 at 10:15, Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> >>> +     if (has_sbe && (security_status & SECURE_BOOT))
> >>> +             pr_info("AST2600 secure boot enabled\n");
> >>> +
> >>
> >> Maybe it is more interesting to log, when it is not enabled?
> >
> > By default the soc will boot without secure boot, and this is not a
> > problem. It is informative to know that the system has been configured
> > with secure boot as this indicates the system has it enabled, and has
> > correctly booted (otherwise you would not see any message).
>
> Maybe log a message in both cases? Linux also logs the message below on
> my old Dell Intel laptop:
>
>      [    0.000000] secureboot: Secure boot could not be determined (mode 0)

I'll print a message either way, as long as the secure boot controller
compatible was found.

Thanks for the review.

Cheers,

Joel

  reply	other threads:[~2021-11-17  3:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  8:06 [RFC PATCH] ARM: aspeed: Add secure boot controller support Joel Stanley
2021-10-23  2:25 ` Ryan Chen
2021-10-23  5:14 ` Paul Menzel
2021-11-16  5:39   ` Joel Stanley
2021-11-16 10:15     ` Paul Menzel
2021-11-17  3:03       ` Joel Stanley [this message]
2021-10-23  5:16 ` Paul Menzel
2021-10-23  5:17 ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8Xfsfz=3ByQ0jYXUe-MWs+_OxYqfUTQ5QNppPNjb9SV5_g@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=andrew@aj.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.