From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F872C388F7 for ; Wed, 28 Oct 2020 22:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2CB3246CD for ; Wed, 28 Oct 2020 22:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="krmIqsua" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbgJ1WDC (ORCPT ); Wed, 28 Oct 2020 18:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728210AbgJ1WBc (ORCPT ); Wed, 28 Oct 2020 18:01:32 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FE40C0613CF for ; Wed, 28 Oct 2020 15:01:32 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id r7so501682qkf.3 for ; Wed, 28 Oct 2020 15:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i1Avim0KcggX9IKdEMHQzMezF7Rz3tSoeLz2phO/Qtk=; b=krmIqsuarEYIqEPBm4Rt9OwNjTY2cNSHgrwW+emBvBI9j3l7zTHMq3GBEa/Uvb8ssx HSLrplTUrRl2NeeAe4RwNMyQOtfot26unJogq38S711aVf+a4RvLZ+J9LgSCRFc/cX0W +Mhvx0ovZrBsUgU5ThwXomL7XXLfgnRA6SLx0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1Avim0KcggX9IKdEMHQzMezF7Rz3tSoeLz2phO/Qtk=; b=Qnkoe+l1D5Xu+Bbx4QcSzeA2jEmoSzdvtkoxxAhiJXnn/KMDNIhxbI68LQmRVdW/kb c6fO45IVXMn3/aasj36I6xVqaALqHeMojK0pqvTRegecCfQQqaUh4wrOWoHPeezRUvjo uWzRXtNsHIyjJUZWlFnFTLlxayWcg2UzHoJeajtRZtFR4cpCMEIzVHPzve6m8Xrfm+Gv eqmx41zCWfmJFJDgbPa4Yg0ctALXl3vULabS0HWW6utvlyP2Ys3oJiLZxilVkzApX7Lf OKi8bStCzV8+3gfGF7HPhGVVE7LLmBelgqBiXUnSeARamuDsuptBei1yZKF+8t7USrsn Adeg== X-Gm-Message-State: AOAM5331aD5cqlYqGHxm62Tc8vw/LXxlpkbuC4S+ISaaffouypMVOmpn LEn7OFFJx05sN+Jh0l1dK7PGwF64WJjAVO5PwzctnBS2MngLHnPF X-Google-Smtp-Source: ABdhPJxAwOu26YXrml3Jp4vpuM/CyX8292+gEMtWP3BbMIEu/3OAPQMfNMfcsIA42LCh9GZJcMO/tafG5/DTfFmimXE= X-Received: by 2002:a05:6638:d0c:: with SMTP id q12mr6553929jaj.95.1603889974045; Wed, 28 Oct 2020 05:59:34 -0700 (PDT) MIME-Version: 1.0 References: <20201007083944.27910-1-ardb@kernel.org> <20201007083944.27910-3-ardb@kernel.org> <920965b8-6f87-3f82-9fce-d3051fc543ca@samsung.com> In-Reply-To: From: Joel Stanley Date: Wed, 28 Oct 2020 12:59:20 +0000 Message-ID: Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region To: Ard Biesheuvel Cc: Marek Szyprowski , Linux ARM , Linux Samsung SOC , Krzysztof Kozlowski , Linus Walleij , Florian Fainelli , Russell King , Rob Herring , Nicolas Pitre , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, 28 Oct 2020 at 12:53, Ard Biesheuvel wrote: > > On Wed, 28 Oct 2020 at 13:05, Joel Stanley wrote: > > > > On Wed, 28 Oct 2020 at 09:19, Marek Szyprowski wrote: > > > This patch landed in linux-next 20201028 as commit 7a1be318f579 ("ARM: > > > 9012/1: move device tree mapping out of linear region"). Sadly it broke > > > booting almost all Samsung Exynos-based boards. The only one which > > > booted, used an appended device tree. I can provide more information if > > > needed, just let me know what to check. "Starting kernel ..." is the > > > last message I see here. No output from earlycon. > > > > A bisection lead me to this patch after the next-20201028 failed to > > boot on the aspeed systems in testing (aspeed_g5_defconfig). > > > > You can reproduce this with today's next and qemu 5.1: > > > > qemu-system-arm -M romulus-bmc -nographic \ > > -kernel arch/arm/boot/zImage \ > > -dtb arch/arm/boot/dts/aspeed-bmc-opp-romulus.dtb \ > > -initrd any-old-file > > > > It requires the initrd option to reproduce, but the initrd doesn't > > need to be valid as we don't make it that far. > > > > There is no output but attaching gdb shows the kernel is stuck in > > setup_machine_tags. (If we enable CONFIG_ATAGS it is instead stuck in > > calibrate_delay). > > > > (gdb) bt > > #0 setup_machine_tags (machine_nr=, > > __atags_vaddr=) at ../arch/arm/kernel/atags.h:12 > > #1 setup_arch (cmdline_p=0x80c01fc4) at ../arch/arm/kernel/setup.c:1100 > > #2 0x80b00d2c in start_kernel () at ../init/main.c:862 > > #3 0x00000000 in ?? () > > > > Reverting 7a1be318f579 on top of next allowed the system to boot again. > > > > Does this help? Yes, that boots to userspace. > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index bb79e52aeb90..4f355bda872a 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -68,8 +68,8 @@ > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) > > #define FDT_FIXED_BASE UL(0xff800000) > -#define FDT_FIXED_SIZE (2 * PMD_SIZE) > -#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % PMD_SIZE)) > +#define FDT_FIXED_SIZE (2 * SECTION_SIZE) > +#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % SECTION_SIZE)) > > #if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) > /* From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8F5C55178 for ; Wed, 28 Oct 2020 13:01:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 379942473A for ; Wed, 28 Oct 2020 13:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JTAq92tL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="krmIqsua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 379942473A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I8aN/Bt2YDDwkX42zJNu/9uew0krgztNf5FgKWWYOlc=; b=JTAq92tLkgxHrGpc44p5FXqtR 2ZkGE1AxihFLh9AgligjHVImQrFtaLwFaSYEr9Giila/ixzIzYFmNSySsa/AGou5Aq2LxyFYVIhif Gf8L7hYUJdeJ+o+hm5e2cBSFYDmxQiy2dety4R4b5GXORw/c6bw2+U3IRjonyEapFFEAJjTMCciXE 1xzxbDb5kBCq6DFpsheMx+ylk3YcP4o6xFUlDw6RP5dNYoRXvuz2/9XkzeQwWNyDy6DAwsfrphyc5 LEAKpROpig33uCyAVH+XXN4yhsxYS3yoBC5mKLGIYQ9OlQ7NDx8LiQQA8apJ11o96wFSpS6h8tSU/ R2LM3jnLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXl3C-0005iy-T8; Wed, 28 Oct 2020 12:59:38 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXl3A-0005iC-8M for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 12:59:37 +0000 Received: by mail-io1-xd44.google.com with SMTP id r9so5211825ioo.7 for ; Wed, 28 Oct 2020 05:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i1Avim0KcggX9IKdEMHQzMezF7Rz3tSoeLz2phO/Qtk=; b=krmIqsuarEYIqEPBm4Rt9OwNjTY2cNSHgrwW+emBvBI9j3l7zTHMq3GBEa/Uvb8ssx HSLrplTUrRl2NeeAe4RwNMyQOtfot26unJogq38S711aVf+a4RvLZ+J9LgSCRFc/cX0W +Mhvx0ovZrBsUgU5ThwXomL7XXLfgnRA6SLx0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i1Avim0KcggX9IKdEMHQzMezF7Rz3tSoeLz2phO/Qtk=; b=JJyVkXiUZS2y2odh9wMOMi0HSS+xMvI0JLTjXYh62NuFCZPNeHLou/rY1XtLzMf0Z2 m167cEHpzhCcI6pCitG0sGQapem0eAijjlzezQYUQJ2K6aoZTM+sTNkA3irudDupd0Cw AcnWBeGgM8w2/psCNwa0PAz3ImiAFFieovZvrg6mm2fA8sCU6driO5HFkEPk3UBV1pH3 GCb+9FEooX7/AOpLH4QWXstnfxLHhRj6Us50QAf7Ng0AMMdyXOA2jEeet5pbxR6XsMj6 OIC6M0QGfQYz3lsThBx/H28WdbKjMjraXzVFNywXArXoyihlgSsU2l9zqa3cOTrZuSsW wA2Q== X-Gm-Message-State: AOAM531Z+FM4lS/IfQ/RWzskTvQumjB6I+qyG7rr9q/nYkVqkQfUfUNT 7T7Gjmu9SBJtV+UybQasTgdsBBtpFP/4nwB4e34= X-Google-Smtp-Source: ABdhPJxAwOu26YXrml3Jp4vpuM/CyX8292+gEMtWP3BbMIEu/3OAPQMfNMfcsIA42LCh9GZJcMO/tafG5/DTfFmimXE= X-Received: by 2002:a05:6638:d0c:: with SMTP id q12mr6553929jaj.95.1603889974045; Wed, 28 Oct 2020 05:59:34 -0700 (PDT) MIME-Version: 1.0 References: <20201007083944.27910-1-ardb@kernel.org> <20201007083944.27910-3-ardb@kernel.org> <920965b8-6f87-3f82-9fce-d3051fc543ca@samsung.com> In-Reply-To: From: Joel Stanley Date: Wed, 28 Oct 2020 12:59:20 +0000 Message-ID: Subject: Re: [PATCH v2 2/2] ARM: move device tree mapping out of linear region To: Ard Biesheuvel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_085936_348949_19523392 X-CRM114-Status: GOOD ( 27.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Nicolas Pitre , Linus Walleij , Russell King , Krzysztof Kozlowski , Rob Herring , Linux Samsung SOC , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Linux ARM , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Oct 2020 at 12:53, Ard Biesheuvel wrote: > > On Wed, 28 Oct 2020 at 13:05, Joel Stanley wrote: > > > > On Wed, 28 Oct 2020 at 09:19, Marek Szyprowski wrote: > > > This patch landed in linux-next 20201028 as commit 7a1be318f579 ("ARM: > > > 9012/1: move device tree mapping out of linear region"). Sadly it broke > > > booting almost all Samsung Exynos-based boards. The only one which > > > booted, used an appended device tree. I can provide more information if > > > needed, just let me know what to check. "Starting kernel ..." is the > > > last message I see here. No output from earlycon. > > > > A bisection lead me to this patch after the next-20201028 failed to > > boot on the aspeed systems in testing (aspeed_g5_defconfig). > > > > You can reproduce this with today's next and qemu 5.1: > > > > qemu-system-arm -M romulus-bmc -nographic \ > > -kernel arch/arm/boot/zImage \ > > -dtb arch/arm/boot/dts/aspeed-bmc-opp-romulus.dtb \ > > -initrd any-old-file > > > > It requires the initrd option to reproduce, but the initrd doesn't > > need to be valid as we don't make it that far. > > > > There is no output but attaching gdb shows the kernel is stuck in > > setup_machine_tags. (If we enable CONFIG_ATAGS it is instead stuck in > > calibrate_delay). > > > > (gdb) bt > > #0 setup_machine_tags (machine_nr=, > > __atags_vaddr=) at ../arch/arm/kernel/atags.h:12 > > #1 setup_arch (cmdline_p=0x80c01fc4) at ../arch/arm/kernel/setup.c:1100 > > #2 0x80b00d2c in start_kernel () at ../init/main.c:862 > > #3 0x00000000 in ?? () > > > > Reverting 7a1be318f579 on top of next allowed the system to boot again. > > > > Does this help? Yes, that boots to userspace. > > diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h > index bb79e52aeb90..4f355bda872a 100644 > --- a/arch/arm/include/asm/memory.h > +++ b/arch/arm/include/asm/memory.h > @@ -68,8 +68,8 @@ > #define XIP_VIRT_ADDR(physaddr) (MODULES_VADDR + ((physaddr) & 0x000fffff)) > > #define FDT_FIXED_BASE UL(0xff800000) > -#define FDT_FIXED_SIZE (2 * PMD_SIZE) > -#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % PMD_SIZE)) > +#define FDT_FIXED_SIZE (2 * SECTION_SIZE) > +#define FDT_VIRT_ADDR(physaddr) ((void *)(FDT_FIXED_BASE | > (physaddr) % SECTION_SIZE)) > > #if !defined(CONFIG_SMP) && !defined(CONFIG_ARM_LPAE) > /* _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel