From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B745DC433B4 for ; Thu, 8 Apr 2021 12:45:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0974D610FC for ; Thu, 8 Apr 2021 12:45:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0974D610FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUU2e-0000Gd-Pu for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 08:45:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUTwn-00062E-HW; Thu, 08 Apr 2021 08:39:45 -0400 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:42961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUTwl-0002mG-GM; Thu, 08 Apr 2021 08:39:45 -0400 Received: by mail-qt1-x831.google.com with SMTP id m16so602363qtx.9; Thu, 08 Apr 2021 05:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jXr9V7WZuQ1MQUo2L7X8W6+mjxPifB+3LUpeKSURTkM=; b=QevFCNexcJh5kchGAQRMSj63OU8eZQ+88KMQZenqaDdqgBvnZ+DDQLzsdLF4mN5rBh UZgxkcGKXzi+7SyskyDAiz/S0A0sRup/gxbC55g2v+4wptqeQs+vg8x193k/gC3gCSoF yqmu9Idu08U8B+Xol19NFYGzjvLXJc4Pq9bRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jXr9V7WZuQ1MQUo2L7X8W6+mjxPifB+3LUpeKSURTkM=; b=npUXGIzJepIKO7PrS3rrf/O1T4w7eLtbJ0fXiIXGbmSjax0bN0kXUS8WLJjLXD2Wtk YldWMbrdku9bX7NFyTY2YzCtMV0/kTwt8mx1kzui/q4Jq4hSr+WAI/wGDgOjpneVlmdi oUjpzJAC3t0d4dPhyr/hDIeNOaZ+l7PRLdmM3HWunnc+FYId7//asTZjo61DC7/v76BF DQqmSHhh4SJbJIiySKzSl9Erzj69szjNN4Spv1JXHEhWABY4qrdZLDRAiSEDoQMax2a2 rwKt1w6LJah57PECj8tn2hOwfc4Qg1Vw7oow8WXFQyipkITG8AGYNC8VCYQZUtQwqG0C 2Lcg== X-Gm-Message-State: AOAM532M10BCjNkm/sfZMAOLCP3uGFCbQYkJq0jxHMSUUkAVBFty0KGz bIo9qR3ZvsKFCtWMZatHOYJGeTl/xjrz9e4p51M= X-Google-Smtp-Source: ABdhPJx+sPoqNS9eBgRb4eRSaY14ButGHYshjjBDd6YfRGcKeoCrFjLHrGf7PhorFdZ/okk0XBS+qHjFp7dHvoVogBE= X-Received: by 2002:ac8:5f87:: with SMTP id j7mr7010838qta.135.1617885581443; Thu, 08 Apr 2021 05:39:41 -0700 (PDT) MIME-Version: 1.0 References: <20210407171637.777743-1-clg@kaod.org> <20210407171637.777743-10-clg@kaod.org> In-Reply-To: <20210407171637.777743-10-clg@kaod.org> From: Joel Stanley Date: Thu, 8 Apr 2021 12:39:28 +0000 Message-ID: Subject: Re: [PATCH 09/24] aspeed: Add Scater-Gather support for HACE Hash To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=joel.stan@gmail.com; helo=mail-qt1-x831.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , Peter Maydell , qemu-arm , QEMU Developers , Klaus Heinrich Kiwi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Klaus, On Wed, 7 Apr 2021 at 17:16, C=C3=A9dric Le Goater wrote: > > From: Klaus Heinrich Kiwi > > Complement the Aspeed HACE support with Scatter-Gather hash support for > sha256 and sha512. Scatter-Gather is only supported on AST2600-series. Sorry it's taken some time for me to get to this patch. It looks good. While spending some time reviewing, I ended up using your ideas to rework the do_hash_operation to support both sg and direct modes. It results in a smaller patch and shares codepaths for both modes. I'll send it out soon for review. Cheers, Joel