From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?St=E9phane_Marchesin?= Subject: Re: [pull] drm-intel-fixes Date: Wed, 22 May 2013 09:00:22 -0700 Message-ID: References: <20120910072817.GB5387@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, May 22, 2013 at 8:51 AM, Daniel Vetter wrote: > On Wed, May 22, 2013 at 5:25 PM, St=E9phane Marchesin > wrote: >> On Wed, May 22, 2013 at 12:13 AM, Daniel Vetter wrote: >>> On Wed, May 22, 2013 at 3:24 AM, St=E9phane Marchesin >>> wrote: >>>> On Mon, Sep 10, 2012 at 12:28 AM, Daniel Vetter wrot= e: >>>>> Hi Dave, >>>>> >>>>> You're pull just reminded me that I've been sitting on a few small -f= ixes, >>>>> too. Nothing really major at all: >>>>> - fixup edp setup sequence (Dave) >>>>> - disable sdvo hotplug for real, this is a fixup for a messed-up >>>>> regression fixer (Jani) >>>>> - don't expose dysfunctional backlight driver (Jani) >>>> >>>> Hi Daniel, >>>> >>>> This change ("don't expose dysfunctional backlight driver") regresses >>>> the backlight on Chromebooks, where we don't run the vbios. >>> >>> Presuming the patch works as advertised it only stops publishing an >>> intel backlight driver which won't work. How does that break stuff? >>> >> >> Well it probably works as advertised to avoid exposing some broken >> backlight, but the problem is that it also stops exposing a working >> backlight on Chromebooks. However it sounds like the initial patch is >> specific to a broken machine, so maybe a dmi match is more >> appropriate? > > I prefer a dmi match for chromebooks since the behaviour of fixing up > the backlight after i915.ko is loaded seems rather peculiar to your > setup. It has nothing to do with Chromebooks though, but more with the fact that we don't run vbios. This isn't a property of the hardware. > >>> Or do you somehow update the max blc stuff only once i915.ko is loaded? >>> >> >> Yup that's what used to happen. > > What/when exactly does that happen? Before the regression, the code was: if (max =3D=3D 0) { i915_set_default_max_backlight which would make it work. And now that doesn't run and therefore it breaks. St=E9phane > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch