From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730Ab3EBIM3 (ORCPT ); Thu, 2 May 2013 04:12:29 -0400 Received: from mail-ia0-f177.google.com ([209.85.210.177]:47511 "EHLO mail-ia0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254Ab3EBIMY convert rfc822-to-8bit (ORCPT ); Thu, 2 May 2013 04:12:24 -0400 MIME-Version: 1.0 In-Reply-To: References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> From: Richard Genoud Date: Thu, 2 May 2013 10:12:03 +0200 Message-ID: Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set To: "Yang, Wenyou" Cc: Joachim Eastwood , "linux-arm-kernel@lists.infradead.org" , "grant.likely@secretlab.ca" , "Ferre, Nicolas" , "plagnioj@jcrosoft.com" , "Lin, JM" , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013/5/2 Yang, Wenyou : > Hi, Joachim, > >> -----Original Message----- >> From: Joachim Eastwood [mailto:manabian@gmail.com] >> Sent: 2013年3月7日 20:31 >> To: Yang, Wenyou >> Cc: linux-arm-kernel@lists.infradead.org; grant.likely@secretlab.ca; Ferre, >> Nicolas; plagnioj@jcrosoft.com; richard.genoud@gmail.com; Lin, JM; >> spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after >> xfer->speed_hz set >> >> On 7 March 2013 04:26, Wenyou Yang wrote: >> > commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e >> > cause the atmel spi probing failure. >> > >> > Signed-off-by: Wenyou Yang >> > Cc: spi-devel-general@lists.sourceforge.net >> > Cc: linux-kernel@vger.kernel.org >> > --- >> > drivers/spi/spi-atmel.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c >> > index 656d137..1eca815 100644 >> > --- a/drivers/spi/spi-atmel.c >> > +++ b/drivers/spi/spi-atmel.c >> > @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi, >> struct spi_message *msg) >> > } >> > } >> > >> > - /* FIXME implement these protocol options!! */ >> > - if (xfer->speed_hz) { >> > - dev_dbg(&spi->dev, "no protocol options >> yet\n"); >> > + if (xfer->speed_hz < spi->max_speed_hz) { >> > + dev_dbg(&spi->dev, >> > + "speed in transfer less than bus >> speed\n"); >> > return -ENOPROTOOPT; >> > } >> >> I sent a similar patch to spi-devl a while ago, which Grant said he applied. >> https://patchwork.kernel.org/patch/2165301/ >> >> Can't find the patch in any upstream git tree so I guess Grant hasn't >> pushed it yet. > This patch hasn't still applied in any upstream git tree, so Atmel spi master doesn't work. > Could you help do some ping it? it's in linux-next: 3d3522604a5557e80fdcab61c54bd04eaf15b525 merged from spi-current/spi/merge Richard. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Genoud Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set Date: Thu, 2 May 2013 10:12:03 +0200 Message-ID: References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Joachim Eastwood , "Ferre, Nicolas" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org" , "Lin, JM" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" To: "Yang, Wenyou" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org MjAxMy81LzIgWWFuZywgV2VueW91IDxXZW55b3UuWWFuZ0BhdG1lbC5jb20+Ogo+IEhpLCBKb2Fj aGltLAo+Cj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IEpvYWNoaW0gRWFz dHdvb2QgW21haWx0bzptYW5hYmlhbkBnbWFpbC5jb21dCj4+IFNlbnQ6IDIwMTPlubQz5pyIN+aX pSAyMDozMQo+PiBUbzogWWFuZywgV2VueW91Cj4+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmc7IGdyYW50Lmxpa2VseUBzZWNyZXRsYWIuY2E7IEZlcnJlLAo+PiBOaWNv bGFzOyBwbGFnbmlvakBqY3Jvc29mdC5jb207IHJpY2hhcmQuZ2Vub3VkQGdtYWlsLmNvbTsgTGlu LCBKTTsKPj4gc3BpLWRldmVsLWdlbmVyYWxAbGlzdHMuc291cmNlZm9yZ2UubmV0OyBsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnCj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjYgMDEvMTZdIHNw aS9zcGktYXRtZWw6IGZpeCBwcm9iaW5nIGZhaWx1cmUgYWZ0ZXIKPj4geGZlci0+c3BlZWRfaHog c2V0Cj4+Cj4+IE9uIDcgTWFyY2ggMjAxMyAwNDoyNiwgV2VueW91IFlhbmcgPHdlbnlvdS55YW5n QGF0bWVsLmNvbT4gd3JvdGU6Cj4+ID4gY29tbWl0OiAwNTliOGZmZWVlNWI0Mjc5NDk4NzJiYjZl ZDVkYjVhZTA3ODgwNTRlCj4+ID4gY2F1c2UgdGhlIGF0bWVsIHNwaSBwcm9iaW5nIGZhaWx1cmUu Cj4+ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBXZW55b3UgWWFuZyA8d2VueW91LnlhbmdAYXRtZWwu Y29tPgo+PiA+IENjOiBzcGktZGV2ZWwtZ2VuZXJhbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKPj4g PiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+PiA+IC0tLQo+PiA+ICBkcml2ZXJz L3NwaS9zcGktYXRtZWwuYyB8ICAgIDYgKysrLS0tCj4+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4+ID4KPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9zcGkvc3BpLWF0bWVsLmMgYi9kcml2ZXJzL3NwaS9zcGktYXRtZWwuYwo+PiA+IGluZGV4IDY1 NmQxMzcuLjFlY2E4MTUgMTAwNjQ0Cj4+ID4gLS0tIGEvZHJpdmVycy9zcGkvc3BpLWF0bWVsLmMK Pj4gPiArKysgYi9kcml2ZXJzL3NwaS9zcGktYXRtZWwuYwo+PiA+IEBAIC04NDYsOSArODQ2LDkg QEAgc3RhdGljIGludCBhdG1lbF9zcGlfdHJhbnNmZXIoc3RydWN0IHNwaV9kZXZpY2UgKnNwaSwK Pj4gc3RydWN0IHNwaV9tZXNzYWdlICptc2cpCj4+ID4gICAgICAgICAgICAgICAgICAgICAgICAg fQo+PiA+ICAgICAgICAgICAgICAgICB9Cj4+ID4KPj4gPiAtICAgICAgICAgICAgICAgLyogRklY TUUgaW1wbGVtZW50IHRoZXNlIHByb3RvY29sIG9wdGlvbnMhISAqLwo+PiA+IC0gICAgICAgICAg ICAgICBpZiAoeGZlci0+c3BlZWRfaHopIHsKPj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBk ZXZfZGJnKCZzcGktPmRldiwgIm5vIHByb3RvY29sIG9wdGlvbnMKPj4geWV0XG4iKTsKPj4gPiAr ICAgICAgICAgICAgICAgaWYgKHhmZXItPnNwZWVkX2h6IDwgc3BpLT5tYXhfc3BlZWRfaHopIHsK Pj4gPiArICAgICAgICAgICAgICAgICAgICAgICBkZXZfZGJnKCZzcGktPmRldiwKPj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJzcGVlZCBpbiB0cmFuc2ZlciBsZXNzIHRoYW4g YnVzCj4+IHNwZWVkXG4iKTsKPj4gPiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVO T1BST1RPT1BUOwo+PiA+ICAgICAgICAgICAgICAgICB9Cj4+Cj4+IEkgc2VudCBhIHNpbWlsYXIg cGF0Y2ggdG8gc3BpLWRldmwgYSB3aGlsZSBhZ28sIHdoaWNoIEdyYW50IHNhaWQgaGUgYXBwbGll ZC4KPj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8yMTY1MzAxLwo+Pgo+PiBD YW4ndCBmaW5kIHRoZSBwYXRjaCBpbiBhbnkgdXBzdHJlYW0gZ2l0IHRyZWUgc28gSSBndWVzcyBH cmFudCBoYXNuJ3QKPj4gcHVzaGVkIGl0IHlldC4KPiBUaGlzIHBhdGNoIGhhc24ndCBzdGlsbCBh cHBsaWVkIGluIGFueSB1cHN0cmVhbSBnaXQgdHJlZSwgc28gQXRtZWwgc3BpIG1hc3RlciBkb2Vz bid0IHdvcmsuCj4gQ291bGQgeW91IGhlbHAgZG8gc29tZSBwaW5nIGl0PwoKaXQncyBpbiBsaW51 eC1uZXh0OgozZDM1MjI2MDRhNTU1N2U4MGZkY2FiNjFjNTRiZDA0ZWFmMTViNTI1Cm1lcmdlZCBm cm9tIHNwaS1jdXJyZW50L3NwaS9tZXJnZQoKClJpY2hhcmQuCgotLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KSW50cm9kdWNpbmcgQXBwRHluYW1pY3MgTGl0ZSwgYSBmcmVlIHRyb3VibGVzaG9vdGluZyB0 b29sIGZvciBKYXZhLy5ORVQKR2V0IDEwMCUgdmlzaWJpbGl0eSBpbnRvIHlvdXIgcHJvZHVjdGlv biBhcHBsaWNhdGlvbiAtIGF0IG5vIGNvc3QuCkNvZGUtbGV2ZWwgZGlhZ25vc3RpY3MgZm9yIHBl cmZvcm1hbmNlIGJvdHRsZW5lY2tzIHdpdGggPDIlIG92ZXJoZWFkCkRvd25sb2FkIGZvciBmcmVl IGFuZCBnZXQgc3RhcnRlZCB0cm91Ymxlc2hvb3RpbmcgaW4gbWludXRlcy4KaHR0cDovL3Auc2Yu bmV0L3NmdS9hcHBkeW5fZDJkX2FwMQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpzcGktZGV2ZWwtZ2VuZXJhbCBtYWlsaW5nIGxpc3QKc3BpLWRldmVsLWdl bmVyYWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0 L2xpc3RzL2xpc3RpbmZvL3NwaS1kZXZlbC1nZW5lcmFsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard.genoud@gmail.com (Richard Genoud) Date: Thu, 2 May 2013 10:12:03 +0200 Subject: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set In-Reply-To: References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2013/5/2 Yang, Wenyou : > Hi, Joachim, > >> -----Original Message----- >> From: Joachim Eastwood [mailto:manabian at gmail.com] >> Sent: 2013?3?7? 20:31 >> To: Yang, Wenyou >> Cc: linux-arm-kernel at lists.infradead.org; grant.likely at secretlab.ca; Ferre, >> Nicolas; plagnioj at jcrosoft.com; richard.genoud at gmail.com; Lin, JM; >> spi-devel-general at lists.sourceforge.net; linux-kernel at vger.kernel.org >> Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after >> xfer->speed_hz set >> >> On 7 March 2013 04:26, Wenyou Yang wrote: >> > commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e >> > cause the atmel spi probing failure. >> > >> > Signed-off-by: Wenyou Yang >> > Cc: spi-devel-general at lists.sourceforge.net >> > Cc: linux-kernel at vger.kernel.org >> > --- >> > drivers/spi/spi-atmel.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c >> > index 656d137..1eca815 100644 >> > --- a/drivers/spi/spi-atmel.c >> > +++ b/drivers/spi/spi-atmel.c >> > @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi, >> struct spi_message *msg) >> > } >> > } >> > >> > - /* FIXME implement these protocol options!! */ >> > - if (xfer->speed_hz) { >> > - dev_dbg(&spi->dev, "no protocol options >> yet\n"); >> > + if (xfer->speed_hz < spi->max_speed_hz) { >> > + dev_dbg(&spi->dev, >> > + "speed in transfer less than bus >> speed\n"); >> > return -ENOPROTOOPT; >> > } >> >> I sent a similar patch to spi-devl a while ago, which Grant said he applied. >> https://patchwork.kernel.org/patch/2165301/ >> >> Can't find the patch in any upstream git tree so I guess Grant hasn't >> pushed it yet. > This patch hasn't still applied in any upstream git tree, so Atmel spi master doesn't work. > Could you help do some ping it? it's in linux-next: 3d3522604a5557e80fdcab61c54bd04eaf15b525 merged from spi-current/spi/merge Richard.