From: Richard Genoud <richard.genoud@gmail.com> To: Mark Brown <broonie@kernel.org> Cc: "Nicolas Ferre" <nicolas.ferre@atmel.com>, "Liam Girdwood" <lgirdwood@gmail.com>, "Bo Shen" <voice.shen@atmel.com>, "Lars-Peter Clausen" <lars@metafoo.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Date: Mon, 15 Jul 2013 16:59:21 +0200 [thread overview] Message-ID: <CACQ1gAiJ8ww-gYfcUsux00DmpWUpfqyzzqfxZjWZSaObgsz29g@mail.gmail.com> (raw) In-Reply-To: <20130712114926.GE24508@sirena.org.uk> 2013/7/12 Mark Brown <broonie@kernel.org>: > On Thu, Jul 11, 2013 at 06:15:54PM +0200, Richard Genoud wrote: >> From: Nicolas Ferre <nicolas.ferre@atmel.com> >> >> Description of the Asoc machine driver for an at91sam9x5 based board > > ASoC. > >> +sam9x5 pins: >> + * LOUT >> + * ROUT >> + * LHPOUT >> + * RHPOUT >> + * LLINEIN >> + * RLINEIN >> + * MICIN > > These aren't pins on the CPU, they're pins on the CODEC, and you should > be adding this to the binding document for the CODEC and referring to > that rather than having them in each individual binding document. This > also helps if any new variants are added (not that this is likely for > the WM8731). ok, I'll move that > >> +static struct sam9x5_drvdata sam9x5_priv; > > Why is this a global static? > >> + ret = snd_soc_register_card(&snd_soc_sam9x5); >> + if (ret) { >> + dev_err(&pdev->dev, >> + "ASoC: Platform device allocation failed\n"); >> + goto out_put_audio; >> + } > >> + platform_set_drvdata(pdev, &snd_soc_sam9x5); > > It should be being dynamically allocated and retrieved as driver data > when needed. ok. Thanks ! -- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
WARNING: multiple messages have this Message-ID (diff)
From: richard.genoud@gmail.com (Richard Genoud) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Date: Mon, 15 Jul 2013 16:59:21 +0200 [thread overview] Message-ID: <CACQ1gAiJ8ww-gYfcUsux00DmpWUpfqyzzqfxZjWZSaObgsz29g@mail.gmail.com> (raw) In-Reply-To: <20130712114926.GE24508@sirena.org.uk> 2013/7/12 Mark Brown <broonie@kernel.org>: > On Thu, Jul 11, 2013 at 06:15:54PM +0200, Richard Genoud wrote: >> From: Nicolas Ferre <nicolas.ferre@atmel.com> >> >> Description of the Asoc machine driver for an at91sam9x5 based board > > ASoC. > >> +sam9x5 pins: >> + * LOUT >> + * ROUT >> + * LHPOUT >> + * RHPOUT >> + * LLINEIN >> + * RLINEIN >> + * MICIN > > These aren't pins on the CPU, they're pins on the CODEC, and you should > be adding this to the binding document for the CODEC and referring to > that rather than having them in each individual binding document. This > also helps if any new variants are added (not that this is likely for > the WM8731). ok, I'll move that > >> +static struct sam9x5_drvdata sam9x5_priv; > > Why is this a global static? > >> + ret = snd_soc_register_card(&snd_soc_sam9x5); >> + if (ret) { >> + dev_err(&pdev->dev, >> + "ASoC: Platform device allocation failed\n"); >> + goto out_put_audio; >> + } > >> + platform_set_drvdata(pdev, &snd_soc_sam9x5); > > It should be being dynamically allocated and retrieved as driver data > when needed. ok. Thanks ! -- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
next prev parent reply other threads:[~2013-07-15 14:59 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-11 16:15 [PATCH v5 0/7] Sound support for at91sam9x5-wm8731 based boards Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-11 16:15 ` [PATCH v5 1/7] sound: codec: wm8731: add rates constraints Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-12 11:45 ` Mark Brown 2013-07-12 11:45 ` Mark Brown 2013-07-12 11:45 ` Mark Brown 2013-07-15 14:53 ` Richard Genoud 2013-07-15 14:53 ` Richard Genoud 2013-07-15 15:22 ` Mark Brown 2013-07-15 15:22 ` Mark Brown 2013-07-11 16:15 ` [PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-12 11:49 ` Mark Brown 2013-07-12 11:49 ` Mark Brown 2013-07-12 11:49 ` Mark Brown 2013-07-15 14:59 ` Richard Genoud [this message] 2013-07-15 14:59 ` Richard Genoud 2013-07-11 16:15 ` [PATCH v5 3/7] Documentation: DT: update atmel SSC with DMA binding Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-11 16:15 ` [PATCH v5 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-11 16:15 ` [PATCH v5 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-11 16:15 ` [PATCH v5 6/7] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud 2013-07-11 16:15 ` Richard Genoud 2013-07-11 16:15 ` [PATCH v5 7/7] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud 2013-07-11 16:15 ` Richard Genoud
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACQ1gAiJ8ww-gYfcUsux00DmpWUpfqyzzqfxZjWZSaObgsz29g@mail.gmail.com \ --to=richard.genoud@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=lars@metafoo.de \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nicolas.ferre@atmel.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=voice.shen@atmel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.