From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver Date: Thu, 15 Nov 2012 20:09:20 +0100 Message-ID: References: <4a92290e8a3b1a19c3a5e864edfa7badfc2af5d0.1352608333.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Viresh Kumar Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, Shiraz Hashim , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sr-ynQEQJNshbs@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Nov 15, 2012 at 3:19 PM, Viresh Kumar wrote: > On 15 November 2012 19:47, Linus Walleij wrote: >> Just one question: since this driver is not using any >> pinctrl interfaces, why is it under drivers/pinctrl/*? >> >> Shouldn't it be under drivers/gpio from a technical >> point of view? >> >> I think I'd accept it under drivers/pinctrl/spear/* >> if you just want this to keep everything SPEAr-related >> in one place though, so enlighten me. > > That's because they are controlling few pads. They are not > actually gpio's but just pads that we are controlling. > > That's why we thought they are better in this place. The grouping of drivers in the kernel is about what in-kernel subsystem interface they're using, not how their electronics work... Since this driver is only using the GPIO API it should be in drivers/gpio/gpio-*.c. Many, many drivers in drivers/gpio* are controlling pads too, so it will be in good company ;-) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Thu, 15 Nov 2012 20:09:20 +0100 Subject: [PATCH 01/14] pinctrl: SPEAr: add spi chipselect control driver In-Reply-To: References: <4a92290e8a3b1a19c3a5e864edfa7badfc2af5d0.1352608333.git.viresh.kumar@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Nov 15, 2012 at 3:19 PM, Viresh Kumar wrote: > On 15 November 2012 19:47, Linus Walleij wrote: >> Just one question: since this driver is not using any >> pinctrl interfaces, why is it under drivers/pinctrl/*? >> >> Shouldn't it be under drivers/gpio from a technical >> point of view? >> >> I think I'd accept it under drivers/pinctrl/spear/* >> if you just want this to keep everything SPEAr-related >> in one place though, so enlighten me. > > That's because they are controlling few pads. They are not > actually gpio's but just pads that we are controlling. > > That's why we thought they are better in this place. The grouping of drivers in the kernel is about what in-kernel subsystem interface they're using, not how their electronics work... Since this driver is only using the GPIO API it should be in drivers/gpio/gpio-*.c. Many, many drivers in drivers/gpio* are controlling pads too, so it will be in good company ;-) Yours, Linus Walleij