From: Linus Walleij <linus.walleij@linaro.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Kevin Tsai <ktsai@capellamicro.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe()
Date: Wed, 13 Oct 2021 01:45:47 +0200 [thread overview]
Message-ID: <CACRpkdY0uM4BNapd7XNUhZ5U0sGdP3hu5Tr+dM1jigg5vQ+KDw@mail.gmail.com> (raw)
In-Reply-To: <20211008092656.421-1-caihuoqing@baidu.com>
On Fri, Oct 8, 2021 at 11:27 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v2->v3:
> *Handle platform_get_irq() that returns -EPROBE_DEFER.
> *Handle the lack of availability of an IIO channel
> by converting an -ENODEV to an -EPROBE_DEFER.
This looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-10-12 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 9:26 [PATCH v3 1/4] iio: light: cm3605: Make use of the helper function dev_err_probe() Cai Huoqing
2021-10-08 9:26 ` [PATCH v3 2/4] iio: light: cm36651: " Cai Huoqing
2021-10-08 9:26 ` [PATCH v3 3/4] iio: light: gp2ap002: " Cai Huoqing
2021-10-08 9:26 ` [PATCH v3 4/4] iio: light: noa1305: " Cai Huoqing
2021-10-12 23:45 ` Linus Walleij [this message]
2021-10-17 11:56 ` [PATCH v3 1/4] iio: light: cm3605: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY0uM4BNapd7XNUhZ5U0sGdP3hu5Tr+dM1jigg5vQ+KDw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=caihuoqing@baidu.com \
--cc=jic23@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.