From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Date: Sat, 13 Feb 2016 15:48:11 +0100 Message-ID: References: <1452773795-24216-1-git-send-email-mcoquelin.stm32@gmail.com> <1452773795-24216-5-git-send-email-mcoquelin.stm32@gmail.com> <2151471.Wut3mQ9SS7@wuerfel> <56AF4AEB.40109@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ob0-f182.google.com ([209.85.214.182]:36226 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbcBMOsM (ORCPT ); Sat, 13 Feb 2016 09:48:12 -0500 Received: by mail-ob0-f182.google.com with SMTP id gc3so58518405obb.3 for ; Sat, 13 Feb 2016 06:48:12 -0800 (PST) In-Reply-To: <56AF4AEB.40109@st.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Maxime Coquelin Cc: Maxime Coquelin , Arnd Bergmann , Mark Rutland , "devicetree@vger.kernel.org" , Daniel Thompson , Bruno Herrera , Patrice CHOTARD , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , =?UTF-8?Q?Andreas_F=C3=A4rber?= , "linux-arm-kernel@lists.infradead.org" On Mon, Feb 1, 2016 at 1:09 PM, Maxime Coquelin wrote: > On 02/01/2016 11:39 AM, Maxime Coquelin wrote: >> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann : >>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: >>> dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory >> >> Right, I missed to notify this dependency to Linus, sorry about that. >> This dependency is no more needed, so I could just move the macros to >> the driver side. >> >> Note that I also noticed a breakage at build time due to field >> renaming in gpio_chip structure (dev -> parent). >> >> I propose to rebase the series and move the defines into the driver. >> Is it ok for you? >> > I have rebased the series, taking care to fix the mentioned problems. > > Linus, do you confirm you will revert STM32 pinctrl patches from your tree? I guess the other fixes removes the need to do this. Sorry for not staying on top of this issue, I was swamped with mail and had a hard time prioritizing :( Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Sat, 13 Feb 2016 15:48:11 +0100 Subject: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support In-Reply-To: <56AF4AEB.40109@st.com> References: <1452773795-24216-1-git-send-email-mcoquelin.stm32@gmail.com> <1452773795-24216-5-git-send-email-mcoquelin.stm32@gmail.com> <2151471.Wut3mQ9SS7@wuerfel> <56AF4AEB.40109@st.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Feb 1, 2016 at 1:09 PM, Maxime Coquelin wrote: > On 02/01/2016 11:39 AM, Maxime Coquelin wrote: >> 2016-02-01 11:21 GMT+01:00 Arnd Bergmann : >>> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: >>> dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory >> >> Right, I missed to notify this dependency to Linus, sorry about that. >> This dependency is no more needed, so I could just move the macros to >> the driver side. >> >> Note that I also noticed a breakage at build time due to field >> renaming in gpio_chip structure (dev -> parent). >> >> I propose to rebase the series and move the defines into the driver. >> Is it ok for you? >> > I have rebased the series, taking care to fix the mentioned problems. > > Linus, do you confirm you will revert STM32 pinctrl patches from your tree? I guess the other fixes removes the need to do this. Sorry for not staying on top of this issue, I was swamped with mail and had a hard time prioritizing :( Yours, Linus Walleij