From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDA7C10F13 for ; Mon, 8 Apr 2019 13:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21397213F2 for ; Mon, 8 Apr 2019 13:07:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tcfzzZtG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbfDHNHG (ORCPT ); Mon, 8 Apr 2019 09:07:06 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:34224 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfDHNHG (ORCPT ); Mon, 8 Apr 2019 09:07:06 -0400 Received: by mail-lf1-f68.google.com with SMTP id o199so2325073lfo.1 for ; Mon, 08 Apr 2019 06:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0AyWKrT0NuvHSYj7C91aK7wR5Y+FA1C/FvU7EnCeP48=; b=tcfzzZtGPiGRqVGNPEDTrH+hICLknnt8lyY7JmlytyxS/fguhjvjITAkCC7PkguApq MFv6tBpZVXKZPAEy8nga3NJY11BcFtim4y7jgpIIgNXXq8UD9SlRsclsq2UsibuaE5T0 9EYetbDu0cEzYG5s5JJmO9ka8343ARYel8vrZuYDFWvNdDB4A3KX8FNedhYrh0Apjbcp YqDqzEHUL+0Bu/0Zbo4VHdQtCzQzvzjc4gCPUdDQOrptl8CaIelsZ7J2MZRCe4pKk0qr yMTuEWo2x/2BdtHK+IdCIEPUCouVSKqV+8P/re6zTD9DzaPBJZMfMlmPCUljelVwMpev Z6tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0AyWKrT0NuvHSYj7C91aK7wR5Y+FA1C/FvU7EnCeP48=; b=cYiZfxz2pXikT0WL/jKtLayb/wcWh50edxbrrksT7km9E9+0PME15b00007aSYl0Lt nvVivL41cPGRRnGpcAbEaqOeVdQWNZg1qZuiobilSYMl6i6Eoes9BNJ+3r+WTkV/w+Bf +6HE8V5ATlGjhwgKFJIJDWanj4+OLIo3/VdQ74b8u9rdJwMQG7C5mggGzUgKbpCQlGKK xdpcEJjN4Cgl5BsvYsWWDe3QwFsbLYHplWSta3fzulF3bIIIK3xuBj7VYyrZrLzi05nW ORPmtxgbZ/fce0f1ZhRTHSsiolQHfpKz7k+NTRTAlwuzuBd+uyyS5f6LrWDPv5L7kSOE 27+g== X-Gm-Message-State: APjAAAU+dc9766HPTxaxl2CffDJTmXJG2VPeU/kcqUWRtFIoi4/kPhQE /ABHo5FHO6QqHgmS8OfzirDTzCg5qJBDRLdm2i4stA== X-Google-Smtp-Source: APXvYqyYYCE4/Ks6czxKLdL0dVVnf2FQbH1agfmCMWG0srCdnxXgM859ZaP1jzXfd8A5h9d/zgxhwzlxf6tNhkpgIxc= X-Received: by 2002:ac2:4285:: with SMTP id m5mr15564999lfh.103.1554728824187; Mon, 08 Apr 2019 06:07:04 -0700 (PDT) MIME-Version: 1.0 References: <1554298852-9955-1-git-send-email-p.paillet@st.com> <1554298852-9955-2-git-send-email-p.paillet@st.com> <5CAB3DF8.7020505@st.com> In-Reply-To: <5CAB3DF8.7020505@st.com> From: Linus Walleij Date: Mon, 8 Apr 2019 15:06:52 +0200 Message-ID: Subject: Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board To: Pascal PAILLET-LME Cc: "devicetree@vger.kernel.org" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" , "horms+renesas@verge.net.au" , "olof@lixom.net" , "arnd@arndb.de" , "geert+renesas@glider.be" , "biju.das@bp.renesas.com" , Yannick FERTRE , "m.szyprowski@samsung.com" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 8, 2019 at 2:26 PM Pascal PAILLET-LME wrote: > > I hope you are not trying to work around a bug in the driver by > > stripping out DMA configuration from the device tree, because then > > it is probably a better idea to fix the bug. > This is not a workaround. The PMIC can use the DMA over I2C bus. > Our goal is to avoid using a DMA channel for a consumer that generates a > very few traffic. Dma channels may lack for other use cases. > > If you agree, you can add the to the commit message. OK I understand, then also write it directly in the dts as a comment, so people understand why it is being removed when they just look in the device tree. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board Date: Mon, 8 Apr 2019 15:06:52 +0200 Message-ID: References: <1554298852-9955-1-git-send-email-p.paillet@st.com> <1554298852-9955-2-git-send-email-p.paillet@st.com> <5CAB3DF8.7020505@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <5CAB3DF8.7020505@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Pascal PAILLET-LME Cc: "devicetree@vger.kernel.org" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux@armlinux.org.uk" , "horms+renesas@verge.net.au" , "olof@lixom.net" , "arnd@arndb.de" , "geert+renesas@glider.be" , "biju.das@bp.renesas.com" , Yannick FERTRE , "m.szyprowski@samsung.com" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Mon, Apr 8, 2019 at 2:26 PM Pascal PAILLET-LME wrote: > > I hope you are not trying to work around a bug in the driver by > > stripping out DMA configuration from the device tree, because then > > it is probably a better idea to fix the bug. > This is not a workaround. The PMIC can use the DMA over I2C bus. > Our goal is to avoid using a DMA channel for a consumer that generates a > very few traffic. Dma channels may lack for other use cases. > > If you agree, you can add the to the commit message. OK I understand, then also write it directly in the dts as a comment, so people understand why it is being removed when they just look in the device tree. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB81C10F13 for ; Mon, 8 Apr 2019 13:07:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B07C4213F2 for ; Mon, 8 Apr 2019 13:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YrAYYaR/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tcfzzZtG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B07C4213F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MRUt+KJPnmZBaLaIOg64v+5QQ/LUdekGxKhLuoQx4JY=; b=YrAYYaR/+yhx3X 28FlYr0fiDDZtAbmHb+YCjKmW0wyM/i03Gr8gGDO7Yy0Ci0fJVI3NmvOEm2yHIE4xIqqGflseuJxH PNg+XyQ+zJsXbeuwRlFnLKIypAueOWB/ULPXo83piH3LnT/wWTeeN4bgYa3SS/q4gzWlfdP3AjsSn 3nHSQZ57EqtQCI9PHdUWqZbhc2hZ8fo0kjmfs0mo+mjIxSovBXN6n+llCzL5/FSI7aoKBEM2ZISrH CfS42tuvbEJzl0RW7S8nKLB7STxrtkZanPANqmd33pzXpGp9fl1E6mT902JIyc7VxabSasmifK7VJ RHTx0DSrRMI2VDaCACTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDTzR-0003n5-M2; Mon, 08 Apr 2019 13:07:09 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDTzO-0003m9-11 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2019 13:07:07 +0000 Received: by mail-lf1-x144.google.com with SMTP id u24so2524106lfg.5 for ; Mon, 08 Apr 2019 06:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0AyWKrT0NuvHSYj7C91aK7wR5Y+FA1C/FvU7EnCeP48=; b=tcfzzZtGPiGRqVGNPEDTrH+hICLknnt8lyY7JmlytyxS/fguhjvjITAkCC7PkguApq MFv6tBpZVXKZPAEy8nga3NJY11BcFtim4y7jgpIIgNXXq8UD9SlRsclsq2UsibuaE5T0 9EYetbDu0cEzYG5s5JJmO9ka8343ARYel8vrZuYDFWvNdDB4A3KX8FNedhYrh0Apjbcp YqDqzEHUL+0Bu/0Zbo4VHdQtCzQzvzjc4gCPUdDQOrptl8CaIelsZ7J2MZRCe4pKk0qr yMTuEWo2x/2BdtHK+IdCIEPUCouVSKqV+8P/re6zTD9DzaPBJZMfMlmPCUljelVwMpev Z6tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0AyWKrT0NuvHSYj7C91aK7wR5Y+FA1C/FvU7EnCeP48=; b=VFH0lOHSs/w4Xok9/0LCLL8hB58hjGXeY19Ec9TtORZMvkFLis208jj5c3hUD4Pblz cLLi9mUpKWDz4PAehqChpIHr+Uu3VfE7bPCRRDxjxshhgBsUyDSMbzKZRVtlrQUOzlt4 NBvxnWyHsHuDgyyHwInxq6GV9Pxk1gS77WuMlt2+xevTXYu+DhhgrpuB+Ez6/qfomANe 2uxcAa8nITT6w0dmJPDB0gCpqdw0c6kJV/0o1ENh5ZXNI362CoUD0l6eP5ZvQD8UJgdM 4NUCQ0Q0sEX7vn6LR/ahRPEjao9q0H8+cLkf8aiVZ5lWe8w9/QOf1HgP+zyFvlwZNol4 wGNw== X-Gm-Message-State: APjAAAWsVA6z4IplBELdRm/SmrCviUUuq10tKrN10S0gKtK63wVY/hJl t0cE/tvSu45WbN2Ba6pGL6S7PXZYwxKN9jz9yrR1QA== X-Google-Smtp-Source: APXvYqyYYCE4/Ks6czxKLdL0dVVnf2FQbH1agfmCMWG0srCdnxXgM859ZaP1jzXfd8A5h9d/zgxhwzlxf6tNhkpgIxc= X-Received: by 2002:ac2:4285:: with SMTP id m5mr15564999lfh.103.1554728824187; Mon, 08 Apr 2019 06:07:04 -0700 (PDT) MIME-Version: 1.0 References: <1554298852-9955-1-git-send-email-p.paillet@st.com> <1554298852-9955-2-git-send-email-p.paillet@st.com> <5CAB3DF8.7020505@st.com> In-Reply-To: <5CAB3DF8.7020505@st.com> From: Linus Walleij Date: Mon, 8 Apr 2019 15:06:52 +0200 Message-ID: Subject: Re: [PATCH 1/3] ARM: dts: stm32: add stpmic1 support on stm32mp157c ed1 board To: Pascal PAILLET-LME X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190408_060706_092509_BA10183E X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Alexandre TORGUE , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "linux@armlinux.org.uk" , "biju.das@bp.renesas.com" , Yannick FERTRE , "robh+dt@kernel.org" , "mcoquelin.stm32@gmail.com" , "olof@lixom.net" , "horms+renesas@verge.net.au" , "geert+renesas@glider.be" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "m.szyprowski@samsung.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 8, 2019 at 2:26 PM Pascal PAILLET-LME wrote: > > I hope you are not trying to work around a bug in the driver by > > stripping out DMA configuration from the device tree, because then > > it is probably a better idea to fix the bug. > This is not a workaround. The PMIC can use the DMA over I2C bus. > Our goal is to avoid using a DMA channel for a consumer that generates a > very few traffic. Dma channels may lack for other use cases. > > If you agree, you can add the to the commit message. OK I understand, then also write it directly in the dts as a comment, so people understand why it is being removed when they just look in the device tree. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel