All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	William Breathitt Gray <vilhelm.gray@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	David Jander <david@protonic.nl>,
	Robin van der Gracht <robin@protonic.nl>,
	linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: counter: add pulse-counter binding
Date: Thu, 28 Jan 2021 09:17:23 +0100	[thread overview]
Message-ID: <CACRpkdY2XYi2jqYiXaBUfRO1+UEK3QCC8JQ0duENVGoOfYTmBA@mail.gmail.com> (raw)
In-Reply-To: <20210126131239.8335-2-o.rempel@pengutronix.de>

Hi Oleksij,

thanks for your patch!

On Tue, Jan 26, 2021 at 2:15 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> Add binding for the pulse counter node
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
(...)

> +properties:
> +  compatible:
> +    const: virtual,pulse-counter

What is so virtual about this? The device seems very real.
However it is certainly a GPIO counter.

I would call it "gpio-counter" simply.

Define:
  $nodename:
     pattern: "^counter(@.*)?$"

> +    counter-0 {

counter@0 {

> +    counter-1 {

counter@1 {

Thanks!
Linus Walleij

  reply	other threads:[~2021-01-28  8:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 13:12 [PATCH v4 0/2] add support for GPIO based counter Oleksij Rempel
2021-01-26 13:12 ` [PATCH v4 1/2] dt-bindings: counter: add pulse-counter binding Oleksij Rempel
2021-01-28  8:17   ` Linus Walleij [this message]
2021-01-28 13:39     ` Oleksij Rempel
2021-02-05 23:34       ` Rob Herring
2021-01-26 13:12 ` [PATCH v4 2/2] counter: add IRQ or GPIO based pulse counter Oleksij Rempel
2021-01-27  8:52   ` kernel test robot
2021-01-27  8:52     ` kernel test robot
2021-01-28  8:24   ` Linus Walleij
2021-01-28 13:58     ` Oleksij Rempel
2021-01-26 13:18 ` [PATCH v4 0/2] add support for GPIO based counter Marc Kleine-Budde
2021-01-27  6:44   ` Oleksij Rempel
2021-01-27  7:10     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdY2XYi2jqYiXaBUfRO1+UEK3QCC8JQ0duENVGoOfYTmBA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.