From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D03FA3728 for ; Wed, 16 Oct 2019 12:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78B9721925 for ; Wed, 16 Oct 2019 12:27:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YFoZ+P9H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391044AbfJPM16 (ORCPT ); Wed, 16 Oct 2019 08:27:58 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42767 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390999AbfJPM15 (ORCPT ); Wed, 16 Oct 2019 08:27:57 -0400 Received: by mail-qt1-f196.google.com with SMTP id w14so35734304qto.9 for ; Wed, 16 Oct 2019 05:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RiitUgtPHWYB471TBDHiVHPPALR+DVcpaO06JHpx/Ks=; b=YFoZ+P9HHoSoLVHZecxRW+Z7+f5LggWJqYiP/+udF6k8cZBRCQRsm8W8AwvIMcyD6J zTw6j4UEPKQKVMpk2gJnDJoOksG/VEM42AGDsdK/YZyvHpkkYyC8SKShI7Agk6xfypfJ k0nLAPhKyNxQWeYBhOEk7LuzIHr8mqN/lTDSJFSLPoXiSfAlJVCewPyLfZD8+7j+5AAN FEY34BuDnOTiVkBk1hYZCoocdavCaQCeBlt8eW+zStBLnFGieKwX13ennTtwM4s0iYje F3DBnl5Fg6qyga8kRN1/JGplByRpdSwo3UHi51A8RpphiOx14cymS/FA0PVlTS33uYb9 KGTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RiitUgtPHWYB471TBDHiVHPPALR+DVcpaO06JHpx/Ks=; b=XsqfOIjWMQSW6C6dCFKfDjrstTVmyyUwn08dCGq345s11q6J2sfsyvyDyVA/8cQzza yrhpQ972jHxgv9npzRH2UZVbgskGCuV1zFxacUNDNtVtTUmIa5ZN0T2pZtsDpgxWmyTp WLo263UyqpJMr2scHiZVN7y7sBdGjhApi02XeM6oeMlQzrPyxaJExx9Q4XW/a6cO/rwi F2sAsA5hSO9Il8LBN3oZud6yvEF3fuN/EQMj5M6bAd3ayQej3RI3yPrcztDYUcxOMnmP ADDAVXYCWgzcnbvFktNq/2y4YUXmvJJMRrtoUwUu4TWhYBAfyxBVRdgpuVw3lDsO6LQy 6FyA== X-Gm-Message-State: APjAAAUo62SCmqOPp9H0oEiaJUOnCvM0LRf8hcD9gUtyWWS64Va+xlEC GILyc5T9A7llZCctMQ7zefUahG3Yczp5tJmAQ+JSkg== X-Google-Smtp-Source: APXvYqzDHm0kSmPDqed4NoHcllkNpwqptCmh2deQ0fBpLLPQJG+ftMU1r99mU527MOglkMOMQ/pVQl9DwOdDGZP4UzM= X-Received: by 2002:aed:2462:: with SMTP id s31mr45321050qtc.40.1571228876746; Wed, 16 Oct 2019 05:27:56 -0700 (PDT) MIME-Version: 1.0 References: <20191015173026.9962-1-manivannan.sadhasivam@linaro.org> <20191015173026.9962-2-manivannan.sadhasivam@linaro.org> In-Reply-To: <20191015173026.9962-2-manivannan.sadhasivam@linaro.org> From: Linus Walleij Date: Wed, 16 Oct 2019 14:27:44 +0200 Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: Add devicetree binding for RDA Micro GPIO controller To: Manivannan Sadhasivam Cc: Bartosz Golaszewski , Linux ARM , linux-unisoc@lists.infradead.org, "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Orson Zhai Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam wrote: > Add YAML devicetree binding for RDA Micro GPIO controller. > > Signed-off-by: Manivannan Sadhasivam First: this looks awesome to me, Second: since this is kind of a first... could we move the standard GPIOchip YAML business into a generic gpiochip .yaml file? We currently only have pl061-gpio.yaml and this would duplicate a lot of the stuff from that yaml file. If you look at how display/panel/panel-common.yaml is used from say display/panel/ti,nspire.yaml Could we do something similar and lift out all the generics from gpio-pl061.yaml to gpio-common.yaml and reference that also in the new binding? If it seems hard, tell me and I can take a stab at it. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6B6FA372A for ; Wed, 16 Oct 2019 12:28:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2EB721925 for ; Wed, 16 Oct 2019 12:28:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nh9WCsuu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YFoZ+P9H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2EB721925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D0sTPDsJfmQg79L0Uxaf2A89JjGJg5T+BN0Y2uQDeF4=; b=Nh9WCsuu4ttzXp 6yxjJ7S1ja4U5zyVEe2O7zbyX8DGFk4cfYzxleHskzq4rI9uNk3QwxMb7pRkVbU5YM5+CxeGowUPZ xfWLFgp3+dQdLLM7tV7XVfzVTENF+zlXIItYQisOW9nc7/yJDJft5JDndtvh3JipUFooYuEwB9wRZ gwMdWdbW5pg9FAGdbqvDtL+ugofo7TLCsOraKYAX2g2AKlmizQkynbQ8l56J9uIhDBkkld4I8JUgU qw3E8D9TEhh+Ce6sqNbIdL5fl55HynONjm/vQITo8k0DKx0rq3VSSD4hgDqAuYlgJZjfZwcNw9BXT 7xMz2bCNk7y/N/NVTFvg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKiPK-0005P5-3b; Wed, 16 Oct 2019 12:28:02 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKiPG-0005O8-L6 for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 12:27:59 +0000 Received: by mail-qt1-x843.google.com with SMTP id 3so35841768qta.1 for ; Wed, 16 Oct 2019 05:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RiitUgtPHWYB471TBDHiVHPPALR+DVcpaO06JHpx/Ks=; b=YFoZ+P9HHoSoLVHZecxRW+Z7+f5LggWJqYiP/+udF6k8cZBRCQRsm8W8AwvIMcyD6J zTw6j4UEPKQKVMpk2gJnDJoOksG/VEM42AGDsdK/YZyvHpkkYyC8SKShI7Agk6xfypfJ k0nLAPhKyNxQWeYBhOEk7LuzIHr8mqN/lTDSJFSLPoXiSfAlJVCewPyLfZD8+7j+5AAN FEY34BuDnOTiVkBk1hYZCoocdavCaQCeBlt8eW+zStBLnFGieKwX13ennTtwM4s0iYje F3DBnl5Fg6qyga8kRN1/JGplByRpdSwo3UHi51A8RpphiOx14cymS/FA0PVlTS33uYb9 KGTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RiitUgtPHWYB471TBDHiVHPPALR+DVcpaO06JHpx/Ks=; b=taKayxGEo859oQmFeAv/C89Wp+GH3D6myr4tujep3Agch8Ph8V7vlOD2OHHU3fGLh3 D+PqpMRgM7aCAhanPf2oOdeP01d7wmXD+qx54frgwpWJLCoxPK2Ytk16/pRqcj2+w4/S 1RR4euC8CRhgB1l+uywovL8czhS7Z04GV4mLkXT33pzTk/YL823yepn2iitBEnfuS4zy y3UbGW8yrP/pdNEIX09fXUzz6R2+EGHytbSWzpEaaL9ZUg1sDwHLFFyZKAQfpIftC2TV rscWvJIYRr3nvL3lyE51MPxDH6w1i43fzml0iwBiFWbyDlryYLAvr/wXY5ZuFWQ3CrEy Yw/w== X-Gm-Message-State: APjAAAX4Ll8822+/ESmNKqA31Ngq8PTaZ5Mmk8y9RqBC+5W/hwl+hoHS Dqa5tbap80haOBJDNt/qwvWj0Qb4iWGwiPPyIp0HU8Eu X-Google-Smtp-Source: APXvYqzDHm0kSmPDqed4NoHcllkNpwqptCmh2deQ0fBpLLPQJG+ftMU1r99mU527MOglkMOMQ/pVQl9DwOdDGZP4UzM= X-Received: by 2002:aed:2462:: with SMTP id s31mr45321050qtc.40.1571228876746; Wed, 16 Oct 2019 05:27:56 -0700 (PDT) MIME-Version: 1.0 References: <20191015173026.9962-1-manivannan.sadhasivam@linaro.org> <20191015173026.9962-2-manivannan.sadhasivam@linaro.org> In-Reply-To: <20191015173026.9962-2-manivannan.sadhasivam@linaro.org> From: Linus Walleij Date: Wed, 16 Oct 2019 14:27:44 +0200 Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: Add devicetree binding for RDA Micro GPIO controller To: Manivannan Sadhasivam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_052758_688433_E458FF25 X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , linux-unisoc@lists.infradead.org, Orson Zhai , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam wrote: > Add YAML devicetree binding for RDA Micro GPIO controller. > > Signed-off-by: Manivannan Sadhasivam First: this looks awesome to me, Second: since this is kind of a first... could we move the standard GPIOchip YAML business into a generic gpiochip .yaml file? We currently only have pl061-gpio.yaml and this would duplicate a lot of the stuff from that yaml file. If you look at how display/panel/panel-common.yaml is used from say display/panel/ti,nspire.yaml Could we do something similar and lift out all the generics from gpio-pl061.yaml to gpio-common.yaml and reference that also in the new binding? If it seems hard, tell me and I can take a stab at it. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel