All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Eric Anholt <eric@anholt.net>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH] pinctrl: bcm2835: Pass irqchip when adding gpiochip
Date: Fri, 23 Aug 2019 11:06:32 +0200	[thread overview]
Message-ID: <CACRpkdY7oHKYg0_8jRaDZJmTgE8oAUyFCCEB9Qq5G5syn6+A6g@mail.gmail.com> (raw)
In-Reply-To: <a82230ae-4f3a-2600-0bea-85c432c56d05@i2se.com>

On Fri, Aug 23, 2019 at 10:07 AM Stefan Wahren <stefan.wahren@i2se.com> wrote:

> On 23.08.19 09:46, Linus Walleij wrote:
> > On Mon, Aug 12, 2019 at 8:29 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> >> We need to convert all old gpio irqchips to pass the irqchip
> >> setup along when adding the gpio_chip. For more info see
> >> drivers/gpio/TODO.
> >>
> >> For chained irqchips this is a pretty straight-forward
> >> conversion. The BCM2835 has multiple parents so let's
> >> exploit the new facility in the GPIO_IRQCHIP to actually
> >> deal with multiple parents.
> >>
> >> Cc: Simon Arlott <simon@arlott.org>
> >> Cc: Eric Anholt <eric@anholt.net>
> >> Cc: Stefan Wahren <stefan.wahren@i2se.com>
> >> Cc: Thierry Reding <treding@nvidia.com>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > This patch is a bit scary because I haven't tried converting multiple
> > parents before. Any chance one of you RPi people could give it
> > a test run, so you don't have to experience testing it in linux-next?
>
> it's on my TODO list, but i didn't had the time to test it yet.

OK sorry for stressing :(

> Can you give me some test ideas?

Anything that fires IRQ on the pin controller is a good test,
I sometimes just use tools/gpio/gpio-event-mon.c (the
more elaborate version is inside libgpiod) and have some
pushbutton or wire to ground the GPIO line under test.

Yours,
Linus Walleij

  reply	other threads:[~2019-08-23  9:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  6:27 [PATCH] pinctrl: bcm2835: Pass irqchip when adding gpiochip Linus Walleij
2019-08-12  6:48 ` Simon Arlott
2019-08-23  7:46 ` Linus Walleij
2019-08-23  8:07   ` Stefan Wahren
2019-08-23  9:06     ` Linus Walleij [this message]
2019-08-23 19:00     ` Stefan Wahren
2019-08-23 21:04       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdY7oHKYg0_8jRaDZJmTgE8oAUyFCCEB9Qq5G5syn6+A6g@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=eric@anholt.net \
    --cc=linux-gpio@vger.kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.