All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org, Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpiolib: Fix locking on gpio debugfs files
Date: Mon, 11 Feb 2013 15:31:45 +0100	[thread overview]
Message-ID: <CACRpkdYBQDCuyff1cVaG2p_AaFvZ-sEX0B=j=Y4nsko8UDChHA@mail.gmail.com> (raw)
In-Reply-To: <1360406062-14982-1-git-send-email-grant.likely@secretlab.ca>

On Sat, Feb 9, 2013 at 11:34 AM, Grant Likely <grant.likely@secretlab.ca> wrote:

> The debugfs files really need to hold the gpiolib spinlock before
> accessing the list. Otherwise chip addition/removal will cause an oops.
>
> Cc: Alexandre Courbot <acourbot@nvidia.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

> I've also got a draft patch that turns gpio chips into first-class
> kobjects which means we can do proper reference counting on them and
> prevent the structure from actually disappearing while other drivers
> still hold references.

Thank you for doing this!

Yours,
Linus Walleij

      parent reply	other threads:[~2013-02-11 14:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-09 10:34 [PATCH] gpiolib: Fix locking on gpio debugfs files Grant Likely
2013-02-11  4:28 ` Alex Courbot
2013-02-11 11:31   ` Grant Likely
2013-02-12  2:27     ` Alexandre Courbot
2013-02-11 14:31 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYBQDCuyff1cVaG2p_AaFvZ-sEX0B=j=Y4nsko8UDChHA@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=acourbot@nvidia.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.