All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: eric.ernst@linux.intel.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mark Gross <mark.gross@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v4 1/1] pinctrl: baytrail: Warn if direct IRQ GPIO set to output
Date: Mon, 7 Jul 2014 12:19:58 +0200	[thread overview]
Message-ID: <CACRpkdYBfRf7Ztgd2wW=HfCNTNdOtpe70iVGULrQVcOh0W9J1g@mail.gmail.com> (raw)
In-Reply-To: <1402596380-18783-1-git-send-email-eric.ernst@linux.intel.com>

On Thu, Jun 12, 2014 at 8:06 PM,  <eric.ernst@linux.intel.com> wrote:

> From: Eric Ernst <eric.ernst@linux.intel.com>
>
> For Baytrail, you should never set a GPIO set to direct_irq
> to output mode.  When direct_irq_en is set for a GPIO, it is
> tied directly to an APIC internally, and making the pad output
> does not make any sense. Assert a WARN() in the event this happens.
>
> Signed-off-by: Eric Ernst <eric.ernst@linux.intel.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Patch applied.

Sorry for the delay.

Yours,
Linus Walleij

  reply	other threads:[~2014-07-07 10:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0140602191416.GD1730@lahna.fi.intel.com>
2014-06-02 21:12 ` [PATCH v2 1/1] PINCTRL: Warn if direct IRQ GPIO set to output eric.ernst
2014-06-03 11:06   ` Mika Westerberg
2014-06-03 22:25     ` [PATCH v3 1/1] pinctrl: baytrail: " eric.ernst
2014-06-04  8:22       ` Mika Westerberg
2014-06-12  7:49       ` Linus Walleij
2014-06-12 18:06         ` [PATCH v4 " eric.ernst
2014-07-07 10:19           ` Linus Walleij [this message]
2014-07-07 21:14           ` Linus Walleij
2014-07-09  0:33             ` eric ernst
2014-06-03 12:49   ` [PATCH v2 1/1] PINCTRL: " Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYBfRf7Ztgd2wW=HfCNTNdOtpe70iVGULrQVcOh0W9J1g@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=eric.ernst@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.gross@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.