All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-gpio@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 1/2] pinctrl: mcp23s08: Rename and change function that wraps regmap_update_bits()
Date: Wed, 29 Mar 2023 16:31:50 +0200	[thread overview]
Message-ID: <CACRpkdYCkY2Lxedm9mKdghT6B8KuKaeqKTpa7W=sH0V_XX9Evw@mail.gmail.com> (raw)
In-Reply-To: <20230324164957.485924-2-u.kleine-koenig@pengutronix.de>

On Fri, Mar 24, 2023 at 5:50 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

> The semantic of mcp_set_mask() was surprising to me when I first read
> that driver. So it was unexpected that in the call
>
>         mcp_set_mask(mcp, MCP_OLAT, mask, value);
>
> value was a bool. Make the function a thinner wrapper around
> regmap_update_bits() and rename it to also have a similar name.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Both patches applied, thanks!

Yours,
Linus Walleij

  reply	other threads:[~2023-03-29 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 16:49 [PATCH v2 0/2] pinctrl: mcp23s08: Implement gpio bulk functions Uwe Kleine-König
2023-03-24 16:49 ` [PATCH v2 1/2] pinctrl: mcp23s08: Rename and change function that wraps regmap_update_bits() Uwe Kleine-König
2023-03-29 14:31   ` Linus Walleij [this message]
2023-03-24 16:49 ` [PATCH v2 2/2] pinctrl: mcp23s08: Implement gpio bulk functions Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYCkY2Lxedm9mKdghT6B8KuKaeqKTpa7W=sH0V_XX9Evw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-gpio@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.