All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-gpio@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	Mylene Josserand <mylene.josserand@free-electrons.com>
Subject: Re: [PATCH] pinctrl: axp209: dereference pointer after it's been set
Date: Wed, 20 Dec 2017 09:07:32 +0100	[thread overview]
Message-ID: <CACRpkdYDe6NePVw1WCR_CqBYnkje0LiFk5mnH-yJ9s2shD96cA@mail.gmail.com> (raw)
In-Reply-To: <20171213085503.31899-1-quentin.schulz@free-electrons.com>

On Wed, Dec 13, 2017 at 9:55 AM, Quentin Schulz
<quentin.schulz@free-electrons.com> wrote:

> The number of GPIOs is gotten from a field within the structure
> referenced in the of_device.data but it was actually read before it was
> retrieved, thus it was dereferencing a null pointer.
>
> Set the number of GPIOs after retrieving of_device.data.
>
> Fixes: e1190083b89b ("pinctrl: axp209: add support for AXP813 GPIOs")
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> Reported-by: Mylène Josserand <mylene.josserand@free-electrons.com>

Patch applied with the tags for test and ACK.

Yours,
Linus Walleij

      parent reply	other threads:[~2017-12-20  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  8:55 [PATCH] pinctrl: axp209: dereference pointer after it's been set Quentin Schulz
2017-12-13  8:55 ` Quentin Schulz
     [not found] ` <20171213085503.31899-1-quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-12-13  9:20   ` Mylene JOSSERAND
2017-12-13  9:20     ` Mylene JOSSERAND
     [not found]     ` <20171213102048.1c7e3b7f-K8i4uRanGBt8XcdJbWeDu7NAH6kLmebB@public.gmane.org>
2017-12-14  3:05       ` Chen-Yu Tsai
2017-12-14  3:05         ` Chen-Yu Tsai
2017-12-20  8:07 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYDe6NePVw1WCR_CqBYnkje0LiFk5mnH-yJ9s2shD96cA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mylene.josserand@free-electrons.com \
    --cc=quentin.schulz@free-electrons.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.