From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs() Date: Thu, 7 Jan 2016 10:07:51 +0100 Message-ID: References: <1452126010-1111-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ob0-f178.google.com ([209.85.214.178]:33099 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722AbcAGJHw (ORCPT ); Thu, 7 Jan 2016 04:07:52 -0500 Received: by mail-ob0-f178.google.com with SMTP id bx1so294600186obb.0 for ; Thu, 07 Jan 2016 01:07:52 -0800 (PST) In-Reply-To: <1452126010-1111-1-git-send-email-linux@roeck-us.net> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Guenter Roeck Cc: Alexandre Courbot , Michal Simek , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck wrote: > Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces > the use of container_of() with gpiochip_get_data(). Unfortunately, the > data pointer is not yet set by the time xgpio_save_regs() is called, > causing a system hang. > > Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") > Signed-off-by: Guenter Roeck > --- > It might make sense to merge this patch with the patch introducing the problem. Patch applied, thanks for finding and fixing this so quick! (I hope I haven't created too many of these regressions...) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbcAGJH7 (ORCPT ); Thu, 7 Jan 2016 04:07:59 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:33099 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752747AbcAGJHw (ORCPT ); Thu, 7 Jan 2016 04:07:52 -0500 MIME-Version: 1.0 In-Reply-To: <1452126010-1111-1-git-send-email-linux@roeck-us.net> References: <1452126010-1111-1-git-send-email-linux@roeck-us.net> Date: Thu, 7 Jan 2016 10:07:51 +0100 Message-ID: Subject: Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs() From: Linus Walleij To: Guenter Roeck Cc: Alexandre Courbot , Michal Simek , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck wrote: > Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces > the use of container_of() with gpiochip_get_data(). Unfortunately, the > data pointer is not yet set by the time xgpio_save_regs() is called, > causing a system hang. > > Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") > Signed-off-by: Guenter Roeck > --- > It might make sense to merge this patch with the patch introducing the problem. Patch applied, thanks for finding and fixing this so quick! (I hope I haven't created too many of these regressions...) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Thu, 7 Jan 2016 10:07:51 +0100 Subject: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs() In-Reply-To: <1452126010-1111-1-git-send-email-linux@roeck-us.net> References: <1452126010-1111-1-git-send-email-linux@roeck-us.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck wrote: > Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces > the use of container_of() with gpiochip_get_data(). Unfortunately, the > data pointer is not yet set by the time xgpio_save_regs() is called, > causing a system hang. > > Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") > Signed-off-by: Guenter Roeck > --- > It might make sense to merge this patch with the patch introducing the problem. Patch applied, thanks for finding and fixing this so quick! (I hope I haven't created too many of these regressions...) Yours, Linus Walleij