From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88B2C43217 for ; Thu, 16 Sep 2021 22:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93B4361263 for ; Thu, 16 Sep 2021 22:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235393AbhIPWzR (ORCPT ); Thu, 16 Sep 2021 18:55:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235109AbhIPWzQ (ORCPT ); Thu, 16 Sep 2021 18:55:16 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16F22C061574 for ; Thu, 16 Sep 2021 15:53:55 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id g1so24813983lfj.12 for ; Thu, 16 Sep 2021 15:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=64aRGDxfXVoa1qTlY3upuJ19yGXpI/+Kdh+ykSMARUA=; b=PTTrrtcAQ0MZYQljqcAEHN2QYzJVOe5PNdmKDLNHnXNOiptmi9UeFaAlszfg18iSvT eiofM9HmyYDvNuV1FZzVEmPcDKqNj4trR4GHfSKgNODjbzaFWGTvt+LhT0S7iUvFa+AQ tNcfKN8zWtSBaXEAawLyLfvAWYTDFL/WImrGXyAdrERGD8EuOsrZ0iMqBb9GzDaWes0k 2FtXnVaX6RrQ+Ov8K0KA1+1V7MJvBEB/ztwWsdRpr8+5qiMtqZfuBKUI7wE/orRw8Wsa Q50iSggylqcR6T2ihn2SYgYbNLABcZISk7Vp0Ml3MQtXVnF6F6r2As0l1+n1UzjVz61k 1ZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=64aRGDxfXVoa1qTlY3upuJ19yGXpI/+Kdh+ykSMARUA=; b=BHpbkv6EpHLqZGhMmXpq1SlRZ0c9BtXqbOmzg5bUoRvMdj1sme3eNOuKAUj5CMPybx 3ia0euZ+VWhtFe4xPapPt59pYqu5fTWOyOEZnwIkM/mVWf7fyGHQZ0oownSi1nbsZ5V1 sjb681pRRxrooSRJzXR+7mOd8cz1CYHJFEOkss6XaLsV8EtrB97/Gr4hOVTZ36RF35hI AcycSDy7X4CEp3bJgj0ylRnhcjxw0FTQLC3A4pwNjwsB+GmSHJKIbdunUTEA5Xf5tvOy MYV1QgJ7Qi1gO7X2WS33fU8pNTac/eQWihO0bh4H8BLcby8/8bCw+lKmh5Z6QOau5a9G 33jg== X-Gm-Message-State: AOAM531zwJ1y7EVF3JYC4nZ7bZSikwlEgjNuL79FIqqebBe/1yAxAc3p QImF7XdCUaevgA2OeuDH+WZ4Swshx36ngq6LajDFpw== X-Google-Smtp-Source: ABdhPJwx8ITFkSsQzaVlRuqb8ifRkDnCbGjxFukpklP6ZORMZwGg6j2a4KP6PgB3oxlHxBr2VGB/Qe7r2bMKHCu2gfY= X-Received: by 2002:a05:6512:e89:: with SMTP id bi9mr5641322lfb.95.1631832833481; Thu, 16 Sep 2021 15:53:53 -0700 (PDT) MIME-Version: 1.0 References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-8-maxime@cerno.tech> In-Reply-To: <20210901091852.479202-8-maxime@cerno.tech> From: Linus Walleij Date: Fri, 17 Sep 2021 00:53:42 +0200 Message-ID: Subject: Re: [PATCH v2 07/52] dt-bindings: bluetooth: broadcom: Fix clocks check To: Maxime Ripard Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Frank Rowand , Chen-Yu Tsai , =?UTF-8?Q?Jernej_=C5=A0krabec?= , Linux ARM , linux-sunxi , "David S. Miller" , Jakub Kicinski , netdev , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 1, 2021 at 11:19 AM Maxime Ripard wrote: > The original binding was mentioning that valid values for the clocks and > clock-names property were one or two clocks from extclk, txco and lpo, > with extclk being deprecated in favor of txco. > > However, the current binding lists a valid array as extclk, txco and > lpo, with either one or two items. > > While this looks similar, it actually enforces that all the device trees > use either ["extclk"], or ["extclk", "txco"]. That doesn't make much > sense, since the two clocks are said to be equivalent, with one > superseeding the other. > > lpo is also not a valid clock anymore, and would be as the third clock > of the list, while we could have only this clock in the previous binding > (and in DTs). > > Let's rework the clock clause to allow to have either: > > - extclk, and mark it a deprecated > - txco alone > - lpo alone > - txco, lpo > > While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device > tree so it's not an issue in practice. > > Similarly, ["lpo", "txco"] is still considered invalid, but it's > generally considered as a best practice to fix the order of clocks. > > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Linus Walleij > Cc: netdev@vger.kernel.org > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E8B2C433F5 for ; Thu, 16 Sep 2021 22:55:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58A0A61207 for ; Thu, 16 Sep 2021 22:55:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 58A0A61207 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FEM5irZoZrfCxaLblnKKWFdpbQ7ftDpQ7bWeSNC0o1A=; b=dndGh7ikocRYTd pm/mNWxbFrWWvdyPV5B2upWCPpoSN1Ews+2xMavdAhZ0DldKY0vHZNX/TbHBlMA7fD8zDzSqxlGou ljEfw17M6WWowI309OObRuQZN/DIIdpCyBtw1PK0XgUptUNU3TItr+IdKFdqS+jmZcDvME9P3v1Uj ZloLdkx5jO00immKWwMhX9e40e8plWvr18tuwtr4ebAYhXcp9tg0uvyEG1zdQGeIyZEXjX/2i8yif FdDF3J4DxBty2mAXzHalviRblBuZZxY1E/xt3AC3yLRFKgHF5fwCOwd1bl13DgCOJ3fQyohPaJWvi vGOuwowTeOOPUbCI82Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR0GU-00CYQn-6b; Thu, 16 Sep 2021 22:53:58 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR0GR-00CYQQ-3S for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 22:53:56 +0000 Received: by mail-lf1-x12a.google.com with SMTP id m3so22957491lfu.2 for ; Thu, 16 Sep 2021 15:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=64aRGDxfXVoa1qTlY3upuJ19yGXpI/+Kdh+ykSMARUA=; b=PTTrrtcAQ0MZYQljqcAEHN2QYzJVOe5PNdmKDLNHnXNOiptmi9UeFaAlszfg18iSvT eiofM9HmyYDvNuV1FZzVEmPcDKqNj4trR4GHfSKgNODjbzaFWGTvt+LhT0S7iUvFa+AQ tNcfKN8zWtSBaXEAawLyLfvAWYTDFL/WImrGXyAdrERGD8EuOsrZ0iMqBb9GzDaWes0k 2FtXnVaX6RrQ+Ov8K0KA1+1V7MJvBEB/ztwWsdRpr8+5qiMtqZfuBKUI7wE/orRw8Wsa Q50iSggylqcR6T2ihn2SYgYbNLABcZISk7Vp0Ml3MQtXVnF6F6r2As0l1+n1UzjVz61k 1ZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=64aRGDxfXVoa1qTlY3upuJ19yGXpI/+Kdh+ykSMARUA=; b=RkV7f597fpLVvrIm8JncczEZa8DBGueEnjszl07AmzRlgEBY1ssaHm6a5CGmlUVEbX PSRT8PuB3SHqmn0iZX9tHK0O9vRSbxECZu/HmH3K3H2gRG19UyOF97wNQKbXOGpz5LKC 587xVZdJ5CBHwV/yiBQWWrzy3IDrisFQLA2QptUQN78XQu9ZIyb8gfPb92unkB6aA6Pg E/4mtXcIxSbj1W18L6x81Xx3tmydA5/c8QR8zrJyMnXQGLNOUImr8TAAGqbSxMG3rSK5 pHMHttBRclYpZVLms0Sh6WXGBcM9N+yOo/7uGCKMLxgpn4vtIAOq7Y3dLSJKB8FhHVFK HUjQ== X-Gm-Message-State: AOAM533OGlcukoZnREdez2czOpGoJUjTC1UQukKzfd6v2N4RWiYPZpOi 7Soo5XsYWvnoZtYVsXrKplqRo5JXZuu1O1IuTs9Nfw== X-Google-Smtp-Source: ABdhPJwx8ITFkSsQzaVlRuqb8ifRkDnCbGjxFukpklP6ZORMZwGg6j2a4KP6PgB3oxlHxBr2VGB/Qe7r2bMKHCu2gfY= X-Received: by 2002:a05:6512:e89:: with SMTP id bi9mr5641322lfb.95.1631832833481; Thu, 16 Sep 2021 15:53:53 -0700 (PDT) MIME-Version: 1.0 References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-8-maxime@cerno.tech> In-Reply-To: <20210901091852.479202-8-maxime@cerno.tech> From: Linus Walleij Date: Fri, 17 Sep 2021 00:53:42 +0200 Message-ID: Subject: Re: [PATCH v2 07/52] dt-bindings: bluetooth: broadcom: Fix clocks check To: Maxime Ripard Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Frank Rowand , Chen-Yu Tsai , =?UTF-8?Q?Jernej_=C5=A0krabec?= , Linux ARM , linux-sunxi , "David S. Miller" , Jakub Kicinski , netdev , Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_155355_187881_D71CD5F2 X-CRM114-Status: GOOD ( 21.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 1, 2021 at 11:19 AM Maxime Ripard wrote: > The original binding was mentioning that valid values for the clocks and > clock-names property were one or two clocks from extclk, txco and lpo, > with extclk being deprecated in favor of txco. > > However, the current binding lists a valid array as extclk, txco and > lpo, with either one or two items. > > While this looks similar, it actually enforces that all the device trees > use either ["extclk"], or ["extclk", "txco"]. That doesn't make much > sense, since the two clocks are said to be equivalent, with one > superseeding the other. > > lpo is also not a valid clock anymore, and would be as the third clock > of the list, while we could have only this clock in the previous binding > (and in DTs). > > Let's rework the clock clause to allow to have either: > > - extclk, and mark it a deprecated > - txco alone > - lpo alone > - txco, lpo > > While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device > tree so it's not an issue in practice. > > Similarly, ["lpo", "txco"] is still considered invalid, but it's > generally considered as a best practice to fix the order of clocks. > > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Linus Walleij > Cc: netdev@vger.kernel.org > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard Looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel