* [PATCH] pinctrl: tegra: Staticize non-exported symbols
@ 2012-11-11 2:31 Axel Lin
2012-11-12 16:13 ` Stephen Warren
2012-11-15 10:20 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-11-11 2:31 UTC (permalink / raw)
To: Linus Walleij; +Cc: Stephen Warren, linux-kernel
They are not referenced outside of this file, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-tegra.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-tegra.c b/drivers/pinctrl/pinctrl-tegra.c
index 7da0b37..4dfa902 100644
--- a/drivers/pinctrl/pinctrl-tegra.c
+++ b/drivers/pinctrl/pinctrl-tegra.c
@@ -178,8 +178,9 @@ static int add_config(struct device *dev, unsigned long **configs,
return 0;
}
-void tegra_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
- struct pinctrl_map *map, unsigned num_maps)
+static void tegra_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
+ struct pinctrl_map *map,
+ unsigned num_maps)
{
int i;
@@ -209,11 +210,11 @@ static const struct cfg_param {
{"nvidia,slew-rate-rising", TEGRA_PINCONF_PARAM_SLEW_RATE_RISING},
};
-int tegra_pinctrl_dt_subnode_to_map(struct device *dev,
- struct device_node *np,
- struct pinctrl_map **map,
- unsigned *reserved_maps,
- unsigned *num_maps)
+static int tegra_pinctrl_dt_subnode_to_map(struct device *dev,
+ struct device_node *np,
+ struct pinctrl_map **map,
+ unsigned *reserved_maps,
+ unsigned *num_maps)
{
int ret, i;
const char *function;
@@ -288,9 +289,10 @@ exit:
return ret;
}
-int tegra_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
- struct device_node *np_config,
- struct pinctrl_map **map, unsigned *num_maps)
+static int tegra_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
+ struct device_node *np_config,
+ struct pinctrl_map **map,
+ unsigned *num_maps)
{
unsigned reserved_maps;
struct device_node *np;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: tegra: Staticize non-exported symbols
2012-11-11 2:31 [PATCH] pinctrl: tegra: Staticize non-exported symbols Axel Lin
@ 2012-11-12 16:13 ` Stephen Warren
2012-11-15 10:20 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Warren @ 2012-11-12 16:13 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Stephen Warren, linux-kernel
On 11/10/2012 07:31 PM, Axel Lin wrote:
> They are not referenced outside of this file, make them static.
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: tegra: Staticize non-exported symbols
2012-11-11 2:31 [PATCH] pinctrl: tegra: Staticize non-exported symbols Axel Lin
2012-11-12 16:13 ` Stephen Warren
@ 2012-11-15 10:20 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2012-11-15 10:20 UTC (permalink / raw)
To: Axel Lin; +Cc: Stephen Warren, linux-kernel
On Sun, Nov 11, 2012 at 3:31 AM, Axel Lin <axel.lin@ingics.com> wrote:
> They are not referenced outside of this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied with Stephen's ACK, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-15 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-11 2:31 [PATCH] pinctrl: tegra: Staticize non-exported symbols Axel Lin
2012-11-12 16:13 ` Stephen Warren
2012-11-15 10:20 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.