From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] pinctrl: export pin_request to support parent pin Date: Tue, 6 Sep 2016 15:55:12 +0200 Message-ID: References: <1472213942-4815-1-git-send-email-jun.nie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f51.google.com ([209.85.218.51]:36461 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755568AbcIFNzO (ORCPT ); Tue, 6 Sep 2016 09:55:14 -0400 Received: by mail-oi0-f51.google.com with SMTP id w78so100996337oie.3 for ; Tue, 06 Sep 2016 06:55:13 -0700 (PDT) In-Reply-To: <1472213942-4815-1-git-send-email-jun.nie@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Jun Nie Cc: "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Shawn Guo , Jason Liu On Fri, Aug 26, 2016 at 2:19 PM, Jun Nie wrote: > Some pin functions may be controlled in 2nd level multiplex. > We need configure 1st level multiplex when request such > functions. Export pin_request functionality so that parent > can be configured automatically with calling it in > pinmux_ops->request(). > > Signed-off-by: Jun Nie This looks weird as 1/3, please put the DT bindings first in the series. We first need to agree on how to represent this before we start hacking around in the core to support different shortcuts. This patch just makes me nervous, but maybe I can be convinced otherwise if we get some details on how the hardware works and why this is necessary. Yours, Linus Walleij