From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5A0C433EF for ; Tue, 28 Sep 2021 14:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21AC56120D for ; Tue, 28 Sep 2021 14:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241283AbhI1OcQ (ORCPT ); Tue, 28 Sep 2021 10:32:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241279AbhI1OcK (ORCPT ); Tue, 28 Sep 2021 10:32:10 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13228C06161C for ; Tue, 28 Sep 2021 07:30:31 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id x27so8717459lfa.9 for ; Tue, 28 Sep 2021 07:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=bt1vQ9mFtLWbSomTDSPbF5QE3RLYCRSGiCjPdnKP0BYNmZ22nN/5dQreFOHtJlZP9A w1Ju27SQF3MMrUPKopIdjsdV0fU69078TLg3O6fDK6EtaBVBFxWWwokt6QgWln5o8xT/ 0FE64IiWO7MHsJ9hCkLWJ0A73tKdDUIHDA2H6cYZe3v+aaEsZvFVbmFcynWdoX4JFqyW VHhtrRCMq587NZq3jdj7pcF+xc6daSurloZBhgz178YbCvxjCtZ9KIVs5/G/eVu3cZz0 O2DoTHqZJqv61DW3iDhIzQkvY9RLrrmCkYy5YJEATVCpeoiBUANGdDnTN7VJiWwB9a31 i2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=xkTHasuQZKkRhEXPNXkR8VSll9IiALXHoczgUF6zewBAxiFo1HbJkmxZZUZEr6ze3r CMyr7JBxdWpBWHP1lBINw1DRpc0EQ4F1xLxAeBryiGiK7ff7R7bshIV+BBrjtkynNbXN b8dBs1e72hAVo6VM0JE28yeb8vpqfjMMCuGOC43wCOOoW9zYrEFe56q6lGhveJxbawnt vNcMt57SjEty+kGZTpC9yPJXr+Z2eleaFBgJc767Tccnnsn/PDqc4/9kXGgHDlQAsxz7 klUZX+hTGXDUkiIcFtZgprzf6Wlgpniiv7FEKuQsiXqO9NQyB4m5VjUp8pkbin29+HRu eoqA== X-Gm-Message-State: AOAM533oAgNPeMEbhCexJLJ33REjk3ivEpc4noirAoAu3Pw7AzTyzn2U 34mijAqN/nRC4WLFs5/MQFN8Jf/vjLMHfl//nql+FA== X-Google-Smtp-Source: ABdhPJxrQ91FcoG1j8MqOj19A8jz0Mbb51yvmE4ezgOpcY+fkN/eVADQarawxS3wzP2LfC8q5vYwAWJL1ZqFFqpb/1o= X-Received: by 2002:a05:651c:1124:: with SMTP id e4mr253677ljo.261.1632839421344; Tue, 28 Sep 2021 07:30:21 -0700 (PDT) MIME-Version: 1.0 References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-7-caihuoqing@baidu.com> In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 16:30:09 +0200 Message-ID: Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > BTW, change the return value from 'ENXIO' to 'ENODEV', > perfer ENODEV which means no such device. > > Signed-off-by: Cai Huoqing > --- > v2->v3: Update the changelog. Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14132C433FE for ; Tue, 28 Sep 2021 14:30:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D867661206 for ; Tue, 28 Sep 2021 14:30:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D867661206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kfLqQ8VneRd4q1Mx4fv1olopmPOJ0gUWuJTBffvKYko=; b=cR/4DBvdqmH1I4 WNGxzLnOM4vZqMqypzMHFX6FQy02S++9/mNfYwIeGSAJsxM408T5DqqsFcRtz7pTaYvi4q9Ezfzhx GtOjLe9yxKchLkD3y7ELVLHV59yEZmLB3jmyw1002E+QqSPoWz8OzC82TZsJNvJPuVELnpUkXe36d 3Nj3ukvC7/6huoL/qz/cY6uy98LEPw/fe7iTyeWMUkI8jmKKreRcBPKWGU8WZmth2wPXemEmpyvms biFPUYLOWJ4znoMs+ZEWwOEE9xvgA+T6tKUbP2zC57w4Uve8nsdWVgeX/Zf8bVEN5vSx2LKOO75zZ WeWtmmlRI9mfS4/QS9pQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVE7y-007bT1-Gq; Tue, 28 Sep 2021 14:30:38 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVE7l-007bOy-0B for linux-rockchip@lists.infradead.org; Tue, 28 Sep 2021 14:30:26 +0000 Received: by mail-lf1-x134.google.com with SMTP id x27so93711342lfu.5 for ; Tue, 28 Sep 2021 07:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=bt1vQ9mFtLWbSomTDSPbF5QE3RLYCRSGiCjPdnKP0BYNmZ22nN/5dQreFOHtJlZP9A w1Ju27SQF3MMrUPKopIdjsdV0fU69078TLg3O6fDK6EtaBVBFxWWwokt6QgWln5o8xT/ 0FE64IiWO7MHsJ9hCkLWJ0A73tKdDUIHDA2H6cYZe3v+aaEsZvFVbmFcynWdoX4JFqyW VHhtrRCMq587NZq3jdj7pcF+xc6daSurloZBhgz178YbCvxjCtZ9KIVs5/G/eVu3cZz0 O2DoTHqZJqv61DW3iDhIzQkvY9RLrrmCkYy5YJEATVCpeoiBUANGdDnTN7VJiWwB9a31 i2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=iCmf28kTL/QPXjCY9AO9fSJeArcGM0MiMWHIIP9qDBQi36idTerUxaXyZoylq07i4Y D0W6LZhxLgk9uY504wfsHVWlUXFbguCr/UOTiGNuYanfT48RfMLcoZ13QzhoKyUx1UuC N+t/6IjCGZ/ZCvKUi5TPg4eYl42JxDIieBN5Pg2bFkPz3dnppiRb4WnfeFplUuUkcZMS OUAsQWYx0hflbaBaPafAdMTj4ed5F/iY0Jv44qO1RLtJRI+zOiSCJBUWRs2zm84vwaNR 5ME4rkqNc9rikMNZjGkq+DtPYSebItZl8C24bLO0KEHeOXUTkKlk8F7QNY6QDQyXVFBV 31nw== X-Gm-Message-State: AOAM531Qs+ecRYLlawB1IkXKTPKSdcyj1adA/qiszJ1NLG5OoVKPUFt5 ZbhbqkhWkKS35ofLDB+TX0NHItM2J5NqW9R6PtY4sg== X-Google-Smtp-Source: ABdhPJxrQ91FcoG1j8MqOj19A8jz0Mbb51yvmE4ezgOpcY+fkN/eVADQarawxS3wzP2LfC8q5vYwAWJL1ZqFFqpb/1o= X-Received: by 2002:a05:651c:1124:: with SMTP id e4mr253677ljo.261.1632839421344; Tue, 28 Sep 2021 07:30:21 -0700 (PDT) MIME-Version: 1.0 References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-7-caihuoqing@baidu.com> In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 16:30:09 +0200 Message-ID: Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_073025_056205_EF09933D X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > BTW, change the return value from 'ENXIO' to 'ENODEV', > perfer ENODEV which means no such device. > > Signed-off-by: Cai Huoqing > --- > v2->v3: Update the changelog. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94C3C433F5 for ; Tue, 28 Sep 2021 14:30:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AEA861206 for ; Tue, 28 Sep 2021 14:30:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AEA861206 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1RIWMLJqDwbBo2vbc9YXKHwifXD9tJhdggMJID9Gms8=; b=UoA11cOyU6Cyyj uUCSvISnKmODYX3uoG1W0D0EeuXF3UyxzUSDq+QKu0IwpaVDYEtTFK0yrY1kDjfnqZick2Y2IPAfD g3yGT5zlVWxAxr8pcaJQqI7u4FyCV/CsZIiBONz0dWW53qJX3m0HvNqtAC28nqmCepWXgGgR95pkx 55DmOcy3CYGM2eIDnAk6ONiD2CozbgEcjW1TNZZ3nEIR48GHu2BAlKq+FfO/mkfQ0F8Re80/BvbQk QDXMs5CXAzyZdKJk/b+AncFIHVzPXgyCO4XiHDprOgEiOf7srrHcAqeVt5+8LdajAke2UKrtZxvbT X1gipKChMmcBC+s5NbNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVE7z-007bTA-66; Tue, 28 Sep 2021 14:30:39 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVE7n-007bPj-Ta for linux-amlogic@lists.infradead.org; Tue, 28 Sep 2021 14:30:29 +0000 Received: by mail-lf1-x12c.google.com with SMTP id i25so93828838lfg.6 for ; Tue, 28 Sep 2021 07:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=bt1vQ9mFtLWbSomTDSPbF5QE3RLYCRSGiCjPdnKP0BYNmZ22nN/5dQreFOHtJlZP9A w1Ju27SQF3MMrUPKopIdjsdV0fU69078TLg3O6fDK6EtaBVBFxWWwokt6QgWln5o8xT/ 0FE64IiWO7MHsJ9hCkLWJ0A73tKdDUIHDA2H6cYZe3v+aaEsZvFVbmFcynWdoX4JFqyW VHhtrRCMq587NZq3jdj7pcF+xc6daSurloZBhgz178YbCvxjCtZ9KIVs5/G/eVu3cZz0 O2DoTHqZJqv61DW3iDhIzQkvY9RLrrmCkYy5YJEATVCpeoiBUANGdDnTN7VJiWwB9a31 i2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=VenkAZwiST98XLxvCatnChSdhkWIUsoMqqTB6O4NJxZRxRlRWHy4nYl/IYx+L7Zbdt Q/qSmngLl2o6S2XSXyMbmu+GZ3z+l7L6mR86TO+eItoKwwHfDCjLN5WAVKsEdeV9sPq4 pfZSBhtzv+hrWBrYdXmu4n1mzbl3wvBHAEv/j5lgssp2JrETgTHFrBJ5uXUsWMzCfuS6 h6T7ZDeKRVG8T4wCBPVkHHDErnTWaOyM/p1n4AlJ2eX+i+QXe5O74ot6d4zt1BQlBaQb 8StxoOPOCQeD78B2Lb3YsnGBOS6reEiA0JP78eeFqgX+J6D6UchaZUSL3nLAyhVV7pYA Z7JA== X-Gm-Message-State: AOAM532V6TPEiiR/lySB6lxnMzm0Wr4zX7CqvUbQw/cWTJGFx0LZ7sAv l9qFhzB0OPInBvv+IcO2CIzGcc8D9zRnbyDQm8D1XQ== X-Google-Smtp-Source: ABdhPJxrQ91FcoG1j8MqOj19A8jz0Mbb51yvmE4ezgOpcY+fkN/eVADQarawxS3wzP2LfC8q5vYwAWJL1ZqFFqpb/1o= X-Received: by 2002:a05:651c:1124:: with SMTP id e4mr253677ljo.261.1632839421344; Tue, 28 Sep 2021 07:30:21 -0700 (PDT) MIME-Version: 1.0 References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-7-caihuoqing@baidu.com> In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 16:30:09 +0200 Message-ID: Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_073027_976595_A891E1FE X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > BTW, change the return value from 'ENXIO' to 'ENODEV', > perfer ENODEV which means no such device. > > Signed-off-by: Cai Huoqing > --- > v2->v3: Update the changelog. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10584C433F5 for ; Tue, 28 Sep 2021 14:32:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C59A561209 for ; Tue, 28 Sep 2021 14:32:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C59A561209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jMSbUMx5pK5uHizMaN1sBtQ++C7/4ssMhNm2U+K5Pp0=; b=TWxP2ogZEqQJf4 MU4O/giiEdgSRfXucyS/doRdSY8fCIFhH2pPRW2O8YwdLz4Mndldo+694wlhjSOmrLgyBX0s763xu JgRHdRXq4DLTcwWn1aBkXJRoLqDOFVWyZkYxAOJtON3nAnM49qBGEMGRL6NeGrWcx6HkOE05Ad3B8 QsmU0hGmQCOGRx9EVQUzNpUO9n3nBRqbEGBCEGhdtQdtZRfzGLMyrjvxyw3tzEQE/9GxhekhlHHgq ZLaTej2TF6iYQ1YZjDAB3yzdk368Z3au2D98VKUl3pt4Pn6bbaaOHDGbvr2ZoCJpBS6xRymew/py+ AMk1D9bd2gAI/rkQ0jow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVE7n-007bPi-Bv; Tue, 28 Sep 2021 14:30:27 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVE7j-007bOJ-0e for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 14:30:24 +0000 Received: by mail-lf1-x136.google.com with SMTP id b20so94057783lfv.3 for ; Tue, 28 Sep 2021 07:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=bt1vQ9mFtLWbSomTDSPbF5QE3RLYCRSGiCjPdnKP0BYNmZ22nN/5dQreFOHtJlZP9A w1Ju27SQF3MMrUPKopIdjsdV0fU69078TLg3O6fDK6EtaBVBFxWWwokt6QgWln5o8xT/ 0FE64IiWO7MHsJ9hCkLWJ0A73tKdDUIHDA2H6cYZe3v+aaEsZvFVbmFcynWdoX4JFqyW VHhtrRCMq587NZq3jdj7pcF+xc6daSurloZBhgz178YbCvxjCtZ9KIVs5/G/eVu3cZz0 O2DoTHqZJqv61DW3iDhIzQkvY9RLrrmCkYy5YJEATVCpeoiBUANGdDnTN7VJiWwB9a31 i2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uh1B6XTocg/PuNZlNsHJ5qn3ywJ0pfLGKGnm5l1sB1s=; b=2rH7ZbKXZ4cGDvpKWkJYNk/33K/gAi4cYFRpP8HYOfesxScai0wvzL1LCF/10RV86r 4rA7HAC3jkd5hDUuMpzrbkHhfrBJzf9A90uDD+daPduTUJjR6f6eV71b+x9SSYyuxzJY isCeyTXrA+AO5b/df+pafPwnq4namlaZUqpqkm9uodxv18oWiDHp+29RXWjHqqzE+yoS 4s/VYkoWoQpizYFbmFrO/fGBHmZdWO1J9GDWPw5n8CANlstJoCPp7BhPL8T6QGhsBFr7 Y03EpTzX1RVWcJ1xA6gyroSzv9X6qaxemm5xt1DwkK0WOwe1dFgPa2hiRGIlwjDQXvEm bVwA== X-Gm-Message-State: AOAM5312Jrt4AWsPzKpmqMk+mfe0Mm8S57c3l51ZuGkAzPWsr4Xdec3t ORuRLUU5QgVTukeOlF41Hc8nTPEaWt7Ag0WzICM0WQ== X-Google-Smtp-Source: ABdhPJxrQ91FcoG1j8MqOj19A8jz0Mbb51yvmE4ezgOpcY+fkN/eVADQarawxS3wzP2LfC8q5vYwAWJL1ZqFFqpb/1o= X-Received: by 2002:a05:651c:1124:: with SMTP id e4mr253677ljo.261.1632839421344; Tue, 28 Sep 2021 07:30:21 -0700 (PDT) MIME-Version: 1.0 References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-7-caihuoqing@baidu.com> In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 16:30:09 +0200 Message-ID: Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_073023_153622_AC6BB58E X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > BTW, change the return value from 'ENXIO' to 'ENODEV', > perfer ENODEV which means no such device. > > Signed-off-by: Cai Huoqing > --- > v2->v3: Update the changelog. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel