From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline Date: Mon, 17 Jun 2013 08:27:30 +0200 Message-ID: References: <2942784.trumtc2GjZ@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-oa0-f52.google.com ([209.85.219.52]:49204 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750Ab3FQG1a (ORCPT ); Mon, 17 Jun 2013 02:27:30 -0400 Received: by mail-oa0-f52.google.com with SMTP id g12so2899207oah.39 for ; Sun, 16 Jun 2013 23:27:30 -0700 (PDT) In-Reply-To: <2942784.trumtc2GjZ@wuerfel> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Arnd Bergmann Cc: Linus Walleij , linux-gpio@vger.kernel.org, Linux-OMAP , "linux-arm-kernel@lists.infradead.org" , Tony Lindgren , Jon Hunter , Santosh Shilimkar , Kevin Hilman On Fri, May 31, 2013 at 5:59 PM, Arnd Bergmann wrote: > The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised" > has caused a new warning for omap1_defconfig: > > drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function] > static void omap_gpio_init_context(struct gpio_bank *p) {} > ^ > > The solution is to mark the stub function as 'static inline' so > it gets left out of the build when unused. > > Signed-off-by: Arnd Bergmann Patch applied with Tony's and Santosh's ACKs. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Mon, 17 Jun 2013 08:27:30 +0200 Subject: [PATCH] gpio/omap: omap_gpio_init_context stub must be inline In-Reply-To: <2942784.trumtc2GjZ@wuerfel> References: <2942784.trumtc2GjZ@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 31, 2013 at 5:59 PM, Arnd Bergmann wrote: > The bug fix 352a2d5bf "gpio/omap: ensure gpio context is initialised" > has caused a new warning for omap1_defconfig: > > drivers/gpio/gpio-omap.c:1465:13: warning: 'omap_gpio_init_context' defined but not used [-Wunused-function] > static void omap_gpio_init_context(struct gpio_bank *p) {} > ^ > > The solution is to mark the stub function as 'static inline' so > it gets left out of the build when unused. > > Signed-off-by: Arnd Bergmann Patch applied with Tony's and Santosh's ACKs. Yours, Linus Walleij