From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] of/irq: Export of_irq_count() Date: Wed, 23 Dec 2015 00:55:53 +0100 Message-ID: References: <1450786942-13292-1-git-send-email-broonie@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Mark Brown , Frank Rowand , Stephen Boyd , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Dec 22, 2015 at 6:12 PM, Rob Herring wrote: > On Tue, Dec 22, 2015 at 6:22 AM, Mark Brown wrote: >> Some of the Qualcomm pinctrl drivers have started trying to use >> of_irq_count() in modular code but this fails to build as the symbol is >> not exported. Since there doesn't seem to be any reason not to export >> the symbol make it available to modules. > > The reason it has not been exported is because we want to stick with > the platform_* APIs for IRQs. There's not really an equivalent > function though. Perhaps we should make one? Usually it is just used > for allocating some driver data. If that is the case, is it really > enough data to not just allocate the max? Hm that seems like a bigger solution. Should we try to mitigate the issue by making the Qualcomm drivers builtin for the time being? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html