Re: [PATCH] iio: adf4350: Convert to use GPIO descriptor

From: Linus Walleij <linus.walleij@linaro.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: adf4350: Convert to use GPIO descriptor
Date: Mon, 2 Dec 2019 10:16:42 +0100	[thread overview]
Message-ID: <CACRpkdYUz0yrJ_cB9rq1u+KUFUw_DOCwzAec340BgaHV_cdcuA@mail.gmail.com> (raw)
In-Reply-To: <a1be250ce3e9a89e5a352390e16504ce8e017dbe.camel@analog.com>

On Mon, Dec 2, 2019 at 9:50 AM Ardelean, Alexandru
<alexandru.Ardelean@analog.com> wrote:

> > +     st->lock_detect_gpiod = devm_gpiod_get_optional(&spi->dev, NULL,
>
> Would it make sense to name the GPIO here?
> Maybe name it "lock-detect"?
>
> I do realize that this goes into the realm of changing some default
> behavior.
> And I am not sure how acceptable this is [generally].

You can't name it in the devm_gpiod_get_optional() call as this
indicates the name the GPIO lines have in the device tree.

What you can do is add a call to
gpiod_set_consumer_name(gpiod, "name");
to explicitly name the line.

This will only affect the name assigned to the line
in debugfs and in the userspace tools like "lsgpio".

Yours,
Linus Walleij