From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4611FC43603 for ; Mon, 16 Dec 2019 10:20:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15BEB20684 for ; Mon, 16 Dec 2019 10:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tHE/FqAn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727443AbfLPKUp (ORCPT ); Mon, 16 Dec 2019 05:20:45 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:41349 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727225AbfLPKUp (ORCPT ); Mon, 16 Dec 2019 05:20:45 -0500 Received: by mail-ua1-f68.google.com with SMTP id f7so1869828uaa.8 for ; Mon, 16 Dec 2019 02:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MkbL1d/SzqUihRGV9EGxMppkoVLFMzfPIRPZl16fK20=; b=tHE/FqAndfXj+pF3rpKcyZB3P2mC/ivGu+RuNn7h6U8fH6CwMbbwsVUcsp/rTQHd7w SnHZW/qVxTnvRge2orkhtQ9Xsf73XYevjXfqvfdKDkG6TobwnqhLBRLLAqcTfYe0WEYP TemamdhsBonUMSlcJPhpPbtBP1PxXnbcO6gUB921WNamWplR0wZicOySkVBqhLyXZ1Yo 5/Wicv3VUbruyGwEo/ySRP7hgpg/Rx9tzYgwHjF/x5Tt0Rb19SDBDqLbx7dadCPp/2w3 55sfvzdVwUdtHbd82oEpCim18++9O0mztUBgkt/XgEzxg9/Ghg+3d2LhqjyhP+4MBMHG ziSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MkbL1d/SzqUihRGV9EGxMppkoVLFMzfPIRPZl16fK20=; b=q9DZ4hHUn4jmoCxhobpsRdpoC6+nL2CddBC2SdBGEJQhpIOSi+LutLsQ0fRFfk7fQw 93pzRf8Rzs6M5j95890AZb9EKrGvX7Ofs6qUwYyuDVxCGC6aRW77sIOqXqLgGa6cuC8u 3bd4k3mMaRHyeAdySk1bXbjPIK4PbIBiRQ7VVHbArWP12he+w83tRim/lITDSSAvgM2U 9Lw+B5hCJq+/d6NK6YP0A6fCd2Iw+SQsqb2QROj3MnIsY+05DO/iBJBk/znEyYgogu1l BEBWndyGBnZJOW6g/c1bc2ciUmeZKfZ23QpKFgKtvFYCV2HC3tXv/L+ylsgsE+ZfyTqW dJww== X-Gm-Message-State: APjAAAXhYxi7uJ9qCDp6VhP+IDXlAKXsuGwZhhm4GHm+OSZvOHwFtYXw ImAUM4DE5DjR6S4R5UoI+EnHo5CPg1ltDco7ZQeY3w== X-Google-Smtp-Source: APXvYqytRcaEhtLm4UxsiP0XcQ5WA/lllFA43ewjb5KkmW6LveWszgSmmf6NQVq50n36TRexdsgdRA2S2NxjbZ7+23A= X-Received: by 2002:ab0:7219:: with SMTP id u25mr23212467uao.10.1576491644556; Mon, 16 Dec 2019 02:20:44 -0800 (PST) MIME-Version: 1.0 References: <20191215011045.15453-1-navid.emamdoost@gmail.com> In-Reply-To: <20191215011045.15453-1-navid.emamdoost@gmail.com> From: Linus Walleij Date: Mon, 16 Dec 2019 11:20:33 +0100 Message-ID: Subject: Re: [PATCH] net: gemini: Fix memory leak in gmac_setup_txqs To: Navid Emamdoost Cc: Hans Ulli Kroll , "David S. Miller" , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux ARM , netdev , "linux-kernel@vger.kernel.org" , emamd001@umn.edu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 15, 2019 at 2:11 AM Navid Emamdoost wrote: > In the implementation of gmac_setup_txqs() the allocated desc_ring is > leaked if TX queue base is not aligned. Release it via > dma_free_coherent. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") > Signed-off-by: Navid Emamdoost Looks correct to me, Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8118C2D0C0 for ; Mon, 16 Dec 2019 10:20:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A79D20684 for ; Mon, 16 Dec 2019 10:20:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ykt3R6sT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tHE/FqAn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A79D20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gofTArvhc/ycqmgns2Lj/YumNmGY3g9NJUgycvvSMUA=; b=Ykt3R6sTsr/yYD vl5N0Bwb1f53D9s/qnYe/LRX2h/aRBjDVew6/50RogztzIFuOn8tiFWFG8rxtqpwKjbl7HGnM+Wpb Ru1Zgg718+Y8YdJFFg4wpO9oleoPKl5rskRBB+T0PL06sgW/f5oytiZmXAk2zz2O7byBfu6tLw745 laRvLS4oqsxu2jVpqIxC2HcRxi79feJKK5Tr7lXMgivIwk7MPhP74dbrNV02zxkZ2cFpmuZvhbFLw xj6TUYDqZ3gNPmLhjKMO4qrDwIIvgA3ncj4CQfmj5Ivp3zaZHfjN71E0kygxst7fza/woNEmTGFl+ Tk2SyY6NVLKUZ3hoT8YA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ignUe-0002pq-8c; Mon, 16 Dec 2019 10:20:48 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ignUb-0002pG-KY for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 10:20:46 +0000 Received: by mail-ua1-x942.google.com with SMTP id o42so1868031uad.10 for ; Mon, 16 Dec 2019 02:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MkbL1d/SzqUihRGV9EGxMppkoVLFMzfPIRPZl16fK20=; b=tHE/FqAndfXj+pF3rpKcyZB3P2mC/ivGu+RuNn7h6U8fH6CwMbbwsVUcsp/rTQHd7w SnHZW/qVxTnvRge2orkhtQ9Xsf73XYevjXfqvfdKDkG6TobwnqhLBRLLAqcTfYe0WEYP TemamdhsBonUMSlcJPhpPbtBP1PxXnbcO6gUB921WNamWplR0wZicOySkVBqhLyXZ1Yo 5/Wicv3VUbruyGwEo/ySRP7hgpg/Rx9tzYgwHjF/x5Tt0Rb19SDBDqLbx7dadCPp/2w3 55sfvzdVwUdtHbd82oEpCim18++9O0mztUBgkt/XgEzxg9/Ghg+3d2LhqjyhP+4MBMHG ziSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MkbL1d/SzqUihRGV9EGxMppkoVLFMzfPIRPZl16fK20=; b=OUtjcZP5zzNA6sRXKuaivEY2eIvsRgeNy8ILlvD8JlV2PZq80H9H1t6lYiJ4oxevxH vBHRd2SQri0GD2nuzh+4ay3X6l/zRhx6mVqaRIZqKjpCaYzU+H4/rX6q/x2QD/+tgfHX xSCPvgchjt1Y61RkTczMyZRF1+RskQJSB6Qo531x3HdHdOP23fIJyvxoSB9lcGm6gvH8 FB5yoGPL+xr27qf/yvggXyXWa1gljRYb07qSgvhZ2Qs9AcBkzBG8mtMuko1eq56uOD5t 5Km8OO+bFZICdC5oCbTq2iXQJC1+xht5n9kqAdIuNeLE3Om9huvN1OokHP/p/1IvatvY h3aw== X-Gm-Message-State: APjAAAXIJjh2U2SsYozRUyfxlJdWQaE5nBjl6ZnBN7e14oE/DzF06Z7C o7gL7aDI3pX6se5kixGgs8vi/cdw5WA3EgXvuLTvrQ== X-Google-Smtp-Source: APXvYqytRcaEhtLm4UxsiP0XcQ5WA/lllFA43ewjb5KkmW6LveWszgSmmf6NQVq50n36TRexdsgdRA2S2NxjbZ7+23A= X-Received: by 2002:ab0:7219:: with SMTP id u25mr23212467uao.10.1576491644556; Mon, 16 Dec 2019 02:20:44 -0800 (PST) MIME-Version: 1.0 References: <20191215011045.15453-1-navid.emamdoost@gmail.com> In-Reply-To: <20191215011045.15453-1-navid.emamdoost@gmail.com> From: Linus Walleij Date: Mon, 16 Dec 2019 11:20:33 +0100 Message-ID: Subject: Re: [PATCH] net: gemini: Fix memory leak in gmac_setup_txqs To: Navid Emamdoost X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_022045_683337_0DEC0C2B X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , Hans Ulli Kroll , "linux-kernel@vger.kernel.org" , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , emamd001@umn.edu, "David S. Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 15, 2019 at 2:11 AM Navid Emamdoost wrote: > In the implementation of gmac_setup_txqs() the allocated desc_ring is > leaked if TX queue base is not aligned. Release it via > dma_free_coherent. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") > Signed-off-by: Navid Emamdoost Looks correct to me, Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel