From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbcHHVfz (ORCPT ); Mon, 8 Aug 2016 17:35:55 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33014 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbcHHVfx (ORCPT ); Mon, 8 Aug 2016 17:35:53 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Linus Walleij Date: Mon, 8 Aug 2016 23:35:52 +0200 Message-ID: Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons To: Thomas Gleixner Cc: John Stultz , Jon Hunter , Marc Zyngier , lkml , Bjorn Andersson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 30, 2016 at 10:07 AM, Thomas Gleixner wrote: > On Fri, 29 Jul 2016, John Stultz wrote: >> Hey Jon, >> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >> noticed the power/volume buttons stopped working. >> >> I did a manual rebased bisection and chased it down to your commit >> 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ"). >> >> Reverting that patch makes things work again, so I wanted to see if >> there was any debugging info I could provide to try to help narrow >> down the problem here. (Sorry, I'd tinker myself with it some and try >> to debug the issue, but after burning my friday night on this, I'm >> eager to get away from the keyboard for the weekend). > > dmesg should contain debug output which yells about non matching types. Can > you provide that? I had that problem *too* on the Qualcomm platforms (APQ8060, MSM8660 and the APQ8064 variants, but fixed it up with these two patches: http://marc.info/?l=linux-arm-kernel&m=147038646226142&w=2 In addition to that there is some other problem, discussed in this thread... I understand that less. Yours, Linus Walleij