From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpio: mxc: Shift generic request/free after gpiochip registration Date: Tue, 25 Oct 2016 14:11:12 +0200 Message-ID: References: <580EE62D.4090704@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <580EE62D.4090704@mentor.com> Sender: linux-kernel-owner@vger.kernel.org To: Deepak Das Cc: Shawn Guo , "linux-gpio@vger.kernel.org" , Vladimir Zapolskiy , Fabio Estevam , Sascha Hauer , Philipp Zabel , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Tue, Oct 25, 2016 at 6:57 AM, Deepak Das wrote: > generic gpio request/free should be added after gpiocip registration > to validate mapping of gpiochip with pinctrl subsystem. > > gpiochip->pin_ranges list contains the information used by pinctrl > subsystem to configure corresponding pins for gpio usage. > This list will be empty if gpiochip fails to map with > pinctrl subsystem for any reason. > For Ex.:- > generic gpio request/free should not be used if IOMUX pin controller > device node is disabled in device tree. > > This commit checks above list and skips adding generic gpio request/free > if list is found empty. > > Signed-off-by: Deepak Das > Signed-off-by: Vladimir Zapolskiy Third time I find this in my inbox and it still doesn't apply. Yours, Linus Walleij