From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CA6C4CEC6 for ; Thu, 12 Sep 2019 14:31:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4889920663 for ; Thu, 12 Sep 2019 14:31:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ncaEmNwJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732592AbfILObH (ORCPT ); Thu, 12 Sep 2019 10:31:07 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:46275 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732564AbfILObH (ORCPT ); Thu, 12 Sep 2019 10:31:07 -0400 Received: by mail-lf1-f67.google.com with SMTP id t8so19507220lfc.13 for ; Thu, 12 Sep 2019 07:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GGFnevdB6/W3Bn08vXZUmYabxaeEv2/WytcSluM4/qA=; b=ncaEmNwJoGN+h9j/w2zBIKBQZsgZQT2H68ZJRafK8UQg1HqUSTqLYVkpITITzG6hYp 8kNSTxCfdTHB8SlHaOYh+ZtMRu8pMEDN3T6x22PO3AiC3vRwRw+JrMqlP/Jk74y6t3mX ywWS24EkuibJ2tShu+SqULfWeNSIMKPpr5wJREZX7Tc1cL+bYwQCkSoznpU7aTReSWjF jyH9hbh2kpExgjM79iT+iG6bEqijxuIXLbmtAyZikQrSeR0MiiA079g1SNBe9hFsvZwK C1lQqzudFaoE/DZcKU/0HVRJdxc8hXy5dcBdFy2kIB3D3tvU/DZJjJo/WTKqNQBI+1qo 0Y+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GGFnevdB6/W3Bn08vXZUmYabxaeEv2/WytcSluM4/qA=; b=regXgJHekaTSIc8G7f2N0Tn3cCXeUahvrZQl8z/xKmZtogZxwkb98S6x8FIe5JNU6F M4pvS9acFD+yIw/TFPxxFDyajd7ZLmfqZbJPXRokzCKqii4Mb15DxoxqRdTjjRxA86Pl acYUS25e4g00FaKktQlDgm+NJnKyDU3iqmpJiGRWQopaJ/uj+eDK0c2F8SmdqBRT3mns nWfrqISfYa1/EK5zzPocKBdt39AoMT9xNvYf3SwDPYvLB4wHBDpLRGEAE7jHooCxsNZB 8KzMZ+yQN4gyJcfSjjVSrl1/MTMzzzl4YJu/x/mEZDkr8Tchuf1+eQT7w01X0ZQqLQUX Scbw== X-Gm-Message-State: APjAAAV39ezbH3+QOLXZqUmIZ6Ujpf9NwjNo7eFCUrbwW/kej7u8I1CL /ok1IGO7tK7gs8WLiShdcVkR2gSrtt3gTBG07ogdhw== X-Google-Smtp-Source: APXvYqxO9Z8c7OrTKavPMGL2/MV6p57Y1bzJgt/HX0TZHAPCfiKQUMd+9yPlAdhhtCF+f1UbeWI7+mA8oZoL7ARgpjY= X-Received: by 2002:ac2:530e:: with SMTP id c14mr1286884lfh.165.1568298665420; Thu, 12 Sep 2019 07:31:05 -0700 (PDT) MIME-Version: 1.0 References: <20190912135806.GA2680@smile.fi.intel.com> In-Reply-To: <20190912135806.GA2680@smile.fi.intel.com> From: Linus Walleij Date: Thu, 12 Sep 2019 15:30:52 +0100 Message-ID: Subject: Re: [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver To: Andriy Shevchenko Cc: Rahul Tanwar , Mika Westerberg , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, Mathias Nyman , Heikki Krogerus Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Sep 12, 2019 at 2:58 PM Andriy Shevchenko wrote: > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > > Hi Rahul, > > > > thanks for your patches! > > > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > > wrote: > > > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > > Patch 1 adds pinmux & GPIO controller driver. > > > Patch 2 adds the dt bindings document & include file. > > > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > > > OK nice, I think you need to include Mika Westerberg on this review > > as well, because I think he likes to stay on top of all things intel > > in pin control. (Also included two other Intel folks in Finland who usually > > take an interest in these things.) > > Linus, > nevertheless I guess you may give your comments WRT device tree use > (bindings, helpers, etc) along with some basics, (like devm_*() > [ab]use I just noticed). I plan to look at the patches per se but right now I don't have much time because soon there is merge window and kernel summit, the patches just need to age a little bit like a good wine ;) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v1 0/2] pinctrl: Add new pinctrl/GPIO driver Date: Thu, 12 Sep 2019 15:30:52 +0100 Message-ID: References: <20190912135806.GA2680@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190912135806.GA2680@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andriy Shevchenko Cc: Rahul Tanwar , Mika Westerberg , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, Mathias Nyman , Heikki Krogerus List-Id: devicetree@vger.kernel.org On Thu, Sep 12, 2019 at 2:58 PM Andriy Shevchenko wrote: > On Thu, Sep 12, 2019 at 11:11:32AM +0100, Linus Walleij wrote: > > Hi Rahul, > > > > thanks for your patches! > > > > On Thu, Sep 12, 2019 at 8:59 AM Rahul Tanwar > > wrote: > > > > > This series is to add pinctrl & GPIO controller driver for a new SoC. > > > Patch 1 adds pinmux & GPIO controller driver. > > > Patch 2 adds the dt bindings document & include file. > > > > > > Patches are against Linux 5.3-rc5 at below Git tree: > > > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > > > > OK nice, I think you need to include Mika Westerberg on this review > > as well, because I think he likes to stay on top of all things intel > > in pin control. (Also included two other Intel folks in Finland who usually > > take an interest in these things.) > > Linus, > nevertheless I guess you may give your comments WRT device tree use > (bindings, helpers, etc) along with some basics, (like devm_*() > [ab]use I just noticed). I plan to look at the patches per se but right now I don't have much time because soon there is merge window and kernel summit, the patches just need to age a little bit like a good wine ;) Yours, Linus Walleij