From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/2] pinctrl: mediatek: add input-enable and direction setting for eint resources Date: Fri, 19 Feb 2016 00:31:03 +0100 Message-ID: References: <1455650194-9813-1-git-send-email-biao.huang@mediatek.com> <1455650194-9813-3-git-send-email-biao.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ob0-f177.google.com ([209.85.214.177]:34546 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946440AbcBRXbE (ORCPT ); Thu, 18 Feb 2016 18:31:04 -0500 Received: by mail-ob0-f177.google.com with SMTP id kf7so8816035obb.1 for ; Thu, 18 Feb 2016 15:31:03 -0800 (PST) In-Reply-To: <1455650194-9813-3-git-send-email-biao.huang@mediatek.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Biao Huang Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-gpio@vger.kernel.org" , srv_heupstream@mediatek.com, Yingjoe Chen , Hongzhou Yang , Eddie Huang On Tue, Feb 16, 2016 at 8:16 PM, Biao Huang wrote: > To use pin as eint, user should make sure that: > 1. pin is set to right mode, this is done in .irq_request_resources > implementation already. > 2. direction of the pin is input, which should call GPIO API to set > pin to input gpio. > We add what step 2 do to .irq_request_resources so that user doesn't > need call GPIO API any more when pin for eint usage. > > Signed-off-by: Biao Huang Patch applied. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948724AbcBRXge (ORCPT ); Thu, 18 Feb 2016 18:36:34 -0500 Received: from mail-ob0-f172.google.com ([209.85.214.172]:36574 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1947226AbcBRXgd (ORCPT ); Thu, 18 Feb 2016 18:36:33 -0500 MIME-Version: 1.0 In-Reply-To: <1455650194-9813-3-git-send-email-biao.huang@mediatek.com> References: <1455650194-9813-1-git-send-email-biao.huang@mediatek.com> <1455650194-9813-3-git-send-email-biao.huang@mediatek.com> Date: Fri, 19 Feb 2016 00:31:03 +0100 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: mediatek: add input-enable and direction setting for eint resources From: Linus Walleij To: Biao Huang Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "moderated list:ARM/Mediatek SoC support" , "linux-gpio@vger.kernel.org" , srv_heupstream@mediatek.com, Yingjoe Chen , Hongzhou Yang , Eddie Huang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 8:16 PM, Biao Huang wrote: > To use pin as eint, user should make sure that: > 1. pin is set to right mode, this is done in .irq_request_resources > implementation already. > 2. direction of the pin is input, which should call GPIO API to set > pin to input gpio. > We add what step 2 do to .irq_request_resources so that user doesn't > need call GPIO API any more when pin for eint usage. > > Signed-off-by: Biao Huang Patch applied. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Fri, 19 Feb 2016 00:31:03 +0100 Subject: [PATCH 2/2] pinctrl: mediatek: add input-enable and direction setting for eint resources In-Reply-To: <1455650194-9813-3-git-send-email-biao.huang@mediatek.com> References: <1455650194-9813-1-git-send-email-biao.huang@mediatek.com> <1455650194-9813-3-git-send-email-biao.huang@mediatek.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 16, 2016 at 8:16 PM, Biao Huang wrote: > To use pin as eint, user should make sure that: > 1. pin is set to right mode, this is done in .irq_request_resources > implementation already. > 2. direction of the pin is input, which should call GPIO API to set > pin to input gpio. > We add what step 2 do to .irq_request_resources so that user doesn't > need call GPIO API any more when pin for eint usage. > > Signed-off-by: Biao Huang Patch applied. Yours, Linus Walleij