From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464EAC433F5 for ; Tue, 9 Nov 2021 04:52:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2395D610E9 for ; Tue, 9 Nov 2021 04:52:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242904AbhKIEzO (ORCPT ); Mon, 8 Nov 2021 23:55:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242873AbhKIEzK (ORCPT ); Mon, 8 Nov 2021 23:55:10 -0500 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67209C061766 for ; Mon, 8 Nov 2021 20:52:25 -0800 (PST) Received: by mail-oi1-x22b.google.com with SMTP id m6so5687702oim.2 for ; Mon, 08 Nov 2021 20:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIi/8rMsntaI+OsdfCjYQbsx+2Ak2wriMzRfxygR1FA=; b=YQj7Lj4xuXVPjaiPI91CCtrxG/QPQj2KuOiKL+6EOLjbFP+68Vxjn6VP2zgEb2WPng gttNnAewxd5Q/UnXavsCgAkGKGIEbb33rE4NhkJJwqkxwFRhuPZCRsRcTBkyg1ci6l+p 44XDT98JjjfF2Fxepkrnx37rkhjKXElHvjzb/Gqhkszf6RfXX4y/0ob89EC2VrnNdSc/ 1nm23L7eBmUcFVVMMs/v7wWh4CWub/fbwqoWPo2N+7amnOteVZmuDAnDE9qWXU/pgWKI vyF86ekPDv40KLWl074BU5pae8QhuZ+dmVAIJewsWnmy1sT0cZ0QQfCqG1tw9GMURM91 aDzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIi/8rMsntaI+OsdfCjYQbsx+2Ak2wriMzRfxygR1FA=; b=qeBTitX1/vR+YojYGlTqdWIjLh018o6G3Z8tRltA2rArtqyxpTfaIaFAS8ZCLhkNKC 8TlkhOn4VtvT7Kd/CW4NcapfNSOa9YwMtspIMt1WotTyJlt9+Q9hRvCKs9NerJItvLwh wBmpCNJ61ToijWkcFViB5IEG0vA76efI/ojaSyf5N4KmF0SIiqYZYknR4s38nq9n2P2j LaPgWtaykGDvmsloKYuXutgVj2rIOugcdq9Yn99XvrF4x48Qiwxc3uNQWtmWmex05ZU8 AGIdwi23pdJWrb4ObIxUTvRbU/JvJ5E0mjqOFx5zKlMLB8sZAC5U5h6wUJBZckQjywGi v6QA== X-Gm-Message-State: AOAM5321gTzs/9ydFkmKhxnhs5TNomyucQUXvhrd7BL32Ngj8f79ZLaA WwcLZwi20PnQHpXmeptoYsWNz7YZPMVmp9y3zxgsSw== X-Google-Smtp-Source: ABdhPJw/PXJeyQlLBQdKl4Na77Zir0MpynV5/VfDEG0JbF81ciPHPaSAILPbfcUgMwRqhqiiszKinPesveK3xnr+A3A= X-Received: by 2002:aca:120f:: with SMTP id 15mr3151848ois.132.1636433544821; Mon, 08 Nov 2021 20:52:24 -0800 (PST) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-14-lukas.bulwahn@gmail.com> In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com> From: Linus Walleij Date: Tue, 9 Nov 2021 05:52:13 +0100 Message-ID: Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment To: Lukas Bulwahn Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn wrote: > Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow > memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the > good practice to annotate the endif's with a comment to indicate the > corresponding ifdef condition. > > One comment annotation refers to CONFIG_LPAE, whereas the config is > actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably > tolerable for all human readers. > > However, the script ./scripts/checkkconfigsymbols.py, which checks the > kernel tree for references to non-existing Kconfig symbols, identifies and > reports that the reference to CONFIG_LPAE is invalid. > > The script ./scripts/checkkconfigsymbols.py has been quite useful to > identify a number of bugs with Kconfig symbols and deserves to be executed > and checked regularly. > > So, repair the comment to reduce the reports from this script and simplify > to use this script, as new issues are easier to spot when the list of > reports is shorter. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Linus Walleij Please put this patch into Russell's patch tracker! Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70ABC433F5 for ; Tue, 9 Nov 2021 04:53:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA04361179 for ; Tue, 9 Nov 2021 04:53:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA04361179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HpFwj5F2Nz2ybK for ; Tue, 9 Nov 2021 15:53:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YQj7Lj4x; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::231; helo=mail-oi1-x231.google.com; envelope-from=linus.walleij@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YQj7Lj4x; dkim-atps=neutral Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HpFvy3zS4z2yZC for ; Tue, 9 Nov 2021 15:52:28 +1100 (AEDT) Received: by mail-oi1-x231.google.com with SMTP id u2so31555033oiu.12 for ; Mon, 08 Nov 2021 20:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIi/8rMsntaI+OsdfCjYQbsx+2Ak2wriMzRfxygR1FA=; b=YQj7Lj4xuXVPjaiPI91CCtrxG/QPQj2KuOiKL+6EOLjbFP+68Vxjn6VP2zgEb2WPng gttNnAewxd5Q/UnXavsCgAkGKGIEbb33rE4NhkJJwqkxwFRhuPZCRsRcTBkyg1ci6l+p 44XDT98JjjfF2Fxepkrnx37rkhjKXElHvjzb/Gqhkszf6RfXX4y/0ob89EC2VrnNdSc/ 1nm23L7eBmUcFVVMMs/v7wWh4CWub/fbwqoWPo2N+7amnOteVZmuDAnDE9qWXU/pgWKI vyF86ekPDv40KLWl074BU5pae8QhuZ+dmVAIJewsWnmy1sT0cZ0QQfCqG1tw9GMURM91 aDzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIi/8rMsntaI+OsdfCjYQbsx+2Ak2wriMzRfxygR1FA=; b=IFw/ta3StjrHh8EpWNdyqDKobEI0Jbndkmjdha+OjPbp8jRRh6rMK5iK2DKYnPEKD+ 569AYUpKgS8ux4f9IA1afAFXzW2A9AIldhcRxPdfpe4BlXetrsM77Px0RhPpdqD3yUWn kpOj/D0gmqGPo4T9f0j/jvuYbLPIuhtucZosQUP+Bmws1DxwTmvgNIXUEbFDAjKwLKEK 5j5cbNqZnR358ZKq/HWIOtAv9pqt8ESAbQtYCBJIhdAC47afBka3jjGcBCMYx+K/Jq4b T1yxqYcV9Ph15Lvzw6fOexxaPHiJybxhwxOKjzWXNiwfVSUmkxGOEik/YLaoVTnhbG7L rJAA== X-Gm-Message-State: AOAM533g6vBH5gHomzSVhnYBOOLCLfk5dcO17BVPot0ZrSBFzK9/rBxl l26519A0hB8UfGfUclIuXogT9/kQ2r+oVVKObnTuQw== X-Google-Smtp-Source: ABdhPJw/PXJeyQlLBQdKl4Na77Zir0MpynV5/VfDEG0JbF81ciPHPaSAILPbfcUgMwRqhqiiszKinPesveK3xnr+A3A= X-Received: by 2002:aca:120f:: with SMTP id 15mr3151848ois.132.1636433544821; Mon, 08 Nov 2021 20:52:24 -0800 (PST) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-14-lukas.bulwahn@gmail.com> In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com> From: Linus Walleij Date: Tue, 9 Nov 2021 05:52:13 +0100 Message-ID: Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment To: Lukas Bulwahn Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomer Maimon , kernel-janitors@vger.kernel.org, Tali Perry , Fabio Estevam , Benjamin Fair , openbmc@lists.ozlabs.org, Russell King , Arnd Bergmann , Sekhar Nori , Sascha Hauer , Krzysztof Halasa , linux-arm-kernel@lists.infradead.org, Avi Fishman , Patrick Venture , Linus Walleij , linux-kernel@vger.kernel.org, Dinh Nguyen , Pengutronix Kernel Team , Imre Kaloz , Shawn Guo , Bartosz Golaszewski Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn wrote: > Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow > memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the > good practice to annotate the endif's with a comment to indicate the > corresponding ifdef condition. > > One comment annotation refers to CONFIG_LPAE, whereas the config is > actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably > tolerable for all human readers. > > However, the script ./scripts/checkkconfigsymbols.py, which checks the > kernel tree for references to non-existing Kconfig symbols, identifies and > reports that the reference to CONFIG_LPAE is invalid. > > The script ./scripts/checkkconfigsymbols.py has been quite useful to > identify a number of bugs with Kconfig symbols and deserves to be executed > and checked regularly. > > So, repair the comment to reduce the reports from this script and simplify > to use this script, as new issues are easier to spot when the list of > reports is shorter. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Linus Walleij Please put this patch into Russell's patch tracker! Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4904C433F5 for ; Tue, 9 Nov 2021 04:53:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3A986115A for ; Tue, 9 Nov 2021 04:53:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A3A986115A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ivo6Z7pfbv0jYpuh1SRk1MpmAuLG+E9k81X4mOBbv4U=; b=Lb3rqLkPkN5Psm 3lOGiovTgnLfIMj/cDKiZGg3nWXNQgSKS86EkTCdRl51RMWBEVmt6cS3jGif78Jut/LuR6V9K405w MfVW9XCjDYMQ27EBwvoYpCmQWohSmEdpu+sCoecYf8S29/I7ePwb4ySfgze2hJN4MljntlOIJMFbv b9PRbatb8AtxHoFNJpDFwOclPwQIQIklRChL52bdDioK/zPA54Ghv6XQIyIXEqVA4ritcV/NTtp4b 4Kr0o+QQj0rUXr/LatALAhVyxIGQ69TYPl2QEwF5pQvRg6oWKOilVenkxOylSJoO4U9cHnFHW+106 bibDp/4KOrFvqwWC7vAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkJ7W-000g7N-RE; Tue, 09 Nov 2021 04:52:31 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkJ7R-000g6M-TE for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 04:52:28 +0000 Received: by mail-oi1-x22d.google.com with SMTP id u2so31555027oiu.12 for ; Mon, 08 Nov 2021 20:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIi/8rMsntaI+OsdfCjYQbsx+2Ak2wriMzRfxygR1FA=; b=YQj7Lj4xuXVPjaiPI91CCtrxG/QPQj2KuOiKL+6EOLjbFP+68Vxjn6VP2zgEb2WPng gttNnAewxd5Q/UnXavsCgAkGKGIEbb33rE4NhkJJwqkxwFRhuPZCRsRcTBkyg1ci6l+p 44XDT98JjjfF2Fxepkrnx37rkhjKXElHvjzb/Gqhkszf6RfXX4y/0ob89EC2VrnNdSc/ 1nm23L7eBmUcFVVMMs/v7wWh4CWub/fbwqoWPo2N+7amnOteVZmuDAnDE9qWXU/pgWKI vyF86ekPDv40KLWl074BU5pae8QhuZ+dmVAIJewsWnmy1sT0cZ0QQfCqG1tw9GMURM91 aDzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIi/8rMsntaI+OsdfCjYQbsx+2Ak2wriMzRfxygR1FA=; b=G0Xjg8D9qKZtC+X1GxpSCpzwg30BLgeBmPfjy0G1c2Kn79xb3lFOLyQ5QIf86HUxbZ pYJL4zBD2pggRFJLSTBmHyl3CiGy5JqQFWIT8a9U3XYwdHVKkxdVrdYwmsiUX3dcYByN iTEuzjMJmmNEafI5+2rdmn5SSYHSu66on33l7S8Xn2jAACMGJekzfExIFHhdcC+/nXb+ 748SbN3RgLOYriyajVd7SSNzN/A4d7UaNp6kgvri65vKK4pu4voVe8n/qJOMarcN5qX4 KeCxKdQgjP+SwCq5RDgDNt1xyjJZvLtTo68VFYy7rcOFV4w/MmxNiG5CfpArUN6Qedls oJLQ== X-Gm-Message-State: AOAM531xqxnXJZYj6DjDftaaFc+uY5TU5d+86e1pHlW08hiYLuoaNIfO h8JTOQLQtf8odwDKVUCoWehsvQV08cqAy71VzUilZQ== X-Google-Smtp-Source: ABdhPJw/PXJeyQlLBQdKl4Na77Zir0MpynV5/VfDEG0JbF81ciPHPaSAILPbfcUgMwRqhqiiszKinPesveK3xnr+A3A= X-Received: by 2002:aca:120f:: with SMTP id 15mr3151848ois.132.1636433544821; Mon, 08 Nov 2021 20:52:24 -0800 (PST) MIME-Version: 1.0 References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-14-lukas.bulwahn@gmail.com> In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com> From: Linus Walleij Date: Tue, 9 Nov 2021 05:52:13 +0100 Message-ID: Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment To: Lukas Bulwahn Cc: Russell King , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_205225_966380_8C785F24 X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn wrote: > Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow > memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the > good practice to annotate the endif's with a comment to indicate the > corresponding ifdef condition. > > One comment annotation refers to CONFIG_LPAE, whereas the config is > actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably > tolerable for all human readers. > > However, the script ./scripts/checkkconfigsymbols.py, which checks the > kernel tree for references to non-existing Kconfig symbols, identifies and > reports that the reference to CONFIG_LPAE is invalid. > > The script ./scripts/checkkconfigsymbols.py has been quite useful to > identify a number of bugs with Kconfig symbols and deserves to be executed > and checked regularly. > > So, repair the comment to reduce the reports from this script and simplify > to use this script, as new issues are easier to spot when the list of > reports is shorter. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Linus Walleij Please put this patch into Russell's patch tracker! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel