From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A39C433FE for ; Wed, 20 Apr 2022 23:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383199AbiDTX1x (ORCPT ); Wed, 20 Apr 2022 19:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383193AbiDTX1u (ORCPT ); Wed, 20 Apr 2022 19:27:50 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45AA313E22 for ; Wed, 20 Apr 2022 16:25:03 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2eba37104a2so35421277b3.0 for ; Wed, 20 Apr 2022 16:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=faX+8xEq5cxeln2IAgBzOZYC6emkLLqmLHlpGzsrZsI=; b=IdysWrk64gPASP4iboMXdeQr8OBqMtOScTiocxTj/PrXpZ3MpyJ7PLa30ylu64mytC dNZJ48LUjpecPRUYztsGI+HRaMLrBaDd/kcZaLV36ygFMFvmDY057Y+HEiWLnX8GNMwh zze4Y1X6WoKVDIaAGotw8iPC/K8l1onAsVljpkbYO8mFC4YRPbjpiKuiKdaF631UerU7 ti+4EtfpHTfW3DMrUIqjmE+KiLWxhORMBfjPtP60A/UoWuR7wTx2P7q+WOBQloAXxCtG qRwDmPi3kFPBahDbTJXN2rIts8IFZDSrsrgjbq8RbD36cnyF6n/kd7e/lTwEP0I1lCt6 WPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=faX+8xEq5cxeln2IAgBzOZYC6emkLLqmLHlpGzsrZsI=; b=3yrGQNFwpAbn9az1qjv+iXa87C1Hle9nqNvyW2I+qjHpd0wM88yD03d5HnkRxflfrF ZbRPSP9Yk9aLXnQ6aaG6EznqPX4MrjfCHnPnR56IRG3WhBcLP8Qe5Y6amZS6XD5/KeZB AXOCKFLamsH4Oh6CFy3r/m8h8dlAZnJu7M1C6weqQHUzaCzqss5xpJUmb0fx8dYYQ5CE mRYGig+u1Lk/qmmVFkvFkhRaE/oXEsZto5vFz4naGxrEh+6XIHb7oXEkJhRWMAxeIsb1 ACwU02o5mrygzLNozMmywO2WP15zhIBMSNegr5jCQtRlgonfFgpcB8nE5CflY0NrrEXq gW8A== X-Gm-Message-State: AOAM532RYy8shpSXdG5v0P4bClNudEmUyj3m2d8M1Pj2hwGPq9pW3zaH GJ5/+jDyjnpFVKmy9wdxzBVyi7naMnSgTX4uW5MUdl+DveU= X-Google-Smtp-Source: ABdhPJza/ohc+w9rdaX0OxSl3QRR+W9TuPshb4dunNAUPl5XzezXZp8QbAzXuRYReRzLiYb+1tYgVyY2qzk5SSpHy3I= X-Received: by 2002:a81:2154:0:b0:2f4:d79e:35dc with SMTP id h81-20020a812154000000b002f4d79e35dcmr227895ywh.126.1650497102573; Wed, 20 Apr 2022 16:25:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 21 Apr 2022 01:24:51 +0200 Message-ID: Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maira and sorry for being slow on reviews. On Tue, Nov 2, 2021 at 2:04 AM Ma=C3=ADra Canal wrote: > - gpio_set_value_cansleep(imx6_pcie->reset_gpio, > + gpiod_set_raw_value_cansleep(imx6_pcie->reset_gpio, > !imx6_pcie->gpio_active_high); Hm I see you got advised to use the raw api. I'm not so sure about that I like v1 better. > + imx6_pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", > + imx6_pcie->gpio_active_high ? GPIOD_OUT_HIGH : G= PIOD_OUT_LOW); > + if (IS_ERR(imx6_pcie->reset_gpio)) > + return dev_err_probe(dev, PTR_ERR(imx6_pcie->reset_gpio), > + "unable to get reset gpio\n"); Where is this descriptor coming from? Device trees? Can't we just fix the DTS file(s) in that case given how wrong they are if they don't set GPIO_ACTIVE_LOW flag on this IRQ. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53615C433F5 for ; Wed, 20 Apr 2022 23:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2HRP39+9PZkm01T9XfAFv0BF2S/PYzrOIfFW8p1DPLo=; b=p+BhHUTcxavNUy iPBzeDTAFzhtMlZqpb7wALBrNGXqLxyKPjCGWEtQmNVnucEiwMNCkz6nNgno6VZI8SDg9JnwmwXc9 Fg0IqintpS/JYV0BmX8HJikJrktq/S4Cbyxw+21VX+XaSlyKwJ3GbztBJPzqIW6e0zhTHB/jcu7wH YZUDhYdGtqRBPOpG1cYtwtTnGmTYC0DGvif3nzUs01QLMUrrHi1iSJjB9NTp82+3ttH9zOSck0WHn /XrB/1tyDZe+I6A8yxd4qyfXgIMOBSSNoc0ubbNhSjE2S+i/gif21eJZiOgx8w3u27O9ZnPANaiqx RJHomhQS5SmLRz2DOSRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhJh6-00AqMY-Pq; Wed, 20 Apr 2022 23:25:08 +0000 Received: from mail-yw1-x112c.google.com ([2607:f8b0:4864:20::112c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhJh4-00AqKe-6I for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 23:25:07 +0000 Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-2edbd522c21so34666247b3.13 for ; Wed, 20 Apr 2022 16:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=faX+8xEq5cxeln2IAgBzOZYC6emkLLqmLHlpGzsrZsI=; b=IdysWrk64gPASP4iboMXdeQr8OBqMtOScTiocxTj/PrXpZ3MpyJ7PLa30ylu64mytC dNZJ48LUjpecPRUYztsGI+HRaMLrBaDd/kcZaLV36ygFMFvmDY057Y+HEiWLnX8GNMwh zze4Y1X6WoKVDIaAGotw8iPC/K8l1onAsVljpkbYO8mFC4YRPbjpiKuiKdaF631UerU7 ti+4EtfpHTfW3DMrUIqjmE+KiLWxhORMBfjPtP60A/UoWuR7wTx2P7q+WOBQloAXxCtG qRwDmPi3kFPBahDbTJXN2rIts8IFZDSrsrgjbq8RbD36cnyF6n/kd7e/lTwEP0I1lCt6 WPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=faX+8xEq5cxeln2IAgBzOZYC6emkLLqmLHlpGzsrZsI=; b=DXnYAvOdftdvmETLhmofndlcm2Ng0AnTQWMrKv7IQ1PtB0MqlUZUQkp+Qo2WU8gLWW 3XVzgJMBpXUKVQcc4Wu+KaXUbVkeK8L8zKp9AdIAU00UGYNY6jtMsW0Zz022zxaCkQTa 85ZviVc4oRGAY5lzfUatH0KGrhpE2GTlytGJa3n6CJflXVk0duF4Z8swJ4SdPF0tc2Mu fMaIquDEzOH7iYAB6o84Y0jkxHrr2LXjTzSRdcnXOzZwLHvlCofNLe6TrK5L32ncaNQ4 7YVGzm+oND/jDD0JvGMLF18VR8Zy1u83oO2lMYtB+R/08YIAuhvozflPLk+qLknfdZxp z0uQ== X-Gm-Message-State: AOAM53078vs/28kMB7EE4gNJOQzo4TFEQDs0j2VxRlBiNkclREr2rNeu 38Fx/QrwJzWLkKyejV6lI3wdK1MLFhpM5ue3RJ+72A== X-Google-Smtp-Source: ABdhPJza/ohc+w9rdaX0OxSl3QRR+W9TuPshb4dunNAUPl5XzezXZp8QbAzXuRYReRzLiYb+1tYgVyY2qzk5SSpHy3I= X-Received: by 2002:a81:2154:0:b0:2f4:d79e:35dc with SMTP id h81-20020a812154000000b002f4d79e35dcmr227895ywh.126.1650497102573; Wed, 20 Apr 2022 16:25:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 21 Apr 2022 01:24:51 +0200 Message-ID: Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_162506_260804_455648ED X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFpcmEgYW5kIHNvcnJ5IGZvciBiZWluZyBzbG93IG9uIHJldmlld3MuCgpPbiBUdWUsIE5v diAyLCAyMDIxIGF0IDI6MDQgQU0gTWHDrXJhIENhbmFsIDxtYWlyYS5jYW5hbEB1c3AuYnI+IHdy b3RlOgoKPiAtICAgICAgICAgICAgICAgZ3Bpb19zZXRfdmFsdWVfY2Fuc2xlZXAoaW14Nl9wY2ll LT5yZXNldF9ncGlvLAo+ICsgICAgICAgICAgICAgICBncGlvZF9zZXRfcmF3X3ZhbHVlX2NhbnNs ZWVwKGlteDZfcGNpZS0+cmVzZXRfZ3BpbywKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIWlteDZfcGNpZS0+Z3Bpb19hY3RpdmVfaGlnaCk7CgpIbSBJIHNlZSB5b3Ug Z290IGFkdmlzZWQgdG8gdXNlIHRoZSByYXcgYXBpLiBJJ20gbm90IHNvIHN1cmUgYWJvdXQKdGhh dCBJIGxpa2UgdjEgYmV0dGVyLgoKPiArICAgICAgIGlteDZfcGNpZS0+cmVzZXRfZ3BpbyA9IGRl dm1fZ3Bpb2RfZ2V0X29wdGlvbmFsKGRldiwgInJlc2V0IiwKPiArICAgICAgICAgICAgICAgICAg ICAgICBpbXg2X3BjaWUtPmdwaW9fYWN0aXZlX2hpZ2ggPyAgR1BJT0RfT1VUX0hJR0ggOiBHUElP RF9PVVRfTE9XKTsKPiArICAgICAgIGlmIChJU19FUlIoaW14Nl9wY2llLT5yZXNldF9ncGlvKSkK PiArICAgICAgICAgICAgICAgcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJSKGlteDZf cGNpZS0+cmVzZXRfZ3BpbyksCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAidW5h YmxlIHRvIGdldCByZXNldCBncGlvXG4iKTsKCldoZXJlIGlzIHRoaXMgZGVzY3JpcHRvciBjb21p bmcgZnJvbT8gRGV2aWNlIHRyZWVzPyBDYW4ndCB3ZSBqdXN0IGZpeCB0aGUKRFRTIGZpbGUocykg aW4gdGhhdCBjYXNlIGdpdmVuIGhvdyB3cm9uZyB0aGV5IGFyZSBpZiB0aGV5IGRvbid0IHNldApH UElPX0FDVElWRV9MT1cgZmxhZyBvbiB0aGlzIElSUS4KCllvdXJzLApMaW51cyBXYWxsZWlqCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==