From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 016ADC4363C for ; Mon, 21 Sep 2020 21:34:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C3423A60 for ; Mon, 21 Sep 2020 21:34:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="04Yuk1Yi"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z2nOSsj2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C3423A60 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bs/YeyM1tFp8McPGt7xFUHFUpVci8SiyTjG10YWpn6s=; b=04Yuk1YiSi+yRzZLYNQrcpitM qKmZme3IQhPJR/JWJfdA93kn/aBAjrjbu9/0JFgAErwqSA4fgEnyO2yzkC+40LNNuWWRFyGrGb0ul E6E98+6fhWRitfvfuYOFx5SxyHwvHOvyjbeM+FNxNUABcZxGksOHS32MwRjMGSbvORDSaAmUAPKHQ jdSFpUtIs80bODTh/Awj/ShIC1zywFTay5KFUHOTxGy2xe9i+SPaitUqr/jowrLm18yIvwD4OAtDC FM22Op7fdRCf9CNNrGoWDk1Ee8KutyGvvtL2+Ry/rPluzCpKa4hgRpBFwa+8pZjrkB95H8pSunZXW 1W33nQhEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKTQa-0003o5-VZ; Mon, 21 Sep 2020 21:32:53 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKTQY-0003nS-9x for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 21:32:51 +0000 Received: by mail-lj1-x244.google.com with SMTP id k25so12335827ljg.9 for ; Mon, 21 Sep 2020 14:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0jRK4tuNzYA5hcUw94Or8kYumY1XoSF+p8lqpANhekM=; b=Z2nOSsj2DF+QS/WHCozMqdmmb1C+xEpDzfWndQKj//cmuQpPmeL/uGInLRuXMppepu l4GHFMIMqlt9f8wY00Eb0HNWm0Vo5+sK/Ds2moe9cTR2qkmgy+a11MfHpvvlgYWA9xWq RzmrQSB5boiejmba/EGAlw7KAGFER9ee6LzsT60twysiXhogLSYC1Litwj6A+i3YWqhM p/oos46zwDX8zSytTI4Z3bYaN4UJ2dqSEVjbGmU+YoyyXmT0a4zaQCbg50hEzm1GWLgL 8GmUTNN+g6Z1ANw0MMrIKuRfIzTPmvZzGhKKdeHS2MjmvkTxI1XzwHQk1fwXhU3Llxw7 If1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0jRK4tuNzYA5hcUw94Or8kYumY1XoSF+p8lqpANhekM=; b=JCQHEmu9+JRv9H0u8CI7y7R2bcLCiMAlo3eYUWDOddwJ6z9/yxJCkbfpLD2KzYNF2Q TJW/OGZfxquya0qUrEHXKDv+7L0JZP624Bf4RdJd2MF0DBA/F5kUzgMkEChGLhoB/wEV nNiY/EcexLv3A9nWnXUpbGI5PdPIpsBGf8CT336fNmtM0JSGwxIV7GWBhaZi9FVp0xg+ nyFsfuuLKK/ENw/NjJmDEbmfDm5fu4araH9kZglp244xKQ+7bOJRMSiLyEOp66iaGuL/ MlY5rEi0Wd8Jg3y3nzLDL1RQTeXL+pEeSjkLlMQkGa3GQ7q5vPejgbVRcyQsvAZNI0s6 WImg== X-Gm-Message-State: AOAM532sV6RQ9L3qKKJTgAepqbLOWqidLixccweibDAGXe5omD4wVO+q qqRM9yQnBCMFAB/vG8MStZrnaQZ0ms5UXmCpioiIj4pTfTBf1qYQ X-Google-Smtp-Source: ABdhPJxB3B4hyZR/y2w/N52XJDWHxrwFdIahb8iXrtEXFNcO6zX2Bk2djtwTH/XRL0woLcscoArIxGvroBdCbmMk3sE= X-Received: by 2002:a05:651c:107b:: with SMTP id y27mr444903ljm.338.1600723967901; Mon, 21 Sep 2020 14:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20200609200446.153209-1-linus.walleij@linaro.org> <20200609200446.153209-2-linus.walleij@linaro.org> In-Reply-To: From: Linus Walleij Date: Mon, 21 Sep 2020 23:32:37 +0200 Message-ID: Subject: Re: [PATCH 2/4] video: fbdev: amba-clcd: Retire elder CLCD driver To: Peter Collingbourne , John Stultz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_173250_442463_C02BE8D4 X-CRM114-Status: GOOD ( 26.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Brodsky , Maarten Lankhorst , Russell King , Maxime Ripard , Eric Anholt , ML dri-devel , Sean Paul , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 3:10 AM Peter Collingbourne wrote: > On Tue, Jun 9, 2020 at 1:08 PM Linus Walleij wrote: > > > > All the functionality in this driver has been reimplemented > > in the new DRM driver in drivers/gpu/drm/pl111/* and all > > the boards using it have been migrated to use the DRM driver > > with all configuration coming from the device tree. > > Android's FVP configuration still uses FBDEV. But all DRM drivers support frame buffer emulation so I don't see how this can be a problem? The new DRM driver provides a framebuffer. I'm also confused about how this can be in use. fvp-base-revc.dts includes rtsm_ve-motherboard.dtsi where the PL111 is defined. commit f1fe12c8bf33241e04c57a0fc5b25b16ba77ba2d "ARM: dts: Modernize the Vexpress PL111 integration" changes the DTS for the FVP such that only the new DRM driver really works with it: it removes the panel-dpi encoded panel and defines the panel "arm,rtsm-display" for FVP and that is *only* supported by drivers/gpu/drm/panel/panel-simple.c from DRM. The upstream FVP has been using the new DRM driver by default since commit 37ad688497785c9ad1471236e28efda1e2f39741 "arm64: defconfig: Switch to PL11x DRM driver" in january 2019. Are you using old or outoftree devicetrees with a newer kernel? > While it would be great > to see it migrated to DRM, this first requires resolving a design > incompatibility between Android's composer and DRM devices that only > support software rendering. I proposed a patch that would help resolve > this [1], but there was disagreement about the approach and I haven't > had time to get back to this. > > Can this please be reverted until FVP on Android can be migrated to DRM? We need a clear technical reason, I understand that using DRM directly might be a problem, but DRM supports full framebuffer emulation and from a userspace point of view, what the new driver provides should be equivalent. I can think of problems like Android seeing the new fancy DRM userspace ABI but surely it can be instructed to ignore that and just use the framebuffer emulation instead? If there is anything else making DRMs framebuffer emulation substandard I am sure the DRM developers would like to know, especially if it makes Android unhappy. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDE1C4363C for ; Mon, 21 Sep 2020 21:32:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1E1423A61 for ; Mon, 21 Sep 2020 21:32:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z2nOSsj2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1E1423A61 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2725D6E58A; Mon, 21 Sep 2020 21:32:55 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 799056E58A for ; Mon, 21 Sep 2020 21:32:49 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id a15so12374674ljk.2 for ; Mon, 21 Sep 2020 14:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0jRK4tuNzYA5hcUw94Or8kYumY1XoSF+p8lqpANhekM=; b=Z2nOSsj2DF+QS/WHCozMqdmmb1C+xEpDzfWndQKj//cmuQpPmeL/uGInLRuXMppepu l4GHFMIMqlt9f8wY00Eb0HNWm0Vo5+sK/Ds2moe9cTR2qkmgy+a11MfHpvvlgYWA9xWq RzmrQSB5boiejmba/EGAlw7KAGFER9ee6LzsT60twysiXhogLSYC1Litwj6A+i3YWqhM p/oos46zwDX8zSytTI4Z3bYaN4UJ2dqSEVjbGmU+YoyyXmT0a4zaQCbg50hEzm1GWLgL 8GmUTNN+g6Z1ANw0MMrIKuRfIzTPmvZzGhKKdeHS2MjmvkTxI1XzwHQk1fwXhU3Llxw7 If1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0jRK4tuNzYA5hcUw94Or8kYumY1XoSF+p8lqpANhekM=; b=LN4k5q0FzDENICcRhtcCSv6M79UQ9dad8sexJy4BqvuckFRGXN71sh4KFP+kOJOcNX 8EjJuNZ9BaTKyD/rMmSpLlJRWF+LxoBp5hnIyuVb0v90Q0sY5jF6iXtse0KpwJQynv1x +lo6r4BGX2vNXJmgiJ9DHSRkXIV7gra0sU5IDwfUUlz7Yo1t76JYB+xCvipBEhRR+dve IstdZV1DVdqssbVyCkzWH9JslqRPbLO4Wk1+Vg4q7XFvRcSA4G4g6unELtrKmmWFqixd n2ZoagbF/E9ZgGIaT/9kqiFIqegg2DyvWz2M/2EZV8ch42vjnQBeE1cinAUKtKBnhwqf D1lA== X-Gm-Message-State: AOAM531ce1yK5Oxi/cede1AdgbS1A8XRBn/7GgpfcWQihmrwIfChjov9 QPzxOR5CLPBPyq31aIzhnBL5/68M8xbR3HtUaFuokA== X-Google-Smtp-Source: ABdhPJxB3B4hyZR/y2w/N52XJDWHxrwFdIahb8iXrtEXFNcO6zX2Bk2djtwTH/XRL0woLcscoArIxGvroBdCbmMk3sE= X-Received: by 2002:a05:651c:107b:: with SMTP id y27mr444903ljm.338.1600723967901; Mon, 21 Sep 2020 14:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20200609200446.153209-1-linus.walleij@linaro.org> <20200609200446.153209-2-linus.walleij@linaro.org> In-Reply-To: From: Linus Walleij Date: Mon, 21 Sep 2020 23:32:37 +0200 Message-ID: Subject: Re: [PATCH 2/4] video: fbdev: amba-clcd: Retire elder CLCD driver To: Peter Collingbourne , John Stultz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Brodsky , Russell King , ML dri-devel , Sean Paul , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 15, 2020 at 3:10 AM Peter Collingbourne wrote: > On Tue, Jun 9, 2020 at 1:08 PM Linus Walleij wrote: > > > > All the functionality in this driver has been reimplemented > > in the new DRM driver in drivers/gpu/drm/pl111/* and all > > the boards using it have been migrated to use the DRM driver > > with all configuration coming from the device tree. > > Android's FVP configuration still uses FBDEV. But all DRM drivers support frame buffer emulation so I don't see how this can be a problem? The new DRM driver provides a framebuffer. I'm also confused about how this can be in use. fvp-base-revc.dts includes rtsm_ve-motherboard.dtsi where the PL111 is defined. commit f1fe12c8bf33241e04c57a0fc5b25b16ba77ba2d "ARM: dts: Modernize the Vexpress PL111 integration" changes the DTS for the FVP such that only the new DRM driver really works with it: it removes the panel-dpi encoded panel and defines the panel "arm,rtsm-display" for FVP and that is *only* supported by drivers/gpu/drm/panel/panel-simple.c from DRM. The upstream FVP has been using the new DRM driver by default since commit 37ad688497785c9ad1471236e28efda1e2f39741 "arm64: defconfig: Switch to PL11x DRM driver" in january 2019. Are you using old or outoftree devicetrees with a newer kernel? > While it would be great > to see it migrated to DRM, this first requires resolving a design > incompatibility between Android's composer and DRM devices that only > support software rendering. I proposed a patch that would help resolve > this [1], but there was disagreement about the approach and I haven't > had time to get back to this. > > Can this please be reverted until FVP on Android can be migrated to DRM? We need a clear technical reason, I understand that using DRM directly might be a problem, but DRM supports full framebuffer emulation and from a userspace point of view, what the new driver provides should be equivalent. I can think of problems like Android seeing the new fancy DRM userspace ABI but surely it can be instructed to ignore that and just use the framebuffer emulation instead? If there is anything else making DRMs framebuffer emulation substandard I am sure the DRM developers would like to know, especially if it makes Android unhappy. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel