From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C3DC433E0 for ; Wed, 17 Mar 2021 15:55:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99A0E64EEC for ; Wed, 17 Mar 2021 15:55:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99A0E64EEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mWmUaVvTEGMRNtuqBRbA1jZ48yQwxJQ5oSHv4TDBk9Q=; b=XiGriYSkwZQO+/r04wCfjPQgJ bQAz6+HDwjjUNCIK3GI/o0AVkku93+gTKtqWb5U1x76nYh9JXXiMZQNA8Dayv+5FRMu/sQg5MAI8c E8V0Et0dApDMrQNIJb5PHRYR5kIJmaBIanwdeYxS1EUtyodJHirhDkdICY3hc9teVqol6ujDOc+gq 2ay9dyd3q5QqauM5lfhJzptlUJ1eI/zzf2wE0buC1IWBrLyEigF1CenDlb1686n4pesr+ZGl5RSz2 tbwrfkIWeYtDnWWf97xm+UKVKMxLp/tB+S4rMWQQw2hpxGxhJpoUlMLcgT9tNkI50cPCSp8Ce1yR7 tYbSZiwvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMYUy-003TSg-CD; Wed, 17 Mar 2021 15:54:16 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMYUt-003TSH-TX for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 15:54:13 +0000 Received: by mail-lf1-x132.google.com with SMTP id p21so3690957lfu.11 for ; Wed, 17 Mar 2021 08:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6hUAfqi18KmtNa9REspjMOP+elYDH3y8j6iERMwIjKE=; b=dczrRa2LfhPqiKjkPReUzoMJ6N1qjSl2O4NEVPGYSEUCSB2fnyL7yBIUqeQA0GW+aG 1fbj/rCKfoQ7JVIZnox/2sgbxPCwPAgJO/AddOd9uVfQ7+v36H0TjIvWzfwNPojF8c9+ SG+K8U97FHo/fd4k8eJhJmh1cVyA0ePmWdMeIsjAR6BIGgeot9Yg3i+tAY8IyCS/uwR7 fWU6JkZ3S7io0VrtWZ4sOUdg9f3X8jOG1lumhBz3ahM4TYQZO5aVdEQwuSxJ6ZdybXqu yX1Xcy7nw8xBj3nR9XZxzHKhvBBfzAKj/Ghkma2jrAgai0ESSY2dtggh6Ftt2Zv0JE4m tdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6hUAfqi18KmtNa9REspjMOP+elYDH3y8j6iERMwIjKE=; b=ckeo24bEaC5EAcB59Zcq7K4smpz5GCNsN8rnS3t7ohLCBcBFr9PtrerqFZKn4s2T0t kb5vZZ87Kh1UC7/F8iW1dVW1Qxw4jaYr41DA9+fncqW6Ns7n2RhTPP2LW+FKI/byYYaK Wa6WGUsB9sJH7Z3MhHy+klUuqcfLNaT/coBIgnEkJmMKOJQ7nOuCSoptonp+qsJkRwuD h80BOwJ5BZsor0mPAkQwULWzGUbBbc8MulnbUq6CkSxYX0XTg6n48A7zjgg/xVjTap27 bcEkbIsLABFLWEFJuzaok3HT7wwzYiDNbCHdGGjSFoiTfewXwAibEtYfStGfWaWD2oYr 0hpw== X-Gm-Message-State: AOAM530wOyPEHBR1/H4PaFdxeJE6n1EJOYjeIKgo2CwIEKU4FfB6Wsb4 00otuU0k8pVUb35Z2yejcNTOYMPdvVgXbSxuT2q2eNX3o0aEdt/cwFM= X-Google-Smtp-Source: ABdhPJw41x4L40iWsoXgGrHgKrTCmPvUnQeOCTd8jysVRNjRI/NgykVPHvpPHB7rSYFUJNgmatZ1ZGzEVHjaiJCwpII= X-Received: by 2002:a05:6512:243:: with SMTP id b3mr2799122lfo.529.1615996449429; Wed, 17 Mar 2021 08:54:09 -0700 (PDT) MIME-Version: 1.0 References: <20210315110750.139610-1-linus.walleij@linaro.org> In-Reply-To: From: Linus Walleij Date: Wed, 17 Mar 2021 16:53:58 +0100 Message-ID: Subject: Re: [PATCH v2] ARM: dts: ux500: Fix BT+WLAN on Samsung phones To: Stephan Gerhold Cc: Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_155412_064465_32DC2B5D X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 17, 2021 at 4:28 PM Stephan Gerhold wrote: > According to the schematics for samsung-golden: > - GPIO215 goes to WL_REG_ON of BCM4334 > - GPIO222 goes to BT_REG_ON of BCM4334 Yes it appears you are right... This is in conflict with the source code in the vendor tree: board-golden-pins.c: GPIO215_GPIO | PIN_OUTPUT_LOW, /* WLAN_RST_N */ GPIO222_GPIO | PIN_OUTPUT_LOW, /* BT_VREG_EN */ However the BCM4334 does not have appear to have any signal named WLAN_RST_N. So I suspect a copy/paste error from Janice, which might need this because of differences between BCM4330 and BCM4334. However another part of the patch is still needed because GPIO215 is default initilized as low: wlan_en_default: wlan_en_default { golden_cfg1 { pins = "GPIO215_AH13"; /* WLAN_EN */ ste,config = <&gpio_out_lo>; }; }; It needs to be high, or the SDIO will not enumerate unless someone powers on the Bluetooth by chance. (The driver probes after the SDIO card is detected ... catch 22.) Also IMO GPIO 222 should be modeled as a regulator and not assigned to "shutdown-gpios", which could be a separate patch. The whole notion of "shutdown-gpios" seems backward as the driver handles regulators just fine. I'll rehash and compare the BCM4330 and BCM4334 datasheets. Thanks! Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel