From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BA3C5DF60 for ; Thu, 7 Nov 2019 07:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43FFD21D6C for ; Thu, 7 Nov 2019 07:56:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o/vg6xLE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726991AbfKGH4P (ORCPT ); Thu, 7 Nov 2019 02:56:15 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35663 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727415AbfKGH4P (ORCPT ); Thu, 7 Nov 2019 02:56:15 -0500 Received: by mail-lf1-f66.google.com with SMTP id y6so850951lfj.2 for ; Wed, 06 Nov 2019 23:56:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7mVzEAC3PYZ6lpwiL+xf/9aZ7Qv1sjEzD+JY+8MBtWg=; b=o/vg6xLElk2f7BrBS3YYNQnsdnM6poifIjeLagf3IT4HY0bFneDxgynYdByIcS7dHo EzLmS6pL/TyvIYJdQEOzBEsnwOAM7Njv1CFAh7AuC54CbmAw47HZJmHVO7et+nczCN+W 7+8o/Voh8wDjNUOFjhCx4CMK4KOz+BHiUSJCtkBLzC40fA5Qb0zg2BvUW7Hm+07pAMXB 0lLuQBKWtKJ5TGKj2EMx7k5O722aqWp0xbmm+Bc3j5P+DXUw2Q0hnvWWj88ZONlxPSjo npqEAZU/xnP17zcGp5HbfLkqVBsC7eilbm/0NAMCMG057MaAubYC5365OtbgJSB2ih+c McEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7mVzEAC3PYZ6lpwiL+xf/9aZ7Qv1sjEzD+JY+8MBtWg=; b=j0pS/dxglx5BTsZRPblghEgB61U0qAi3Yk+BN6iGQ73x88E8J+FsoUXMtJz2R+Znw7 s2tAkh5FtXg1Gu6mkzr37TY7um+6mlc0y4cBOolk6ioC04qXiuEKb34uTloVvSz1S7Nm jS30BFOVcXJhmrXSV1spajzOXoWHVliX1B2znyjQ4C8IsZktLICUGWYJ9QjfSoehfsis SIsTjr23HGneum1NCm/XddGtBCtw4b33vcUOXVPYnQADnGf8LjQFwHY8AxtsxuKUiBlR L+AHHwjklxkK+p+85eZvN3/pnxm8Q+NvzFC0QG+J/sFxo8UP1Uh4Uv4XbE2Z3mGSnsrg lZ1A== X-Gm-Message-State: APjAAAU8CeGT3AcGX9EtrYUPOXJykX4MH/Rt3HV2MgltlLigRbcMoDnK J5uXTrL/WEEgg7EyuslnGC3mXAnbnsntV9/petGfhJh/F+c= X-Google-Smtp-Source: APXvYqz/ohb7JsLP5oPlc3mF5OTWP6CRzEQS9/wJ3HgdeOitF87zrMa4v8J9ow3u2rGgz4TVrAbl+ne6JhgEadI2dHA= X-Received: by 2002:ac2:51dd:: with SMTP id u29mr1354160lfm.135.1573113373506; Wed, 06 Nov 2019 23:56:13 -0800 (PST) MIME-Version: 1.0 References: <20191105124915.34100-1-broonie@kernel.org> In-Reply-To: <20191105124915.34100-1-broonie@kernel.org> From: Linus Walleij Date: Thu, 7 Nov 2019 08:56:02 +0100 Message-ID: Subject: Re: [PATCH] gpio: xgs-iproc: Fix section mismatch on device tree match table To: Mark Brown Cc: Bartosz Golaszewski , Chris Packham , bcm-kernel-feedback-list , "open list:GPIO SUBSYSTEM" , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Nov 5, 2019 at 1:49 PM Mark Brown wrote: > The table of devicetree identifiers is annotated as __initconst > indicating that it can be discarded after kernel boot but it is > referenced from the driver struct which has no init annotation leading > to a linker warning: > > WARNING: vmlinux.o(.data+0x82d58): Section mismatch in reference from the variable bcm_iproc_gpio_driver to the variable .init.rodata:bcm_iproc_gpio_of_match > The variable bcm_iproc_gpio_driver references > the variable __initconst bcm_iproc_gpio_of_match > > Since drivers can be probed after init the lack of annotation on the > driver struct is correct so remove the annotation from the match table. > > Signed-off-by: Mark Brown Oh thanks a LOT Mark! Hurriedly applied this with the ACKs and pushed out so linux-next starts working. Quite interesting bug, I guess I'll comment on it in the other thread. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF2DC5DF60 for ; Thu, 7 Nov 2019 07:56:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3427221D6C for ; Thu, 7 Nov 2019 07:56:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tTRfW62w"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o/vg6xLE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3427221D6C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RaI5ZWpjPhGvjl1uashfX3veGL3sKInYGjvkibuw33s=; b=tTRfW62wMxRQnV RMg0SITO1BEotMWFK8CO/TdDmZ2tatMXrj53Ae3zEXfW0XbujKakTQiZklgMi7uKUg9tujjQ4OFeh njq0KI3Sr2TYPifGfBNntDB0oA355zjJiwzIdWhnyWP9ws0vcvTkmfq9hepipPRDnvGh2yXuB/8XH uIfVhwnhE01vSMnaC0ozPmdZ7dFNZY/ROVDfzl4qHPPX1KhCZvOeCE8z0eaDlfsBvspYZJn5wxCzD HC+hfGbhS10hyqz/Bdi0H3DKO40AuMz11AgNib9JykZpQr9Fex+veYKyhD0pOvbTfCPb3Bui2s4rX nxbkiEwOwXb7hvtxz4Ng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSceb-0006Kw-1Q; Thu, 07 Nov 2019 07:56:29 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSceP-00069b-1D for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 07:56:18 +0000 Received: by mail-lf1-x141.google.com with SMTP id j14so828367lfb.8 for ; Wed, 06 Nov 2019 23:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7mVzEAC3PYZ6lpwiL+xf/9aZ7Qv1sjEzD+JY+8MBtWg=; b=o/vg6xLElk2f7BrBS3YYNQnsdnM6poifIjeLagf3IT4HY0bFneDxgynYdByIcS7dHo EzLmS6pL/TyvIYJdQEOzBEsnwOAM7Njv1CFAh7AuC54CbmAw47HZJmHVO7et+nczCN+W 7+8o/Voh8wDjNUOFjhCx4CMK4KOz+BHiUSJCtkBLzC40fA5Qb0zg2BvUW7Hm+07pAMXB 0lLuQBKWtKJ5TGKj2EMx7k5O722aqWp0xbmm+Bc3j5P+DXUw2Q0hnvWWj88ZONlxPSjo npqEAZU/xnP17zcGp5HbfLkqVBsC7eilbm/0NAMCMG057MaAubYC5365OtbgJSB2ih+c McEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7mVzEAC3PYZ6lpwiL+xf/9aZ7Qv1sjEzD+JY+8MBtWg=; b=RbTvJooeyhzyTZVGrX+qA//Z4bVPEz/jt478nrM0BVdQAlLDfwr9W3NR6zPQksjE0M oWcuKhcQbMid1ERj1xhiPSADkOF8BkSFx9hUxBrb0Wni+3bZjdX7/GHgtikUqoPtjmZd 7GemoRRNZLqTq241XLF1LBpo1PNLb+T1wOjsNY5A3J04B+LQeIs2pd2OBXSaVVOtXj0S eHRkPCGA8Jtv/ybV3Yq9gAC1gZMuRzHqtYnecDWs9xUx/T5s37bkHKyyMRzOswRz5doC Mqx5y7/MBLdqdOc3pMSuJMuNU6NZDlvQgWJFrtLZ7GoZHdCSW7iLVgazktBsYSV41b4Q 04Zw== X-Gm-Message-State: APjAAAVg2E2fzoBOBShX6QrIicSAgCU7Mt6YVRw2MO4vexw0a7QD1tah 1Z9vWmEp2d91dQhaFJuyFDfjsJt8Gj/tI4zovjfHIw== X-Google-Smtp-Source: APXvYqz/ohb7JsLP5oPlc3mF5OTWP6CRzEQS9/wJ3HgdeOitF87zrMa4v8J9ow3u2rGgz4TVrAbl+ne6JhgEadI2dHA= X-Received: by 2002:ac2:51dd:: with SMTP id u29mr1354160lfm.135.1573113373506; Wed, 06 Nov 2019 23:56:13 -0800 (PST) MIME-Version: 1.0 References: <20191105124915.34100-1-broonie@kernel.org> In-Reply-To: <20191105124915.34100-1-broonie@kernel.org> From: Linus Walleij Date: Thu, 7 Nov 2019 08:56:02 +0100 Message-ID: Subject: Re: [PATCH] gpio: xgs-iproc: Fix section mismatch on device tree match table To: Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_235617_270623_1398CC37 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , Chris Packham , bcm-kernel-feedback-list , Linux ARM , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 5, 2019 at 1:49 PM Mark Brown wrote: > The table of devicetree identifiers is annotated as __initconst > indicating that it can be discarded after kernel boot but it is > referenced from the driver struct which has no init annotation leading > to a linker warning: > > WARNING: vmlinux.o(.data+0x82d58): Section mismatch in reference from the variable bcm_iproc_gpio_driver to the variable .init.rodata:bcm_iproc_gpio_of_match > The variable bcm_iproc_gpio_driver references > the variable __initconst bcm_iproc_gpio_of_match > > Since drivers can be probed after init the lack of annotation on the > driver struct is correct so remove the annotation from the match table. > > Signed-off-by: Mark Brown Oh thanks a LOT Mark! Hurriedly applied this with the ACKs and pushed out so linux-next starts working. Quite interesting bug, I guess I'll comment on it in the other thread. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel