All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Bamvor Jian Zhang <bamv2005@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Subject: Re: [PATCH v2] gpiolib: rewrite gpiodev_add_to_list
Date: Mon, 7 Mar 2016 12:04:05 +0700	[thread overview]
Message-ID: <CACRpkdYq7Dp7iiJVu2uuL7J8UGuVfVQjkQkXNGo1ynAe1AkiXw@mail.gmail.com> (raw)
In-Reply-To: <1456497434-11656-1-git-send-email-bamv2005@gmail.com>

On Fri, Feb 26, 2016 at 9:37 PM, Bamvor Jian Zhang <bamv2005@gmail.com> wrote:

> From: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
>
> The original code of gpiodev_add_to_list is not very clear which
> lead to bugs or compiling warning, reference the following patches:
> Bugs:
> 1.  Commit ef7c7553039b ("gpiolib: improve overlap check of range of
>     gpio").
> 2.  Commit 96098df125c0 ("gpiolib: fix chip order in gpio list")
>
> Warning:
> 1.  Commit e28ecca6eac4 ("gpio: fix warning about iterator").
> of gpio").
>
> There is a off-list discussion about how to improve it consequently.
> This commit try to follow this by rewriting the whole functions.
>
> Tested pass with my gpio mockup driver and test scripts[1].
>
> [1] http://www.spinics.net/lists/linux-gpio/msg09598.html
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>

Patch applied. It surely looks much better like this!

Yours,
Linus Walleij

      reply	other threads:[~2016-03-07  5:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 14:37 [PATCH v2] gpiolib: rewrite gpiodev_add_to_list Bamvor Jian Zhang
2016-03-07  5:04 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYq7Dp7iiJVu2uuL7J8UGuVfVQjkQkXNGo1ynAe1AkiXw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bamv2005@gmail.com \
    --cc=bamvor.zhangjian@linaro.org \
    --cc=broonie@kernel.org \
    --cc=julien.grossholtz@savoirfairelinux.com \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.