From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5E4C2BB1D for ; Thu, 12 Mar 2020 14:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CED420663 for ; Thu, 12 Mar 2020 14:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H7DN/hrX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727619AbgCLOIM (ORCPT ); Thu, 12 Mar 2020 10:08:12 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:42972 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgCLOIM (ORCPT ); Thu, 12 Mar 2020 10:08:12 -0400 Received: by mail-vk1-f194.google.com with SMTP id e20so1590600vke.9 for ; Thu, 12 Mar 2020 07:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6J9Ig2oz1bb7guvVXYyRNpRVz0RKMu9DYxVEd/SzgXI=; b=H7DN/hrXC5SOfs2915ZbQulRR7iAHtt3uIi89leVhH11cRIYwJ9rIM5rrJTWqrQc9c k6W4+S7mPhWQ2G271UpAF2UqqOBhfUyXVTTOQeRHxJK7VosV9dmfY0UvneGlfP+dqukd ba3Z/Ki7tJ2JemSrkSaxjoOoJtCIg6pMKZ3j9UHyB38C1Ah7aqbxMCC2r+nHacnypqbc r3A4lgiLdqxs92Kk3ltPbguQYkRSI1unHNO6GWPHWvlAERBw4nfA4AMns8o44eOr+zKm BUJ0/BKeCLxznbuOfoSnK76G/tzMHiPgKc78DV+nGGwt69TptpgDvh0rOWdTy6i018Jm ag0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6J9Ig2oz1bb7guvVXYyRNpRVz0RKMu9DYxVEd/SzgXI=; b=HL1r76gL47EXRbceWDXeT5RNhD5hJDMDW8B50s5UFsZlnSfMWnfz/D1CDWkYO6aC3h jMdPw/8rXkX/kmZN1keWBYxGKWDbVi4JLQIj2LuPeyyTB/Lh8Lxw5e7L5fELncMvjqce 3rXUBGXKF5Iwg1YEX5Ag7YqzjVK0+5ytJ/SRjKlw/Jwqr7ieQ1JwrYSjg8mxtT4Juz7W ZrHauvcoyodVQQEIu88HU547fot+5Eme+y/hE09pzAYx4BxHf366BOK5O/m0h98M6iiO l7ksOzdLKW1r3emWLs3dQtKB6P7dcYSUJqpnWVTsaEKOnP9hlHMneAngzs5pdY4Tdt9a 6uyQ== X-Gm-Message-State: ANhLgQ2sITydve6oD98lu5t3RnHq/QqWY7q0xTTXl0oim605xq/X4inC xjXjt3Rhh2JDgYB0TFEkJflc8FcG5CDOEpUMBHuwTw== X-Google-Smtp-Source: ADFU+vsGDaiiav8lo5THUgIDY0HPzi+5T5mlfmPdJyURWCmQInX4drk2MUTv+qfoecTOl54d4a4OmoBfL83ZlRl3Who= X-Received: by 2002:a1f:5c84:: with SMTP id q126mr5449459vkb.5.1584022089616; Thu, 12 Mar 2020 07:08:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 12 Mar 2020 15:07:58 +0100 Message-ID: Subject: Re: [PATCH 1/5] pci: handled return value of platform_get_irq correctly To: Aman Sharma Cc: Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , Ryder Lee , Karthikeyan Mitran , Hou Zhiqiang , Marc Gonzalez , Mans Rullgard , Matthias Brugger , linux-pci , Linux ARM , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 8:19 PM Aman Sharma wrote: > Signed-off-by: Aman Sharma > --- > drivers/pci/controller/pci-v3-semi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c > index bd05221f5a22..a5bf945d2eda 100644 > --- a/drivers/pci/controller/pci-v3-semi.c > +++ b/drivers/pci/controller/pci-v3-semi.c > @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev) > > /* Get and request error IRQ resource */ > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > + if (irq < 0) { Have you considered: https://lwn.net/Articles/470820/ TL;DR Linus (both of them) are not with you on this. And that is why the code is written like this. Do you really have a platform that could return 0 as IRQ here? In that case, can we fix it? > dev_err(dev, "unable to obtain PCIv3 error IRQ\n"); > - return -ENODEV; > + return irq; That's OK with me. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D766AC10DCE for ; Thu, 12 Mar 2020 14:08:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A92F8206E7 for ; Thu, 12 Mar 2020 14:08:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="scdSsh7e"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H7DN/hrX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A92F8206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vd5fBUsiyaqqFVmqDOVNH0vF3tOlSqdjU6bx3T5Hhik=; b=scdSsh7eH+qQem /bexEZgGPlX/MWGA6eC/5/mhH4sl3ul+E7gCeyDH9jo2wxUS0JAT5Cg6SVVX2tVxIzc/AAAlYWli7 D16+RvEer6G2vmJbIg18+I+a/Iwb1DAM28soNV4joZh4BmGZZt00y1gpcIBelMQh4HowYXRAgr0rH OmuvXucy6fRWdMnwITNp0/p3OmAqk1jPPzhTsprlGAkEh+GxfAiOvAHoX+nUou1fy1jaqTjmbWH9e SR1seSPzNzqFLDyk7noZcKO3RnTuPIgxO0AauoxgZUUN/NSPF6jvGUO6UgtY5mspXtU4ED609fEYD cU99GgdLi03YI2uxG16w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCOVZ-0005xo-67; Thu, 12 Mar 2020 14:08:21 +0000 Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCOVO-0005pP-WF for linux-mediatek@lists.infradead.org; Thu, 12 Mar 2020 14:08:12 +0000 Received: by mail-vk1-xa43.google.com with SMTP id w67so1600920vkf.1 for ; Thu, 12 Mar 2020 07:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6J9Ig2oz1bb7guvVXYyRNpRVz0RKMu9DYxVEd/SzgXI=; b=H7DN/hrXC5SOfs2915ZbQulRR7iAHtt3uIi89leVhH11cRIYwJ9rIM5rrJTWqrQc9c k6W4+S7mPhWQ2G271UpAF2UqqOBhfUyXVTTOQeRHxJK7VosV9dmfY0UvneGlfP+dqukd ba3Z/Ki7tJ2JemSrkSaxjoOoJtCIg6pMKZ3j9UHyB38C1Ah7aqbxMCC2r+nHacnypqbc r3A4lgiLdqxs92Kk3ltPbguQYkRSI1unHNO6GWPHWvlAERBw4nfA4AMns8o44eOr+zKm BUJ0/BKeCLxznbuOfoSnK76G/tzMHiPgKc78DV+nGGwt69TptpgDvh0rOWdTy6i018Jm ag0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6J9Ig2oz1bb7guvVXYyRNpRVz0RKMu9DYxVEd/SzgXI=; b=MjfJvzXPWH8eTpHX1rdqQHFjVcfMDjFzBqWrKBrN4juSJLITahHPrzjPvuSdNIyKpv Le4LfjAvYUIJeEkD76TLyg987Yj+BFrlD2i4vS99VSqibqYTPziCLOvUwy5zzluSMOrz U5sLGZY05ood173zzR9FJ2O+D7p65LS++zeqXR/9Z/qmiNZ0nm0opS16Ri1tt/rXJLp8 ptxpm701eI8KN19fG3MYKg3jCbkf2mLm/nRyeqiOUQeJWhg5xK7IktVGuoOrgAYpkZYS DStaZAiyEMlB5Lpltn6nOhTB5dpksETzFSaLf/sEoE/Dcecrlw2OBGMboLzk4ytYFNXn c5Bg== X-Gm-Message-State: ANhLgQ27IUAJgNuTXV2clV9JT94qFS2BdREWsvj+6IarO9rxKHisguSX m6SnRXT9eyt3BR0vSGqNfGIGML2Co1RiHVeduD/ttg== X-Google-Smtp-Source: ADFU+vsGDaiiav8lo5THUgIDY0HPzi+5T5mlfmPdJyURWCmQInX4drk2MUTv+qfoecTOl54d4a4OmoBfL83ZlRl3Who= X-Received: by 2002:a1f:5c84:: with SMTP id q126mr5449459vkb.5.1584022089616; Thu, 12 Mar 2020 07:08:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 12 Mar 2020 15:07:58 +0100 Message-ID: Subject: Re: [PATCH 1/5] pci: handled return value of platform_get_irq correctly To: Aman Sharma X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_070811_039131_973F11D1 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Karthikeyan Mitran , Marc Gonzalez , linux-pci , Hou Zhiqiang , "linux-kernel@vger.kernel.org" , Matthias Brugger , Ryder Lee , "moderated list:ARM/Mediatek SoC support" , Thomas Petazzoni , Bjorn Helgaas , Mans Rullgard , Linux ARM , Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Mar 11, 2020 at 8:19 PM Aman Sharma wrote: > Signed-off-by: Aman Sharma > --- > drivers/pci/controller/pci-v3-semi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c > index bd05221f5a22..a5bf945d2eda 100644 > --- a/drivers/pci/controller/pci-v3-semi.c > +++ b/drivers/pci/controller/pci-v3-semi.c > @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev) > > /* Get and request error IRQ resource */ > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > + if (irq < 0) { Have you considered: https://lwn.net/Articles/470820/ TL;DR Linus (both of them) are not with you on this. And that is why the code is written like this. Do you really have a platform that could return 0 as IRQ here? In that case, can we fix it? > dev_err(dev, "unable to obtain PCIv3 error IRQ\n"); > - return -ENODEV; > + return irq; That's OK with me. Yours, Linus Walleij _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1312C4CECE for ; Thu, 12 Mar 2020 14:08:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0814206E7 for ; Thu, 12 Mar 2020 14:08:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GRs83UOp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H7DN/hrX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0814206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I9GgrKocJ+VNVI9nnBOBTiP+4Xta2b1fTloAalOThH0=; b=GRs83UOpvdSxJP KuHWhOiLa3e3mLx5uxFwXv7XQvO4/38WLJNdzjRIT8UDvKgJtjv2Ns6L+DGA0pRPPKhDhR82L0Muv oUHUQsDE38iv36KVa5BIclXA/Mdn0YNHG4EuYEPBndqjkoIiu3bMnanllcXs8pmclPkdxRkTjdE9D OqgSANUnqR2gtIpBNtjb7v8QMh8gwr1Zdpwi5SBhYVYNdcqoXdu1Fi5k3jzILh6DdhoZAvVCmYuJ4 x0mYRSaRNqvqWF5m0gml1RCwZlMhvVMF4zV10Xourh3qFWkk/uKM//+pjYwki674v80uDNjiBfKyq MvDDlGx38HceRcNy6tdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCOVR-0005q4-W2; Thu, 12 Mar 2020 14:08:13 +0000 Received: from mail-vk1-xa42.google.com ([2607:f8b0:4864:20::a42]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCOVP-0005pQ-00 for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2020 14:08:12 +0000 Received: by mail-vk1-xa42.google.com with SMTP id w4so1595473vkd.5 for ; Thu, 12 Mar 2020 07:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6J9Ig2oz1bb7guvVXYyRNpRVz0RKMu9DYxVEd/SzgXI=; b=H7DN/hrXC5SOfs2915ZbQulRR7iAHtt3uIi89leVhH11cRIYwJ9rIM5rrJTWqrQc9c k6W4+S7mPhWQ2G271UpAF2UqqOBhfUyXVTTOQeRHxJK7VosV9dmfY0UvneGlfP+dqukd ba3Z/Ki7tJ2JemSrkSaxjoOoJtCIg6pMKZ3j9UHyB38C1Ah7aqbxMCC2r+nHacnypqbc r3A4lgiLdqxs92Kk3ltPbguQYkRSI1unHNO6GWPHWvlAERBw4nfA4AMns8o44eOr+zKm BUJ0/BKeCLxznbuOfoSnK76G/tzMHiPgKc78DV+nGGwt69TptpgDvh0rOWdTy6i018Jm ag0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6J9Ig2oz1bb7guvVXYyRNpRVz0RKMu9DYxVEd/SzgXI=; b=MJQk6G8r500VivaAWSmOnnTlBUGOX6/eozXlLKCYA+ylBVmDxL9qLSuplKLadrymim 4U6hW/AdhdEGqJcsMETViY0GeD9++WkDWy260N5+o9K1n5ZlQXYdOjEssb3vq5cuHisF CC3A/DUl66xojsXm61mIcMZxEhmiIUdg7FWAQHcxNs2uiqED0kaJa+yl6BotpH8FAseI mC0fOimX+2ullrPI9NfP7mQT84zZemD33LdeEGeIUXoW/jr7lfKB8L6OpX6agAXBLGtX EBCLUwlvIlplt2p2ksb5h5+ZKq29watdJPfxQtb1KjC7Vd0GmeSHessvA83jZM6xMXZ+ DL6A== X-Gm-Message-State: ANhLgQ3U/gPTnIKOcP3xmNGk1k/3ZldMhdRIqlqoLExaAPDytBBm2C5W bmY64jFgfs5XVtWqwBbNehnJ58u+1OkDZcQHTLysbA== X-Google-Smtp-Source: ADFU+vsGDaiiav8lo5THUgIDY0HPzi+5T5mlfmPdJyURWCmQInX4drk2MUTv+qfoecTOl54d4a4OmoBfL83ZlRl3Who= X-Received: by 2002:a1f:5c84:: with SMTP id q126mr5449459vkb.5.1584022089616; Thu, 12 Mar 2020 07:08:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 12 Mar 2020 15:07:58 +0100 Message-ID: Subject: Re: [PATCH 1/5] pci: handled return value of platform_get_irq correctly To: Aman Sharma X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_070811_040372_31EE3C0D X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Karthikeyan Mitran , Marc Gonzalez , linux-pci , Hou Zhiqiang , "linux-kernel@vger.kernel.org" , Matthias Brugger , Ryder Lee , "moderated list:ARM/Mediatek SoC support" , Thomas Petazzoni , Bjorn Helgaas , Mans Rullgard , Linux ARM , Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 11, 2020 at 8:19 PM Aman Sharma wrote: > Signed-off-by: Aman Sharma > --- > drivers/pci/controller/pci-v3-semi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c > index bd05221f5a22..a5bf945d2eda 100644 > --- a/drivers/pci/controller/pci-v3-semi.c > +++ b/drivers/pci/controller/pci-v3-semi.c > @@ -777,9 +777,9 @@ static int v3_pci_probe(struct platform_device *pdev) > > /* Get and request error IRQ resource */ > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > + if (irq < 0) { Have you considered: https://lwn.net/Articles/470820/ TL;DR Linus (both of them) are not with you on this. And that is why the code is written like this. Do you really have a platform that could return 0 as IRQ here? In that case, can we fix it? > dev_err(dev, "unable to obtain PCIv3 error IRQ\n"); > - return -ENODEV; > + return irq; That's OK with me. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel