All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Bamvor Jian Zhang <bamv2005@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Subject: Re: [PATCH] tools: gpio: add kernel headers in CFLAGS
Date: Mon, 7 Mar 2016 12:01:01 +0700	[thread overview]
Message-ID: <CACRpkdYvGYbzENVSfJO-tW8qGs=RzpFCA9BROtU+_92-jjeeTw@mail.gmail.com> (raw)
In-Reply-To: <1456495590-7610-1-git-send-email-bamv2005@gmail.com>

On Fri, Feb 26, 2016 at 9:06 PM, Bamvor Jian Zhang <bamv2005@gmail.com> wrote:

> From: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
>
> Gpio tools require linux/gpio.h which may be only exist in kernel
> source code in a cross compile environment.
>
> Add such header to CFLAGS to avoid compiling failure.
>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>

I already got a patch like this and NACKed it: the procedure to compile
userspace tools is:

make -C ${LINUX_TREE} headers_install ARCH=<arch> INSTALL_HDR_PATH=<bar>
cd tools/gpio
make CFLAGS="${CFLAGS} -I<bar>"

So you push the new locations of your fresh kernel headers to the front of the
include path. But make headers_install is mandatory before trying to compile
userspace, as uapi may differ between architectures.

Yours,
Linus Walleij

      reply	other threads:[~2016-03-07  5:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 14:06 [PATCH] tools: gpio: add kernel headers in CFLAGS Bamvor Jian Zhang
2016-03-07  5:01 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYvGYbzENVSfJO-tW8qGs=RzpFCA9BROtU+_92-jjeeTw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=bamv2005@gmail.com \
    --cc=bamvor.zhangjian@linaro.org \
    --cc=broonie@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.