From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D8AC433E6 for ; Mon, 29 Jun 2020 18:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 416D6204EC for ; Mon, 29 Jun 2020 18:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bEMO9AAn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgF2Sr6 (ORCPT ); Mon, 29 Jun 2020 14:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729355AbgF2Srp (ORCPT ); Mon, 29 Jun 2020 14:47:45 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1898FC02E2C1 for ; Mon, 29 Jun 2020 06:58:15 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id 9so18127438ljc.8 for ; Mon, 29 Jun 2020 06:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uCQ8gnTNmCbw3Jp4/ShmxDGjAQ3pvSFd1R7iQkCtV0o=; b=bEMO9AAnWp5LTsNLVdXW9Oe7mzKQhGXAj0e5OEmfEtAkG1cNaFNZSh2Qdo5mWbPuMY 9DiqUdT+MsXYwleFvjrGxmVJqwyvuKXhxlQUK3rtF7VdMnvX7cTOhwoxwrJJLOVzNu5i 2XK9FlT9eHx+sLquBViH/xZ5rB5rAhbPqcP9GuagM0OXFUt9wlcNzUKNy1aLnFdNwo+V 8Ruz/vdEgYh0uNq8BnFoCh6EqK2N49EfB0DJU88m7ryxOsAPu8lNbY+iq10lCSBY9Mui ZPg6x5swpeRbq9anXoM2U2j46UxRzipSI496ZyBwvvY+KYVNwgj+Iwoz/AD7OkkAul0p isLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uCQ8gnTNmCbw3Jp4/ShmxDGjAQ3pvSFd1R7iQkCtV0o=; b=KbngNQuqzJ6EM4P1ZxMGrBcPkMMGt6wVYD/yEps9rQdKh/IZUAmC2OYK5Id8cpkS1i 0BkUrWxmWD1DBKiUTv2U7tw1ngKfl1dJcPxR56hK5foXPGe7V2BJ3pJY85N9G7nDjrH0 Zq2G7xzz0owM3wj7hhqWXh2RPG/g9OilYgu7O3zqgTstcp5DoE1T55A6/HoYXrIyVyNp DOTsU4Yp/F8YVR1PbWkequQAWhUUxT1Ji04ROzd5CCanWRl00jIg8uqDR7zk8tJJyeP2 eaAMUsoBDsM05irWOe00wmNPLJt9HPp1GiD149kMvvVaXuFGtwdbZD0YPu6gNFYv7vuw Ce4Q== X-Gm-Message-State: AOAM531vbglecf8QD3fQvOYS6p+taU7mHRLCv082YGdwV0Am6RkxVZX6 NQnrTPKqqav0ksSWNtXalXMSEbiSs+qKtmzsakvtd/HRtN0= X-Google-Smtp-Source: ABdhPJyszh+KKJKX6JxEpQEiu36tPTXZ+lFvnrC92R82eADyKCIBV3+TFvVd2yAYiyqz2uUbOeMX15KpV7G5lmjJkoI= X-Received: by 2002:a2e:3504:: with SMTP id z4mr8452019ljz.283.1593439093501; Mon, 29 Jun 2020 06:58:13 -0700 (PDT) MIME-Version: 1.0 References: <20200629123003.1014387-1-lee.jones@linaro.org> In-Reply-To: <20200629123003.1014387-1-lee.jones@linaro.org> From: Linus Walleij Date: Mon, 29 Jun 2020 15:58:02 +0200 Message-ID: Subject: Re: [PATCH 1/1] crypto: ux500: hash: Add namespacing to hash_init() To: Lee Jones Cc: Linux ARM , "linux-kernel@vger.kernel.org" , Herbert Xu , "David S . Miller" , linux-crypto@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jun 29, 2020 at 2:30 PM Lee Jones wrote: > A recent change to the Regulator consumer API (which this driver > utilises) add prototypes for the some suspend functions. These > functions require including header file include/linux/suspend.h. > > The following tree of includes affecting this driver will be > present: > > In file included from include/linux/elevator.h:6, > from include/linux/blkdev.h:288, > from include/linux/blk-cgroup.h:23, > from include/linux/writeback.h:14, > from include/linux/memcontrol.h:22, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from include/linux/regulator/consumer.h:35, > from drivers/crypto/ux500/hash/hash_core.c:28: > > include/linux/elevator.h pulls in include/linux/hashtable.h which > contains its own version of hash_init(). This confuses the build > system and results in the following error (amongst others): > > drivers/crypto/ux500/hash/hash_core.c:1362:19: error: passing argument 1 of '__hash_init' from incompatible pointer type [-Werror=incompatible-pointer-types] > 1362 | return hash_init(req); > > Fix this by namespacing the local hash_init() such that the > source of confusion is removed. > > Cc: Linus Walleij > Cc: Herbert Xu > Cc: David S. Miller > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones This looks reasonable. Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B2CC433E0 for ; Mon, 29 Jun 2020 14:00:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1060323D51 for ; Mon, 29 Jun 2020 14:00:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PkV5Sz5t"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bEMO9AAn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1060323D51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1/Wk5Jo0SmIIgNl7ViVC4NO6itDi9F1MmmGjz8rngWA=; b=PkV5Sz5tf11NItvhfHVJNZmYO z3oU9fvEaI4MVjaBFMIgzwelEsoi0oRDuPAplg6D3+yYv8nuwGRIs5Rrk71yEEJ9QRIvt1VMrdVe1 ltzt8WiPXsaQSSlwk+QNOy+S9CcEyiZfrbTYb1TSBg1dkMyregklbxzcGGD8yw+UuTl1HwfS1z7G4 TJUzbg1adp40gWOJ1HdtsBv0vMZYJrWY5Uo5UEfHssAB73vTVRj/tifGzi3uDXlLHUhfNmW98GCjm XQKSaxjkWXhytiystkhu76JXw88S62bahDVXcZMJeHjjC7UruQipkBRPXmEv7Mtj+1szzl/FM13FR EsEUaMG3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuId-0003O7-G4; Mon, 29 Jun 2020 13:58:19 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpuIa-0003Ni-J8 for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 13:58:17 +0000 Received: by mail-lj1-x244.google.com with SMTP id h22so10969347lji.9 for ; Mon, 29 Jun 2020 06:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uCQ8gnTNmCbw3Jp4/ShmxDGjAQ3pvSFd1R7iQkCtV0o=; b=bEMO9AAnWp5LTsNLVdXW9Oe7mzKQhGXAj0e5OEmfEtAkG1cNaFNZSh2Qdo5mWbPuMY 9DiqUdT+MsXYwleFvjrGxmVJqwyvuKXhxlQUK3rtF7VdMnvX7cTOhwoxwrJJLOVzNu5i 2XK9FlT9eHx+sLquBViH/xZ5rB5rAhbPqcP9GuagM0OXFUt9wlcNzUKNy1aLnFdNwo+V 8Ruz/vdEgYh0uNq8BnFoCh6EqK2N49EfB0DJU88m7ryxOsAPu8lNbY+iq10lCSBY9Mui ZPg6x5swpeRbq9anXoM2U2j46UxRzipSI496ZyBwvvY+KYVNwgj+Iwoz/AD7OkkAul0p isLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uCQ8gnTNmCbw3Jp4/ShmxDGjAQ3pvSFd1R7iQkCtV0o=; b=sIpXnmhZeX0UuNPrEda5D/OyDyCRHstl2pcgweWKUXIwdZ6kimnjmpWw9IyMW8rdN3 xKRlzFfMb/2R+Wvrcnd1VLlTWCcqLhjGWmnx9zhJW78sxnN0Z3XE4c9LRZkAzij9ItLD F4vI+RX/gD+pzz8bB1f0lFXUFINpPhZ3aqD5PP6/HYn42H9hasJ/CFq2ZQb5om2e9b3M LPS+qePyfXgwdlSgat3HW6ACFPbzHuWRSI3j7QgLoTxHBLmpERUD+mTSPGFjhJDxGseY /QpHPPkuJZIV9ovKumXFeu7wJAXR4eb3bs6lh2BsrxrwZADHGrk0Tk0Yv8WPEULsz6qQ 54+g== X-Gm-Message-State: AOAM532gLF7nDxiYaCUY89ACIbWsH3d0LMWsHAlzjc/oLuravBeYTm5b 9sb4UP6rm/OYOpCW+2VKfD7nFBJhItqQI7m9y+8YLw== X-Google-Smtp-Source: ABdhPJyszh+KKJKX6JxEpQEiu36tPTXZ+lFvnrC92R82eADyKCIBV3+TFvVd2yAYiyqz2uUbOeMX15KpV7G5lmjJkoI= X-Received: by 2002:a2e:3504:: with SMTP id z4mr8452019ljz.283.1593439093501; Mon, 29 Jun 2020 06:58:13 -0700 (PDT) MIME-Version: 1.0 References: <20200629123003.1014387-1-lee.jones@linaro.org> In-Reply-To: <20200629123003.1014387-1-lee.jones@linaro.org> From: Linus Walleij Date: Mon, 29 Jun 2020 15:58:02 +0200 Message-ID: Subject: Re: [PATCH 1/1] crypto: ux500: hash: Add namespacing to hash_init() To: Lee Jones X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-crypto@vger.kernel.org, "David S . Miller" , "linux-kernel@vger.kernel.org" , Linux ARM , Herbert Xu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 2:30 PM Lee Jones wrote: > A recent change to the Regulator consumer API (which this driver > utilises) add prototypes for the some suspend functions. These > functions require including header file include/linux/suspend.h. > > The following tree of includes affecting this driver will be > present: > > In file included from include/linux/elevator.h:6, > from include/linux/blkdev.h:288, > from include/linux/blk-cgroup.h:23, > from include/linux/writeback.h:14, > from include/linux/memcontrol.h:22, > from include/linux/swap.h:9, > from include/linux/suspend.h:5, > from include/linux/regulator/consumer.h:35, > from drivers/crypto/ux500/hash/hash_core.c:28: > > include/linux/elevator.h pulls in include/linux/hashtable.h which > contains its own version of hash_init(). This confuses the build > system and results in the following error (amongst others): > > drivers/crypto/ux500/hash/hash_core.c:1362:19: error: passing argument 1 of '__hash_init' from incompatible pointer type [-Werror=incompatible-pointer-types] > 1362 | return hash_init(req); > > Fix this by namespacing the local hash_init() such that the > source of confusion is removed. > > Cc: Linus Walleij > Cc: Herbert Xu > Cc: David S. Miller > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones This looks reasonable. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel