From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754971AbaICIOA (ORCPT ); Wed, 3 Sep 2014 04:14:00 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:58038 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbaICIN4 (ORCPT ); Wed, 3 Sep 2014 04:13:56 -0400 MIME-Version: 1.0 In-Reply-To: <1409159852-7249-3-git-send-email-mathieu.poirier@linaro.org> References: <1409159852-7249-1-git-send-email-mathieu.poirier@linaro.org> <1409159852-7249-3-git-send-email-mathieu.poirier@linaro.org> Date: Wed, 3 Sep 2014 10:13:55 +0200 Message-ID: Subject: Re: [PATCH 02/11 v5] coresight-tmc: add CoreSight TMC driver From: Linus Walleij To: Mathieu Poirier Cc: Thomas Petazzoni , Will Deacon , Russell King - ARM Linux , Greg KH , Arnd Bergmann , Robert Marklund , Al Grant , Patch Tracking , Marcin Jabrzyk , "linux-kernel@vger.kernel.org" , Panchaxari Prasannamurthy Tumkur , r.sengupta@samsung.com, Tony.Armitstead@arm.com, John Stultz , "linux-arm-kernel@lists.infradead.org" , James King , Pratik Patel , Vikas Varshney , Jonas Svennebring , Kaixu Xia Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 27, 2014 at 7:17 PM, wrote: > From: Pratik Patel > > This driver manages CoreSight TMC (Trace Memory Controller) which > can act as a link or a sink depending upon its configuration. It > can present itself as an ETF (Embedded Trace FIFO) or ETR > (Embedded Trace Router). > > ETF when configured in circular buffer mode acts as a trace > collection sink. When configured in HW fifo mode it acts as link. > ETR always acts as a sink and can be used to route data to memory > allocated in RAM. > > Signed-off-by: Pratik Patel > Signed-off-by: Panchaxari Prasannamurthy > Signed-off-by: Mathieu Poirier This looks good to me now. Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Wed, 3 Sep 2014 10:13:55 +0200 Subject: [PATCH 02/11 v5] coresight-tmc: add CoreSight TMC driver In-Reply-To: <1409159852-7249-3-git-send-email-mathieu.poirier@linaro.org> References: <1409159852-7249-1-git-send-email-mathieu.poirier@linaro.org> <1409159852-7249-3-git-send-email-mathieu.poirier@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 27, 2014 at 7:17 PM, wrote: > From: Pratik Patel > > This driver manages CoreSight TMC (Trace Memory Controller) which > can act as a link or a sink depending upon its configuration. It > can present itself as an ETF (Embedded Trace FIFO) or ETR > (Embedded Trace Router). > > ETF when configured in circular buffer mode acts as a trace > collection sink. When configured in HW fifo mode it acts as link. > ETR always acts as a sink and can be used to route data to memory > allocated in RAM. > > Signed-off-by: Pratik Patel > Signed-off-by: Panchaxari Prasannamurthy > Signed-off-by: Mathieu Poirier This looks good to me now. Reviewed-by: Linus Walleij Yours, Linus Walleij