From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size Date: Thu, 26 Apr 2018 11:06:05 +0200 Message-ID: References: <20180405120012.7671-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180405120012.7671-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: William Breathitt Gray , "open list:GPIO SUBSYSTEM" , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Thu, Apr 5, 2018 at 2:00 PM, Colin King wrote: > From: Colin Ian King > > Don't populate the const read-only array 'ports' on the stack but instead > make it static. Makes the object code smaller by over 100 buytes: > > Before: > text data bss dec hex filename > 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o > > After: > text data bss dec hex filename > 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o > > (gcc version 7.2.0 x86_64) > > Signed-off-by: Colin Ian King Patch applied with William's ACK. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Date: Thu, 26 Apr 2018 09:06:05 +0000 Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size Message-Id: List-Id: References: <20180405120012.7671-1-colin.king@canonical.com> In-Reply-To: <20180405120012.7671-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: William Breathitt Gray , "open list:GPIO SUBSYSTEM" , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" On Thu, Apr 5, 2018 at 2:00 PM, Colin King wrote: > From: Colin Ian King > > Don't populate the const read-only array 'ports' on the stack but instead > make it static. Makes the object code smaller by over 100 buytes: > > Before: > text data bss dec hex filename > 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o > > After: > text data bss dec hex filename > 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o > > (gcc version 7.2.0 x86_64) > > Signed-off-by: Colin Ian King Patch applied with William's ACK. Yours, Linus Walleij