From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840A9C00144 for ; Tue, 26 Jul 2022 20:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbiGZU7x (ORCPT ); Tue, 26 Jul 2022 16:59:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbiGZU7x (ORCPT ); Tue, 26 Jul 2022 16:59:53 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24AE839BB7 for ; Tue, 26 Jul 2022 13:59:52 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id w5so6685298edd.13 for ; Tue, 26 Jul 2022 13:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GZVMmT66zBWHeS9bYbeyt7i6nEjBhxBa3DLSXKxsnGY=; b=PUBNT3UA/hm6rgJwFdHGBKRDIwlPEWalDAxwase+0PDZRVNtJcQYBCctt9UTnC3aIx uURsOnlDPXZLJMSTiBzCrn4YPDDQubGnEdo6hZOmCUAs5evoOGu6ZT60RIJYvbeeWKoR T2r2a2n0cidAd6zsnRkyH1v9BvKu38MHhpVyTrmujdu+avY8RVVx4SigE4P4UDBfRVxb +tFSJTBv2hXCQc5QGnj0+xevw2Tef6Aijokp2STNMeJO6KwJSm+tyePeETerlkPyX0QW Zh2etfeex1GmP0PCSKTL910YI5Wafa8ns2ZZZSiIA4UThDdkA3n2ooZG5jk1LpfdVMrb g5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GZVMmT66zBWHeS9bYbeyt7i6nEjBhxBa3DLSXKxsnGY=; b=jiCHp28JWiLt6ZwPbZEpG+Z4f0r0sXItXsqgW3GhR3VjdyHLisAjhpissP0KW9qstA dUJ/Fs+0VR6dYKB9YiC353ZXHBINi7OR2kbcYgMEY28xOZCTBj6CARjl+w9ySC0Vr8Z6 UEFWN3GN5UEzpzrn1w8NVdjnbbBS3cnpyXWoJjpP9lH2YW3XmA4JMiatMsn9bIYBtCiZ cVNG+A2M7QCXGxQJoZ3jMAb6VjcJBQTatU7DTbvr1pEQiWmuoy86M/mwEMl67F+uPnnt 0l1Fn34M2VVaiJ2qEkoju6HaPgznTiD5of682ntf4cfOcrMcboNnV6xaknzPMix3T2Mj 3zfQ== X-Gm-Message-State: AJIora/OqY0kX0/CijlrOdLjtSZM0OH3IxDe8BblwjRb+fkj15ItP6Sv /ii51DC+jEhEarJjBgxjEf98nDRrKPU6X/MwNy/XiA== X-Google-Smtp-Source: AGRyM1sT3FhoWF3hnt19aN3uyT78QBBuLpQPSm3rExd8W3R1tzH6g6cSAgfxlzV1G4HEGtowZUivOh+eQFO69BjBolM= X-Received: by 2002:a05:6402:2696:b0:43b:eb8b:d0da with SMTP id w22-20020a056402269600b0043beb8bd0damr13547357edd.158.1658869190580; Tue, 26 Jul 2022 13:59:50 -0700 (PDT) MIME-Version: 1.0 References: <20220724224943.294057-1-marex@denx.de> <20220724224943.294057-2-marex@denx.de> In-Reply-To: <20220724224943.294057-2-marex@denx.de> From: Linus Walleij Date: Tue, 26 Jul 2022 22:59:39 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode To: Marek Vasut Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , Loic Poulain , Marc Zyngier , NXP Linux Team , Peng Fan , Shawn Guo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jul 25, 2022 at 12:50 AM Marek Vasut wrote: > Always configure GPIO pins which are used as interrupt source as INPUTs. > In case the default pin configuration is OUTPUT, or the prior stage does > configure the pins as OUTPUT, then Linux will not reconfigure the pin as > INPUT and no interrupts are received. > > Always configure interrupt source GPIO pin as input to fix the above case. > > Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") > Signed-off-by: Marek Vasut > Cc: Bartosz Golaszewski > Cc: Linus Walleij > Cc: Loic Poulain > Cc: Marc Zyngier > Cc: NXP Linux Team > Cc: Peng Fan > Cc: Shawn Guo It's up to the driver to deal with the final hardware state, and the author knows what he's doing so: Reviewed-by: Linus Walleij Yours, Linus Walleij