From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E7EC388F9 for ; Wed, 11 Nov 2020 13:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D55CE2065C for ; Wed, 11 Nov 2020 13:45:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BB2uPR6f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726273AbgKKNpE (ORCPT ); Wed, 11 Nov 2020 08:45:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726595AbgKKNpB (ORCPT ); Wed, 11 Nov 2020 08:45:01 -0500 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D535C0613D4 for ; Wed, 11 Nov 2020 05:45:01 -0800 (PST) Received: by mail-lf1-x141.google.com with SMTP id z21so3161485lfe.12 for ; Wed, 11 Nov 2020 05:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o4pDcFw9HNJ9VZhUYbY68fNV22nURMzm7OHDvRMvP4Y=; b=BB2uPR6fQqjMPJ9SwsH0x+Brfy1dMCoYWH1zHacL431t1vv+BdhvfMB9Wvp9PkrwW+ ep+dxiAsL5ID/rg44XJGqtGOkWop43BCGTgzOH3QVSdOOUEShCRXnWvkcHlmd3hI+VAD cApW/F1BgwtK5+MVx5b4p0rs6Ob1EFM5L9/bcxM5CPCBwUlzbTo6rgS7o+mStsVQkpL+ 0JIDgYlbkSLudu6i2pltrxb9bfEE3kTc+AAUSo/PsPNo3lGogNoOD/OsaZUBecHSCo4L itsgwts2KQq5kojVcqwnElXClMzF+JbWpfuQKkf3YzBJjP7YAN+2M0bEAlIVldx3KD8J vB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o4pDcFw9HNJ9VZhUYbY68fNV22nURMzm7OHDvRMvP4Y=; b=mTF0djps33Jbs3NB2vE4XjFJ3cFxkRQ08qX8iu/2whEY7Ypb364QSrVnuhCZjDIMwa xMfgIRqfiKO2ZCDqfM0k0VtOaelQqTQkfubpSBqguIpLsEI7DHRw7asc/mXimYMLSfja s593Ht0hFwN6GMKFndvIFjTP5XPPjBYImkg9TpFC4ByFZ2GjRP65SAt0+edKHYR28nn1 og6ZPyd+ClhrlR4OGUPARe8E9RSu8R8BblbiqPJ2+LOgME4BH9nVkrPevnxb4BtG3y9t iFSZsW9hEGEWCvZtfP6oEoRpbDE3AWaqjXMXSj+trpJqOTu42HUTKUgZdIvdE2O6RUz+ KSZg== X-Gm-Message-State: AOAM5310XQwSVKwCjuqBwQRBEHlq8NbS37SVwCKclrXRbJRoTUVbXBC8 QzToQM4SWAwNuAxPJiKt4tzPUaW+JO3pciQQpmJgMg== X-Google-Smtp-Source: ABdhPJywsbPI2EsBy4HIDztooOemIt50wpEyeH0GKUIy1cOETjKXheDLol+ph4p9W432swIOJeQZuMQvZTy+ZimRQ9o= X-Received: by 2002:a19:546:: with SMTP id 67mr628485lff.502.1605102300001; Wed, 11 Nov 2020 05:45:00 -0800 (PST) MIME-Version: 1.0 References: <20201111011417.2275501-1-linus.walleij@linaro.org> <20201111110412.GW6899@valkosipuli.retiisi.org.uk> In-Reply-To: <20201111110412.GW6899@valkosipuli.retiisi.org.uk> From: Linus Walleij Date: Wed, 11 Nov 2020 14:44:48 +0100 Message-ID: Subject: Re: [PATCH 1/2 v3] dt-bindings: leds: Add DT binding for Richtek RT8515 To: Sakari Ailus Cc: Jacek Anaszewski , Pavel Machek , Dan Murphy , Linux LED Subsystem , newbytee@protonmail.com, Stephan Gerhold , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, Nov 11, 2020 at 12:05 PM Sakari Ailus wrote: > On Wed, Nov 11, 2020 at 02:14:16AM +0100, Linus Walleij wrote: > > Add a YAML devicetree binding for the Richtek RT8515 > > dual channel flash/torch LED driver. > > + led: > > + type: object > > + $ref: common.yaml# > > + properties: > > + function: true > > + color: true > > + flash-max-timeout-us: true > > Don't you also need flash-max-microamp and led-max-microamp? As the maximum > current for the LED may well be less than the driver can provide. I wish I could add that. The problem is that we don't know anything about the microamps for this Richtek component. There is no public datasheet available. I have asked Richtek, they answered as follows: "RT8515 had EOL already. So, we couldn't provide the datasheet. Thank you." I do not quite understand their answer but they at least answered. I have a few out-of-tree drivers, from Asus Zenfone, and from the numerous Samsung mobiles using this. None of the outoftree code makes any reference to the actual microamperes. They make a setting from 1..100 "units" and that is handled by some kind of userspace that I do not have the code for. If someone knows of a source code for this userspace I would be happy to take a look so we can at least figure out if it is linear. Yours, Linus Walleij