From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34AC8C07E94 for ; Fri, 4 Jun 2021 07:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15AB461417 for ; Fri, 4 Jun 2021 07:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbhFDHci (ORCPT ); Fri, 4 Jun 2021 03:32:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbhFDHch (ORCPT ); Fri, 4 Jun 2021 03:32:37 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 464FBC061760 for ; Fri, 4 Jun 2021 00:30:51 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id e11so10323037ljn.13 for ; Fri, 04 Jun 2021 00:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DZr8jgm34p9ETGtBFysNOPM5B3RJwjxp8XPNUWrmeII=; b=asinqHupqJSk8yrmxWFMRFGpKhsAc5mL2dod9IeAxLAtYx3jBovWnObrHekW7WtZdz coKx84Y77Dje7MQgBMXYa+BtHxQFmxNiGvt8yHP1Q45DwuQqxF9ICgw5Pcz0TKELu8TS Jwo0vdRQIG1AuOg0jNylKyf3P0aanVkxF9OsKTv/qxo+L4LWPmxkbd14t22TgBgR0vMH GT7dS2QMt9g8lNx13nRP7JNDrm2mYRy7PvtObSCDFip8Qg2m2+bV8j4lgsQ5j8N8R8uh Ek3E0M+L2Stw1ELyLeLHYkvxypKj5X9iXzDEJg4W6SzOfdhTGVs23L2dBECT+0wcAmba wbyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DZr8jgm34p9ETGtBFysNOPM5B3RJwjxp8XPNUWrmeII=; b=lz5o01Wgxwb/c8J+c8Ja45gVploomIi5KzJK/VtbAphNODjD/1N+OIjqWDuMPsPySC dBxfRFWuUvRuUYaIptlqA3ISxi7PYTecwUCD2zX7qvTNCF/Z/wadP6C3l9WhpPXfbVUN vjc42iYT7gNGwejJlqwTA1wLWdu9P+DhOF4qAH0ct7IF5NroipUM6qGs6EKfJ4ni00Po YfQugHzRFrj8HSxGaC3eC0yVw3RCBcQgmlN1pEuk/3liS6lOAngdoiAF28fPFmocqsqp tYIxPJE5CnexSI+f48sKOcHFbHjsIQAoJGsbJymX+CAQW7HvPYOtJSlr7EGHG0hV8zLc sdeQ== X-Gm-Message-State: AOAM530SJf5/0S93p27RcuQsYvYUE896OFPQ6yeGfzAi3i6/pE0bKE24 +aleofpbByBgwJYyYmti/DtVz1A8loXl54lryP5g2g== X-Google-Smtp-Source: ABdhPJwHbDhon5irujLUGv5DiJtxz7mkeuhyP2cA8YfJFvDCcowwNCw+Y4ZZ87a0DCRU9XDjW20ZMmxHd2w6fxUmcCU= X-Received: by 2002:a05:651c:1501:: with SMTP id e1mr2617160ljf.74.1622791845014; Fri, 04 Jun 2021 00:30:45 -0700 (PDT) MIME-Version: 1.0 References: <20210603043726.3793876-1-dmitry.torokhov@gmail.com> In-Reply-To: <20210603043726.3793876-1-dmitry.torokhov@gmail.com> From: Linus Walleij Date: Fri, 4 Jun 2021 09:30:34 +0200 Message-ID: Subject: Re: [PATCH 1/7] Input: cy8ctmg110_ts - rely on platform code to supply interrupt To: Dmitry Torokhov Cc: Linux Input , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, I see you noticed that there is no upstream board defining any cy8ctmg110_pdata, so I don't see any problem with fixing this. Outoftree users can adopt. On Thu, Jun 3, 2021 at 6:37 AM Dmitry Torokhov wrote: > > Instead of using platform data to specify GPIO that is used as interrupt > source, rely on the platform and I2C core to set it up properly. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Linus Walleij > - client->irq = gpio_to_irq(ts->irq_pin); This looks like a violation of the struct anyway.... Yours, Linus Walleij